HBASE-22185 RAMQueueEntry#writeToCache should freeBlock if any exception encountered instead of the IOException catch block

[openinx]

No description provided.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	139	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	280	master passed
+1	compile	55	master passed
+1	checkstyle	70	master passed
+1	shadedjars	266	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	148	master passed
+1	javadoc	35	master passed
		_ Patch Compile Tests _
+1	mvninstall	255	the patch passed
+1	compile	54	the patch passed
+1	javac	54	the patch passed
+1	checkstyle	70	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	267	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	547	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	154	the patch passed
+1	javadoc	34	the patch passed
		_ Other Tests _
-1	unit	18725	hbase-server in the patch failed.
+1	asflicense	33	The patch does not generate ASF License warnings.
		21215

Reason	Tests
Failed junit tests	hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL
	hadoop.hbase.replication.TestReplicationDisableInactivePeer
	hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
	hadoop.hbase.replication.TestReplicationSmallTests
	hadoop.hbase.client.TestFromClientSide3
	hadoop.hbase.client.TestCloneSnapshotFromClientNormal
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.namespace.TestNamespaceAuditor
	hadoop.hbase.client.TestFromClientSideWithCoprocessor
	hadoop.hbase.client.TestConnectionImplementation
	hadoop.hbase.client.TestAdmin1
	hadoop.hbase.master.procedure.TestSCPWithReplicas
	hadoop.hbase.replication.TestSyncReplicationStandbyKillMaster
	hadoop.hbase.client.replication.TestReplicationAdminWithClusters
	hadoop.hbase.client.TestAsyncTableAdminApi
	hadoop.hbase.quotas.TestSpaceQuotas
	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-130/1/artifact/out/Dockerfile
GITHUB PR	#130
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 9888d87fa513 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / 89ce5d1
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-130/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-130/1/testReport/
Max. process+thread count	5342 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-130/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

[Apache9]

A try finally will be better? Usually I will use a succ flag, and set it to true in the last, so in the finally block, if it is not true, then free the block.

[openinx]

A try finally will be better? Usually I will use a succ flag, and set it to true in the last, so in the finally block, if it is not true, then free the block.

OK, let me address this.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	284	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	257	master passed
+1	compile	50	master passed
+1	checkstyle	69	master passed
+1	shadedjars	270	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	152	master passed
+1	javadoc	33	master passed
		_ Patch Compile Tests _
+1	mvninstall	239	the patch passed
+1	compile	54	the patch passed
+1	javac	54	the patch passed
+1	checkstyle	69	hbase-server: The patch generated 0 new + 44 unchanged - 1 fixed = 44 total (was 45)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	266	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	522	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	157	the patch passed
+1	javadoc	31	the patch passed
		_ Other Tests _
-1	unit	16333	hbase-server in the patch failed.
+1	asflicense	27	The patch does not generate ASF License warnings.
		18872

Reason	Tests
Failed junit tests	hadoop.hbase.master.procedure.TestSCPWithReplicas
	hadoop.hbase.namespace.TestNamespaceAuditor
	hadoop.hbase.client.TestAdmin1
	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.master.TestSplitWALManager

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-130/2/artifact/out/Dockerfile
GITHUB PR	#130
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux db079f5de10d 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / 89ce5d1
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-130/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-130/2/testReport/
Max. process+thread count	5483 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-130/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

[Apache9]

@openinx You have committed directly with command line? Then please close the PR?

[openinx]

@Apache9 OK, will do , not finish yet.