Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24030 Add necessary validations to HRegion.checkAndMutate() and… #1315

Merged
merged 1 commit into from
Mar 22, 2020
Merged

HBASE-24030 Add necessary validations to HRegion.checkAndMutate() and… #1315

merged 1 commit into from
Mar 22, 2020

Conversation

brfrn169
Copy link
Member

… HRegion.checkAndRowMutate()

@Apache-HBase

This comment has been minimized.

Sign in to view
virajjasani
virajjasani reviewed Mar 21, 2020
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, a minor comment

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java Show resolved Hide resolved
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
virajjasani
virajjasani approved these changes Mar 21, 2020
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, pending QA

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 38s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 6m 26s master passed
+1 💚 compile 1m 5s master passed
+1 💚 shadedjars 5m 31s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 39s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 6m 3s the patch passed
+1 💚 compile 1m 5s the patch passed
+1 💚 javac 1m 5s the patch passed
+1 💚 shadedjars 5m 26s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 37s the patch passed
_ Other Tests _
+1 💚 unit 93m 14s hbase-server in the patch passed.
123m 34s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1315/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1315
Optional Tests javac javadoc unit shadedjars compile
uname Linux 47629d66b66d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5592d0c
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1315/3/testReport/
Max. process+thread count 4315 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1315/3/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@brfrn169
Copy link
Member Author

Looks the QA is okay.

@HorizonNet I will merge this if you are okay. Thanks.

@brfrn169 brfrn169 merged commit 9b4e75a into apache:master Mar 22, 2020
@brfrn169
Copy link
Member Author

Merged. Thank you for reviewing this! @virajjasani @HorizonNet

asfgit pushed a commit that referenced this pull request Mar 22, 2020
@brfrn169
HBASE-24030 Add necessary validations to HRegion.checkAndMutate() and…
5104aa8 
… HRegion.checkAndRowMutate() (#1315)

Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Jan Hentschel <janh@apache.org>
asfgit pushed a commit that referenced this pull request Mar 22, 2020
@brfrn169
HBASE-24030 Add necessary validations to HRegion.checkAndMutate() and…
f5e9b3b 
… HRegion.checkAndRowMutate() (#1315)

Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Jan Hentschel <janh@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@brfrn169 @thangTang
HBASE-24030 Add necessary validations to HRegion.checkAndMutate() and…
9fac9d1 
… HRegion.checkAndRowMutate() (apache#1315)

Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Jan Hentschel <janh@apache.org>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@brfrn169 @thangTang
HBASE-24030 Add necessary validations to HRegion.checkAndMutate() and…
d06e369 
… HRegion.checkAndRowMutate() (apache#1315)

Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Jan Hentschel <janh@apache.org>
@brfrn169 brfrn169 self-assigned this Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HorizonNet HorizonNet HorizonNet approved these changes

@virajjasani virajjasani virajjasani approved these changes

Assignees

@brfrn169 brfrn169

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@brfrn169 @Apache-HBase @HorizonNet @virajjasani