Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22203 Reformatted DemoClient.java #137

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

HorizonNet
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 53 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 mvninstall 92 root in master failed.
-1 compile 28 hbase-examples in master failed.
+1 checkstyle 18 master passed
+1 shadedjars 357 branch has no errors when building our shaded downstream artifacts.
-1 findbugs 22 hbase-examples in master failed.
+1 javadoc 20 master passed
_ Patch Compile Tests _
-1 mvninstall 92 root in the patch failed.
-1 compile 25 hbase-examples in the patch failed.
-1 javac 25 hbase-examples in the patch failed.
-1 checkstyle 14 hbase-examples: The patch generated 17 new + 5 unchanged - 237 fixed = 22 total (was 242)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 336 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 54 The patch causes 10 errors with Hadoop v2.7.4.
-1 hadoopcheck 111 The patch causes 10 errors with Hadoop v3.0.0.
-1 findbugs 22 hbase-examples in the patch failed.
+1 javadoc 20 the patch passed
_ Other Tests _
-1 unit 25 hbase-examples in the patch failed.
+1 asflicense 11 The patch does not generate ASF License warnings.
1332
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/1/artifact/out/Dockerfile
GITHUB PR #137
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 1df79efe9f77 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / bf5af14
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/1/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/1/artifact/out/branch-compile-hbase-examples.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/1/artifact/out/branch-findbugs-hbase-examples.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/1/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/1/artifact/out/patch-compile-hbase-examples.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/1/artifact/out/patch-compile-hbase-examples.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/1/artifact/out/diff-checkstyle-hbase-examples.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/1/artifact/out/patch-javac-2.7.4.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/1/artifact/out/patch-javac-3.0.0.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/1/artifact/out/patch-findbugs-hbase-examples.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/1/artifact/out/patch-unit-hbase-examples.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/1/testReport/
Max. process+thread count 78 (vs. ulimit of 10000)
modules C: hbase-examples U: hbase-examples
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Apr 11, 2019

Hey @HorizonNet , Please resolve some of the PRs before opening new one? I see lots of your PRs have already been approved so please merge them and cherry-pick to relevant branches?

Thanks.

@HorizonNet
Copy link
Contributor Author

@Apache9 Will do it later today. Didn't do it yet, because I was also the author of the PRs.

@Apache9
Copy link
Contributor

Apache9 commented Apr 11, 2019

You just need another committer to approve your changes, but you'd better merge it by yourself :)

@HorizonNet
Copy link
Contributor Author

Ok, will do that. It's been a while since I did that and didn't know if with GitHub something has changed about the process (haven't seen it on the mailing list).

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 25 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0 mvndep 25 Maven dependency ordering for branch
+1 mvninstall 242 master passed
+1 compile 31 master passed
+1 checkstyle 133 master passed
+1 shadedjars 259 branch has no errors when building our shaded downstream artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hbase-checkstyle
+1 findbugs 34 master passed
+1 javadoc 27 master passed
_ Patch Compile Tests _
0 mvndep 17 Maven dependency ordering for patch
+1 mvninstall 241 the patch passed
+1 compile 36 the patch passed
+1 javac 36 the patch passed
+1 checkstyle 134 root: The patch generated 0 new + 5 unchanged - 237 fixed = 5 total (was 242)
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedjars 262 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 500 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
0 findbugs 0 Skipped patched modules with no Java source: hbase-checkstyle
+1 findbugs 42 the patch passed
+1 javadoc 29 the patch passed
_ Other Tests _
+1 unit 12 hbase-checkstyle in the patch passed.
+1 unit 87 hbase-examples in the patch passed.
+1 asflicense 23 The patch does not generate ASF License warnings.
2248
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/2/artifact/out/Dockerfile
GITHUB PR #137
Optional Tests dupname asflicense checkstyle javac javadoc unit xml findbugs shadedjars hadoopcheck hbaseanti compile
uname Linux 2c0d14e7863b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / fc6e3fc
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/2/testReport/
Max. process+thread count 2298 (vs. ulimit of 10000)
modules C: hbase-checkstyle hbase-examples U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@saintstack
Copy link
Contributor

+1 from me. Thanks for the cleanup.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 37 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0 mvndep 29 Maven dependency ordering for branch
+1 mvninstall 269 master passed
+1 compile 34 master passed
+1 checkstyle 153 master passed
+1 shadedjars 276 branch has no errors when building our shaded downstream artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hbase-checkstyle
+1 findbugs 36 master passed
+1 javadoc 29 master passed
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
+1 mvninstall 261 the patch passed
+1 compile 34 the patch passed
+1 javac 34 the patch passed
+1 checkstyle 149 root: The patch generated 0 new + 5 unchanged - 237 fixed = 5 total (was 242)
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedjars 273 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 544 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
0 findbugs 0 Skipped patched modules with no Java source: hbase-checkstyle
+1 findbugs 41 the patch passed
+1 javadoc 30 the patch passed
_ Other Tests _
+1 unit 11 hbase-checkstyle in the patch passed.
+1 unit 104 hbase-examples in the patch passed.
+1 asflicense 21 The patch does not generate ASF License warnings.
2434
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/3/artifact/out/Dockerfile
GITHUB PR #137
Optional Tests dupname asflicense checkstyle javac javadoc unit xml findbugs shadedjars hadoopcheck hbaseanti compile
uname Linux 2ac25c8b5a67 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / f77bde3
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/3/testReport/
Max. process+thread count 2671 (vs. ulimit of 10000)
modules C: hbase-checkstyle hbase-examples U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-137/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet HorizonNet merged commit f227eb7 into apache:master Apr 12, 2019
@HorizonNet HorizonNet deleted the HBASE-22203 branch April 12, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants