HBASE-24174 Fix findbugs warning on ServiceAuthorizationManager for master branch #1537

Reidddddd · 2020-04-17T06:11:43Z

No description provided.

…aster branch

Apache-HBase · 2020-04-17T06:46:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 37s	master passed
+1 💚	checkstyle	1m 7s	master passed
+1 💚	spotbugs	2m 1s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 14s	the patch passed
+1 💚	checkstyle	1m 3s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	5m 22s	Patch does not cause any errors with Hadoop 3.1.2.
-1 ❌	spotbugs	2m 10s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		26m 21s

Reason	Tests
FindBugs	module:hbase-server
	Inconsistent synchronization of org.apache.hadoop.hbase.ipc.RpcServer.authManager; locked 71% of time Unsynchronized access at RpcServer.java:71% of time Unsynchronized access at RpcServer.java:[line 599]

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1537
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 9e627464c0d9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b7a6d36`
spotbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

binlijin · 2020-04-17T07:06:36Z

hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java

@@ -597,7 +592,7 @@ public void addCallSize(final long diff) {
   * @param addr InetAddress of incoming connection
   * @throws AuthorizationException when the client isn't authorized to talk the protocol
   */
-  public void authorize(UserGroupInformation user, ConnectionHeader connection,
+  public synchronized void authorize(UserGroupInformation user, ConnectionHeader connection,


Add synchronized to this method, the " synchronized (authManager) { } " in the method can removed?

Oh yes, should do. Will fix in next commit.

binlijin · 2020-04-17T07:31:56Z

LGTM, let see the QA report.

Apache-HBase · 2020-04-17T09:51:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 58s	master passed
+1 💚	compile	0m 58s	master passed
+1 💚	shadedjars	5m 29s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 58s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	shadedjars	5m 30s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
-1 ❌	unit	186m 23s	hbase-server in the patch failed.
		211m 35s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1537
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 51176d9bc766 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b7a6d36`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/testReport/
Max. process+thread count	3010 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-17T10:39:33Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 57s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 15s	master passed
+1 💚	compile	1m 48s	master passed
+1 💚	shadedjars	7m 10s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 56s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 2s	the patch passed
+1 💚	compile	1m 37s	the patch passed
+1 💚	javac	1m 37s	the patch passed
+1 💚	shadedjars	7m 20s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 56s	hbase-server in the patch failed.
		_ Other Tests _
-1 ❌	unit	222m 3s	hbase-server in the patch failed.
		259m 9s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1537
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e41f84eec502 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b7a6d36`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/testReport/
Max. process+thread count	2874 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-17T11:08:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 40s	master passed
+1 💚	checkstyle	1m 6s	master passed
+1 💚	spotbugs	1m 59s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 18s	the patch passed
+1 💚	checkstyle	1m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	5m 26s	Patch does not cause any errors with Hadoop 3.1.2.
+1 💚	spotbugs	2m 7s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		26m 34s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1537
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux e39eaeb901f4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `12aad76`
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1, pending QA

Apache-HBase · 2020-04-17T14:30:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 11s	master passed
+1 💚	compile	0m 58s	master passed
+1 💚	shadedjars	5m 33s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 53s	the patch passed
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
+1 💚	shadedjars	5m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	202m 43s	hbase-server in the patch passed.
		228m 29s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1537
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8cdf49e2a682 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `12aad76`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/2/testReport/
Max. process+thread count	2819 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-17T14:36:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 56s	master passed
+1 💚	compile	1m 15s	master passed
+1 💚	shadedjars	5m 50s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 47s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 42s	the patch passed
+1 💚	compile	1m 14s	the patch passed
+1 💚	javac	1m 14s	the patch passed
+1 💚	shadedjars	6m 7s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 50s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	205m 2s	hbase-server in the patch passed.
		234m 8s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1537
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a16509d2f749 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `12aad76`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/2/testReport/
Max. process+thread count	2697 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1537/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…aster branch (apache#1537) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>

…aster branch (#1537) (#1542) Signed-off-by: binlijin <binlijin@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: stack <stack@apache.org>

HBASE-24174 Fix findbugs warning on ServiceAuthorizationManager for m…

ed915d7

…aster branch

Add synchronized for authorize method

db9198d

binlijin reviewed Apr 17, 2020

View reviewed changes

Remove synchronized(authManager) in authorize method

bee0c53

virajjasani approved these changes Apr 17, 2020

View reviewed changes

Reidddddd merged commit db36cf7 into apache:master Apr 17, 2020

Reidddddd deleted the master-HBASE-24174 branch April 17, 2020 17:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24174 Fix findbugs warning on ServiceAuthorizationManager for master branch #1537

HBASE-24174 Fix findbugs warning on ServiceAuthorizationManager for master branch #1537

Reidddddd commented Apr 17, 2020

Apache-HBase commented Apr 17, 2020

binlijin Apr 17, 2020

Reidddddd Apr 17, 2020

binlijin commented Apr 17, 2020

Apache-HBase commented Apr 17, 2020

Apache-HBase commented Apr 17, 2020

Apache-HBase commented Apr 17, 2020

virajjasani left a comment

Apache-HBase commented Apr 17, 2020

Apache-HBase commented Apr 17, 2020

HBASE-24174 Fix findbugs warning on ServiceAuthorizationManager for master branch #1537

HBASE-24174 Fix findbugs warning on ServiceAuthorizationManager for master branch #1537

Conversation

Reidddddd commented Apr 17, 2020

Apache-HBase commented Apr 17, 2020

binlijin Apr 17, 2020

Choose a reason for hiding this comment

Reidddddd Apr 17, 2020

Choose a reason for hiding this comment

binlijin commented Apr 17, 2020

Apache-HBase commented Apr 17, 2020

Apache-HBase commented Apr 17, 2020

Apache-HBase commented Apr 17, 2020

virajjasani left a comment

Choose a reason for hiding this comment

Apache-HBase commented Apr 17, 2020

Apache-HBase commented Apr 17, 2020