Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool (adde… #1720

Merged
merged 1 commit into from
May 16, 2020
Merged

HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool (adde… #1720

merged 1 commit into from
May 16, 2020

Conversation

infraio
Copy link
Contributor

@infraio infraio commented May 15, 2020

…ndum)

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 3s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.2 Compile Tests _
+1 💚 mvninstall 5m 48s branch-2.2 passed
+1 💚 compile 0m 23s branch-2.2 passed
+1 💚 checkstyle 0m 28s branch-2.2 passed
+1 💚 shadedjars 4m 40s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 21s branch-2.2 passed
+0 🆗 spotbugs 0m 55s Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌ findbugs 0m 52s hbase-common in branch-2.2 has 1 extant findbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 19s the patch passed
+1 💚 compile 0m 23s the patch passed
+1 💚 javac 0m 23s the patch passed
+1 💚 checkstyle 0m 28s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 25s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 28m 23s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚 javadoc 0m 20s the patch passed
+1 💚 findbugs 0m 55s hbase-common generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
_ Other Tests _
+1 💚 unit 2m 56s hbase-common in the patch passed.
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
66m 34s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1720/1/artifact/out/Dockerfile
GITHUB PR #1720
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 54a29ccb5ddd 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1720/out/precommit/personality/provided.sh
git revision branch-2.2 / a6152af
Default Java 1.8.0_181
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1720/1/artifact/out/branch-findbugs-hbase-common-warnings.html
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1720/1/testReport/
Max. process+thread count 291 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1720/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.2 Compile Tests _
+1 💚 mvninstall 5m 40s branch-2.2 passed
+1 💚 compile 0m 22s branch-2.2 passed
+1 💚 checkstyle 0m 28s branch-2.2 passed
+1 💚 shadedjars 4m 25s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 22s branch-2.2 passed
+0 🆗 spotbugs 0m 52s Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌ findbugs 0m 49s hbase-common in branch-2.2 has 1 extant findbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 16s the patch passed
+1 💚 compile 0m 23s the patch passed
+1 💚 javac 0m 23s the patch passed
+1 💚 checkstyle 0m 27s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 21s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 28m 1s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚 javadoc 0m 21s the patch passed
+1 💚 findbugs 1m 0s hbase-common generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
_ Other Tests _
+1 💚 unit 2m 56s hbase-common in the patch passed.
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
63m 8s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1720/3/artifact/out/Dockerfile
GITHUB PR #1720
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 12f52ffc3372 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1720/out/precommit/personality/provided.sh
git revision branch-2.2 / 43d39ee
Default Java 1.8.0_181
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1720/3/artifact/out/branch-findbugs-hbase-common-warnings.html
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1720/3/testReport/
Max. process+thread count 266 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1720/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@infraio
Copy link
Contributor Author

infraio commented May 15, 2020

findbugs:check passed locally. But failed in precommit job. Let me rerun this check.

@petersomogyi
Copy link
Contributor

findbugs:check passed locally. But failed in precommit job. Let me rerun this check.

Findbugs failed on branch-2.2 but not with your patch. I think the overall -1 is a yetus bug.

hbase-common in branch-2.2 has 1 extant findbugs warnings.
hbase-common generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

@infraio infraio merged commit c79a5d2 into apache:branch-2.2 May 16, 2020
@infraio
Copy link
Contributor Author

infraio commented May 16, 2020

findbugs:check passed locally. But failed in precommit job. Let me rerun this check.

Findbugs failed on branch-2.2 but not with your patch. I think the overall -1 is a yetus bug.

hbase-common in branch-2.2 has 1 extant findbugs warnings.
hbase-common generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

Thanks. Merged it.

HomminLee pushed a commit to HomminLee/hbase that referenced this pull request Jun 12, 2020
@infraio @HomminLee
HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool (adde…
8c5eeb7 
…ndum) (apache#1720)
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@infraio
HBASE-24165 maxPoolSize is logged incorrectly in ByteBufferPool (adde…
3b07c54 
…ndum) (apache#1720)

(cherry picked from commit c79a5d2)

Change-Id: I81dfb7a392446c0f9705b1b06f66bdf99ec516d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HorizonNet HorizonNet HorizonNet approved these changes

@petersomogyi petersomogyi petersomogyi approved these changes

@pankaj72981 pankaj72981 pankaj72981 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@infraio @Apache-HBase @petersomogyi @HorizonNet @pankaj72981