HBASE-22033 Update to maven-javadoc-plugin 3.2.0 and switch to non-forking aggregate goals #1796

busbey · 2020-05-28T06:13:14Z

needs a forward port of HBASE-19663 on master (previously only on branch-1)
updates our maven-javadoc-plugin to latest (3.2.0)
switches all of our javadocs reports to use the non-forking version.

using mvn -B install -DskipTests && mvn -B site -DskipTests; times on my local laptop below. I'm sure the impact would be greater in docker for OS X. these single run times has noise I'm sure.

before:

hbase busbey$ grep "Total time: " ~/Downloads/HBASE-22033.before.mvn.log 
19:11:32 [INFO] Total time:  05:30 min
19:27:04 [INFO] Total time:  15:29 min

after:

busbey-mba13:hbase busbey$ grep "Total time: " ~/Downloads/HBASE-22033.after.mvn.log 
18:53:29 [INFO] Total time:  06:22 min
19:02:50 [INFO] Total time:  09:19 min

checked using that website generation still works using bash ./dev-support/jenkins-scripts/generate-hbase-website.sh --local-repo ~/.m2/repository .

Some javadoc invocations require that annotations we reference can have any classes they reference resolved. This includes annotations _they_ have, even though annotations are normally optional. In some cases this showed up as javax.annotation.meta.TypeQualifierNickname not found, because some findbugs annotations use it. Other times it was javax.annotation.concurrent.Immutable not found, because some old guava versions use it. (updated for master branch by doing the config in report config instead of plugin) Signed-off-by: Peter Somogyi <psomogyi@apache.org> Signed-off-by: Michael Stack <stack@apache.org>

…rking aggregate goals

Apache-HBase · 2020-05-28T06:39:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	11m 29s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		19m 13s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1796/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1796
Optional Tests	dupname asflicense hadoopcheck xml
uname	Linux 7855355898cb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `79d5649`
Max. process+thread count	76 (vs. ulimit of 12500)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1796/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1, pending remaining QA build

Apache-HBase · 2020-05-28T11:18:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 51s	master passed
+1 💚	compile	3m 2s	master passed
+1 💚	shadedjars	6m 27s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 16s	root in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 29s	the patch passed
+1 💚	compile	3m 4s	the patch passed
+1 💚	javac	3m 4s	the patch passed
+1 💚	shadedjars	6m 24s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 15s	root in the patch failed.
		_ Other Tests _
+1 💚	unit	264m 35s	root in the patch passed.
		298m 5s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1796/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1796
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b038e039bdd1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `79d5649`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1796/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1796/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1796/1/testReport/
Max. process+thread count	4904 (vs. ulimit of 12500)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1796/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-05-28T12:09:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 49s	master passed
+1 💚	compile	2m 15s	master passed
+1 💚	shadedjars	5m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 8s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	2m 24s	the patch passed
+1 💚	javac	2m 24s	the patch passed
+1 💚	shadedjars	5m 30s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 1s	the patch passed
		_ Other Tests _
-1 ❌	unit	318m 50s	root in the patch failed.
		348m 44s

Subsystem	Report/Notes
Docker	Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1796/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1796
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e32a3ef57438 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `79d5649`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1796/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1796/1/testReport/
Max. process+thread count	6740 (vs. ulimit of 12500)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1796/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

busbey · 2020-05-29T06:38:57Z

jdk8 unit failures are unrelated; patch doesn't change anything in tests or backup implementation.

HorizonNet

Tested it locally on my machine. The site goal went down from 17min to 11min in consecutive runs.

busbey · 2020-05-29T20:18:31Z

thanks everyone!

…rking aggregate goals closes #1796 Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Michael Stack <stack@apache.org> Signed-off-by: Jan Hentschel <janh@apache.org> (cherry picked from commit 06949ff)

…rking aggregate goals closes apache#1796 Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Michael Stack <stack@apache.org> Signed-off-by: Jan Hentschel <janh@apache.org> (cherry picked from commit 06949ff)

busbey added 2 commits May 27, 2020 23:26

HBASE-22033 Update to maven-javadoc-plugin 3.2.0 and switch to non-fo…

0fd3e98

…rking aggregate goals

virajjasani approved these changes May 28, 2020

View reviewed changes

saintstack approved these changes May 28, 2020

View reviewed changes

HorizonNet approved these changes May 29, 2020

View reviewed changes

asfgit closed this in 06949ff May 29, 2020

busbey deleted the HBASE-22033 branch May 29, 2020 20:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-22033 Update to maven-javadoc-plugin 3.2.0 and switch to non-forking aggregate goals #1796

HBASE-22033 Update to maven-javadoc-plugin 3.2.0 and switch to non-forking aggregate goals #1796

busbey commented May 28, 2020

Apache-HBase commented May 28, 2020

virajjasani left a comment

Apache-HBase commented May 28, 2020

Apache-HBase commented May 28, 2020

busbey commented May 29, 2020

HorizonNet left a comment

busbey commented May 29, 2020

HBASE-22033 Update to maven-javadoc-plugin 3.2.0 and switch to non-forking aggregate goals #1796

HBASE-22033 Update to maven-javadoc-plugin 3.2.0 and switch to non-forking aggregate goals #1796

Conversation

busbey commented May 28, 2020

Apache-HBase commented May 28, 2020

virajjasani left a comment

Choose a reason for hiding this comment

Apache-HBase commented May 28, 2020

Apache-HBase commented May 28, 2020

busbey commented May 29, 2020

HorizonNet left a comment

Choose a reason for hiding this comment

busbey commented May 29, 2020