Related jiras that update our handling of Hadoop transitive dependencies #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apreduce as a provided dependency
…s as provided scope to avoid inclusion of unnecessary transitive depednencies
…s of guava after hadoop update * Hadoop updated to Guava 27.0-jre * Guava 27 adds error checker framework as a transitive dependency * update relocation rules to relocate it for the shaded client that includes hadoop Co-authored-by: Sean Busbey <busbey@apache.org> Signed-off-by: Sean Busbey <busbey@apache.org>
…st Hadoop trunk. When building with latest hadoop: * JLine is now in the assembly so update licensing * shaded client w/hadoop needs relocation for a couple new hadoop transitives Co-authored-by: Sean Busbey <busbey@apache.org> Signed-off-by: Sean Busbey <busbey@apache.org>
|
🎊 +1 overall
This message was automatically generated. |
willshen
approved these changes
Apr 26, 2019
| <url>https://opensource.org/licenses/BSD-3-Clause</url> | ||
| <distribution>repo</distribution> | ||
| <comments> | ||
| Copyright (c) 2002-2018, the original author or authors. |
There was a problem hiding this comment.
just wondering, does it matter that we are in 2019 now?
There was a problem hiding this comment.
not unless the version of jline we end up packaging is from 2019.
saintstack
approved these changes
Apr 26, 2019
|
arg. merge button doesn't include review sign off in the git commit information. 😿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two general fixes that will be needed by all branch-2 releases
and also two fixes that will only be needed for upcoming minor releases, since they fix problems that depend on which version(s) of Hadoop 3 end up getting released and built against. These are both modified versions of patches provided by other contributors.