Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24562: Stabilize master startup with meta replicas enabled #1997

Merged
merged 3 commits into from
Jul 3, 2020
Merged

HBASE-24562: Stabilize master startup with meta replicas enabled #1997

merged 3 commits into from
Jul 3, 2020

Conversation

BukrosSzabolcs
Copy link
Contributor

branch-2.2 compatible version of #1903

@BukrosSzabolcs
HBASE-24562: Stabilize master startup with meta replicas enabled (apa…
3823c7b 
…che#1903)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Huaxiang Sun <huaxiangsun@apache.com>
@wchevreuil
Copy link
Contributor

retest build

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 11m 14s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-2.2 Compile Tests _
+1 💚 mvninstall 6m 3s branch-2.2 passed
+1 💚 compile 1m 0s branch-2.2 passed
+1 💚 checkstyle 1m 30s branch-2.2 passed
+1 💚 shadedjars 4m 33s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s branch-2.2 passed
+0 🆗 spotbugs 3m 34s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 32s branch-2.2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 20s the patch passed
+1 💚 compile 0m 57s the patch passed
+1 💚 javac 0m 57s the patch passed
-1 ❌ checkstyle 1m 31s hbase-server: The patch generated 3 new + 116 unchanged - 0 fixed = 119 total (was 116)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 25s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 27m 58s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
-1 ❌ javadoc 0m 36s hbase-server generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1)
+1 💚 findbugs 3m 33s the patch passed
_ Other Tests _
-1 ❌ unit 292m 2s hbase-server in the patch failed.
+1 💚 asflicense 0m 27s The patch does not generate ASF License warnings.
372m 15s
Reason Tests
Failed junit tests hadoop.hbase.util.TestFromClientSide3WoUnsafe
Subsystem Report/Notes
Docker Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/1/artifact/out/Dockerfile
GITHUB PR #1997
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 2fee51fc92df 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1997/out/precommit/personality/provided.sh
git revision branch-2.2 / 981f6b3
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/1/artifact/out/diff-checkstyle-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/1/artifact/out/diff-javadoc-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/1/testReport/
Max. process+thread count 4476 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@wchevreuil wchevreuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, after fixing checkstyles. Last UT failure seems unrelated to this PR, have it passing locally.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 24s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-2.2 Compile Tests _
+1 💚 mvninstall 5m 43s branch-2.2 passed
+1 💚 compile 0m 58s branch-2.2 passed
+1 💚 checkstyle 1m 31s branch-2.2 passed
+1 💚 shadedjars 4m 22s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 36s branch-2.2 passed
+0 🆗 spotbugs 3m 40s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 38s branch-2.2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 16s the patch passed
+1 💚 compile 0m 57s the patch passed
+1 💚 javac 0m 57s the patch passed
-1 ❌ checkstyle 1m 32s hbase-server: The patch generated 2 new + 116 unchanged - 0 fixed = 118 total (was 116)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 26s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 28m 33s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚 javadoc 0m 39s the patch passed
+1 💚 findbugs 3m 56s the patch passed
_ Other Tests _
-1 ❌ unit 324m 10s hbase-server in the patch failed.
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
394m 54s
Reason Tests
Failed junit tests hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.util.TestFromClientSide3WoUnsafe
hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash
hadoop.hbase.client.TestAdmin1
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
Subsystem Report/Notes
Docker Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/2/artifact/out/Dockerfile
GITHUB PR #1997
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 40d18302bb2e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1997/out/precommit/personality/provided.sh
git revision branch-2.2 / 981f6b3
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/2/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/2/testReport/
Max. process+thread count 4772 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 57s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-2.2 Compile Tests _
+1 💚 mvninstall 5m 51s branch-2.2 passed
+1 💚 compile 0m 57s branch-2.2 passed
+1 💚 checkstyle 1m 29s branch-2.2 passed
+1 💚 shadedjars 4m 28s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 36s branch-2.2 passed
+0 🆗 spotbugs 3m 36s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 34s branch-2.2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 14s the patch passed
+1 💚 compile 0m 59s the patch passed
+1 💚 javac 0m 59s the patch passed
+1 💚 checkstyle 1m 29s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 25s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 27m 59s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚 javadoc 0m 34s the patch passed
+1 💚 findbugs 3m 33s the patch passed
_ Other Tests _
-1 ❌ unit 277m 48s hbase-server in the patch failed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
349m 53s
Reason Tests
Failed junit tests hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
hadoop.hbase.client.TestFromClientSide5
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/3/artifact/out/Dockerfile
GITHUB PR #1997
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux e7e5849fb507 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1997/out/precommit/personality/provided.sh
git revision branch-2.2 / 981f6b3
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/3/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/3/testReport/
Max. process+thread count 4352 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1997/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
Copy link
Member

ndimiduk commented Jul 2, 2020

Looks like check style passes. I'd like to merge this PR so we can close the ticket and I can proceed with 2.3 RC. Otherwise, I'll close the ticket and you'll need to do this one as a backport jira. @wchevreuil are you good with this one?

@wchevreuil wchevreuil merged commit 899422b into apache:branch-2.2 Jul 3, 2020
@wchevreuil
Copy link
Contributor

@ndimiduk , done sir!

wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@BukrosSzabolcs @busbey
HBASE-24562: Stabilize master startup with meta replicas enabled (apa…
50ba5ce 
…che#1997)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
(cherry picked from commit 899422b)

Change-Id: I10d2cc6ab9ed1ed9cd5b254eb343895c0efd19ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wchevreuil wchevreuil wchevreuil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@BukrosSzabolcs @wchevreuil @Apache-HBase @ndimiduk