HBASE-22357 Fixed remaining Checkstyle issues in hbase-replication

[HorizonNet]

No description provided.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	223	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	258	master passed
+1	compile	18	master passed
+1	checkstyle	12	master passed
+1	shadedjars	266	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	29	master passed
+1	javadoc	14	master passed
		_ Patch Compile Tests _
+1	mvninstall	240	the patch passed
+1	compile	17	the patch passed
+1	javac	17	the patch passed
+1	checkstyle	11	hbase-replication: The patch generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	261	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	497	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	34	the patch passed
+1	javadoc	15	the patch passed
		_ Other Tests _
+1	unit	39	hbase-replication in the patch passed.
+1	asflicense	11	The patch does not generate ASF License warnings.
		2033

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-213/1/artifact/out/Dockerfile
GITHUB PR	#213
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 24c24b1a3cce 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / 0c0d595
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-213/1/testReport/
Max. process+thread count	224 (vs. ulimit of 10000)
modules	C: hbase-replication U: hbase-replication
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-213/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

[Apache9]

Do we have a fail on violation in the pom so we do not break again?

[HorizonNet]

@Apache9 That's already in place.

[Apache9]

Oh, then why there is no failure? We skip checkstyle check in normal build?

[HorizonNet]

Yes. There was a discussion a while ago to move Checkstyle out of the normal build (partly discussed here). It runs if you pass it to Maven or during the pre-commit run.

[saintstack]

Merge @HorizonNet ?