HBASE-24967 The table.jsp cost long time to load if the table include… #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
infraio
reviewed
Sep 4, 2020
| @@ -655,12 +656,14 @@ | |||
| <% | |||
| if (master.getAssignmentManager().isTableEnabled(table.getName())) { | |||
| try { | |||
| CompactionState compactionState = admin.getCompactionState(table.getName()).get(); | |||
| CompactionState compactionState = admin.getCompactionState(table.getName()).get(1, TimeUnit.SECONDS); | |||
There was a problem hiding this comment.
1 sec is too short? And another way is: get the compaction state from master's memory and avoid rpc call.
There was a problem hiding this comment.
Thanks for the suggestion, let me try.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Could you help to review it if you have time, thanks. @infraio |
Apache9
requested changes
Sep 21, 2020
| .setLastMajorCompactionTs(r.getOldestHfileTs(true)); | ||
| r.setCompleteSequenceId(regionLoadBldr); | ||
|
|
||
| LOG.info(">>>>>>setCompactionState:{}",r.getCompactionState()); |
| * @param tableName The table name | ||
| * @return CompactionState Compaction state of the table | ||
| */ | ||
| public org.apache.hadoop.hbase.client.CompactionState getCompactionState( |
There was a problem hiding this comment.
Conflict with org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.GetRegionInfoResponse.CompactionState
There was a problem hiding this comment.
Then better not import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.GetRegionInfoResponse.CompactionState directly? Import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.GetRegionInfoResponse, and then use GetRegionInfoResponse.CompactionState to reference the protobuf message.
There was a problem hiding this comment.
Good idea, will fix, thanks.
| public RegionMetricsBuilder setCompactionState(CompactionState compactionState) { | ||
| this.compactionState = compactionState; | ||
| return this; | ||
| } |
| @@ -164,10 +166,10 @@ private void compaction(final String tableName, final int flushes, | |||
| long curt = System.currentTimeMillis(); | |||
| long waitTime = 5000; | |||
| long endt = curt + waitTime; | |||
| CompactionState state = admin.getCompactionState(table); | |||
| CompactionState state = master.getCompactionState(table); | |||
There was a problem hiding this comment.
I think this test is for testing the HBaseAdmin.getCompactionState so we should not change to use master?
There was a problem hiding this comment.
Make sense, will fix later, thanks.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Ping @Apache9 |
Apache9
approved these changes
Sep 29, 2020
Yeah, thanks for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… closed regions