-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HBASE-24893] [branch-1] Fix failing TestLogLevel unit test on ci-hadoop #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 -1 overall
This message was automatically generated. |
Abhey
changed the title
[HBASE-24893] Fix failing TestLogLevel Unit Test
[HBASE-24893] [branch-1] Fix failing TestLogLevel unit test on ci-hadoop
Sep 1, 2020
Triggered build one more time. |
💔 -1 overall
This message was automatically generated. |
Precommit results are unrelated. changes look good, let me do a quick local check before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to fix the failing
TestLogLevel
unit tests.Post making this change I looked into the branch-2 tests on ci-hadoop and found that the same test was passing for the same profile ie [JDK 8 + Hadoop 2]. So I delved into the code-base for this test in branch-2 and found that a similar fix had already been done to branch-2 as part of
HBASE-23829
. Here is the link to the PR introducing similar code change in branch-2 - https://github.com/apache/hbase/pull/1296/files#diff-88475ac51af9e041c429e33afc3e8ca0This PR basically cherrypicks the changes in the TestLogLevel class as introduced in #1296