Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HBASE-24893] [branch-1] Fix failing TestLogLevel unit test on ci-hadoop #2338

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

Abhey
Copy link
Contributor

@Abhey Abhey commented Sep 1, 2020

This PR introduces changes to fix the failing TestLogLevel unit tests.

Post making this change I looked into the branch-2 tests on ci-hadoop and found that the same test was passing for the same profile ie [JDK 8 + Hadoop 2]. So I delved into the code-base for this test in branch-2 and found that a similar fix had already been done to branch-2 as part of HBASE-23829. Here is the link to the PR introducing similar code change in branch-2 - https://github.com/apache/hbase/pull/1296/files#diff-88475ac51af9e041c429e33afc3e8ca0

This PR basically cherrypicks the changes in the TestLogLevel class as introduced in #1296

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 12m 5s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
+1 💚 mvninstall 10m 8s branch-1 passed
+1 💚 compile 0m 40s branch-1 passed with JDK v1.8.0_262
+1 💚 compile 0m 44s branch-1 passed with JDK v1.7.0_272
+1 💚 checkstyle 1m 40s branch-1 passed
+1 💚 shadedjars 3m 0s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 47s branch-1 passed with JDK v1.8.0_262
+1 💚 javadoc 0m 40s branch-1 passed with JDK v1.7.0_272
+0 🆗 spotbugs 3m 0s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 2m 57s branch-1 passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 53s the patch passed
+1 💚 compile 0m 43s the patch passed with JDK v1.8.0_262
+1 💚 javac 0m 43s the patch passed
+1 💚 compile 0m 45s the patch passed with JDK v1.7.0_272
+1 💚 javac 0m 45s the patch passed
+1 💚 checkstyle 1m 27s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 2m 59s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 4m 52s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 32s the patch passed with JDK v1.8.0_262
+1 💚 javadoc 0m 41s the patch passed with JDK v1.7.0_272
+1 💚 findbugs 2m 54s the patch passed
_ Other Tests _
-1 ❌ unit 152m 24s hbase-server in the patch failed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
206m 4s
Reason Tests
Failed junit tests hadoop.hbase.replication.TestReplicationSmallTests
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2338/1/artifact/out/Dockerfile
GITHUB PR #2338
JIRA Issue HBASE-24893
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 964c95872a7d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2338/out/precommit/personality/provided.sh
git revision branch-1 / 041debd
Default Java 1.7.0_272
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2338/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2338/1/testReport/
Max. process+thread count 4296 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2338/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Abhey Abhey changed the title [HBASE-24893] Fix failing TestLogLevel Unit Test [HBASE-24893] [branch-1] Fix failing TestLogLevel unit test on ci-hadoop Sep 1, 2020
@virajjasani
Copy link
Contributor

Triggered build one more time.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-1 Compile Tests _
+1 💚 mvninstall 10m 10s branch-1 passed
+1 💚 compile 0m 40s branch-1 passed with JDK v1.8.0_262
+1 💚 compile 0m 44s branch-1 passed with JDK v1.7.0_272
+1 💚 checkstyle 1m 39s branch-1 passed
+1 💚 shadedjars 3m 1s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 49s branch-1 passed with JDK v1.8.0_262
+1 💚 javadoc 0m 40s branch-1 passed with JDK v1.7.0_272
+0 🆗 spotbugs 3m 3s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 0s branch-1 passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 54s the patch passed
+1 💚 compile 0m 40s the patch passed with JDK v1.8.0_262
+1 💚 javac 0m 40s the patch passed
+1 💚 compile 0m 43s the patch passed with JDK v1.7.0_272
+1 💚 javac 0m 43s the patch passed
+1 💚 checkstyle 1m 29s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 2m 52s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 4m 34s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 31s the patch passed with JDK v1.8.0_262
+1 💚 javadoc 0m 42s the patch passed with JDK v1.7.0_272
+1 💚 findbugs 2m 52s the patch passed
_ Other Tests _
-1 ❌ unit 154m 27s hbase-server in the patch failed.
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
196m 54s
Reason Tests
Failed junit tests hadoop.hbase.master.TestWarmupRegion
hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
hadoop.hbase.regionserver.TestHRegion
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2338/2/artifact/out/Dockerfile
GITHUB PR #2338
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 702e416b3d1f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2338/out/precommit/personality/provided.sh
git revision branch-1 / fb654a9
Default Java 1.7.0_272
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2338/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2338/2/testReport/
Max. process+thread count 4450 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2338/2/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@apurtell
Copy link
Contributor

apurtell commented Sep 1, 2020

Precommit results are unrelated. changes look good, let me do a quick local check before merge.

@apurtell apurtell merged commit 1dc75e7 into apache:branch-1 Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants