Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HBASE-22476] FSDataInputStream is not closed. #263

Merged
merged 2 commits into from
May 30, 2019
Merged

[HBASE-22476] FSDataInputStream is not closed. #263

merged 2 commits into from
May 30, 2019

Conversation

q977734161
Copy link
Contributor

HBase-backup module's class "org.apache.hadoop.hbase.backup.impl.BackupManifest" FSDataInputStream is not close.

[HBASE-22476] HBase-backup module's class "org.apache.hadoop.hbase.ba…
8840dcd 
…ckup.impl.BackupManifest" FSDataInputStream is not close.
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 28 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 298 master passed
+1 compile 25 master passed
+1 checkstyle 16 master passed
+1 shadedjars 301 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 44 master passed
+1 javadoc 17 master passed
_ Patch Compile Tests _
+1 mvninstall 259 the patch passed
+1 compile 23 the patch passed
+1 javac 23 the patch passed
+1 checkstyle 13 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 283 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1031 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1 findbugs 46 the patch passed
+1 javadoc 15 the patch passed
_ Other Tests _
+1 unit 740 hbase-backup in the patch passed.
+1 asflicense 13 The patch does not generate ASF License warnings.
3480
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/1/artifact/out/Dockerfile
GITHUB PR #263
JIRA Issue HBASE-22476
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 8ec507d3bd24 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 858d30d
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/1/testReport/
Max. process+thread count 4642 (vs. ulimit of 10000)
modules C: hbase-backup U: hbase-backup
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 requested changes May 30, 2019
View reviewed changes
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManifest.java Outdated
@@ -438,6 +438,7 @@ public BackupManifest(FileSystem fs, Path backupPath) throws BackupException {
long len = subFile.getLen();
byte[] pbBytes = new byte[(int) len];
in.readFully(pbBytes);
in.close();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use the try-with-resources grammar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh,yes, using the try-with-resources grammar is better. Thanks for reviewing the code.

[HBASE-22476] HBase-backup module's class "org.apache.hadoop.hbase.ba…
d6f1447 
…ckup.impl.BackupManifest" FSDataInputStream is not close.
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 190 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 273 master passed
+1 compile 22 master passed
+1 checkstyle 16 master passed
+1 shadedjars 261 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 37 master passed
+1 javadoc 16 master passed
_ Patch Compile Tests _
+1 mvninstall 257 the patch passed
+1 compile 25 the patch passed
+1 javac 25 the patch passed
+1 checkstyle 14 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 282 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1046 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1 findbugs 48 the patch passed
+1 javadoc 17 the patch passed
_ Other Tests _
+1 unit 1297 hbase-backup in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
4142
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/2/artifact/out/Dockerfile
GITHUB PR #263
JIRA Issue HBASE-22476
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 74847f4f4503 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 1be93fc
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/2/testReport/
Max. process+thread count 4643 (vs. ulimit of 10000)
modules C: hbase-backup U: hbase-backup
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-263/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@saintstack saintstack merged commit 2823090 into apache:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apache9 Apache9 Apache9 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@q977734161 @Apache-HBase @Apache9 @saintstack