Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24850 CellComparator perf improvement #2776

Merged
merged 10 commits into from
Dec 28, 2020
Merged

HBASE-24850 CellComparator perf improvement #2776

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3fb2ecd
Using ContiguousCellFormat as a marker alone
ramkrish86 Dec 14, 2020
6492523
Commit the new file
ramkrish86 Dec 14, 2020
00ed663
Fix the comparator logic that was an oversight
ramkrish86 Dec 14, 2020
7d73927
Fix the sequenceId check order
ramkrish86 Dec 14, 2020
b881f85
Adding few more static methods that helps in scan flow like query
ramkrish86 Dec 16, 2020
9ea3a7b
Remove ContiguousCellFormat and ensure compare() can be inlined
ramkrish86 Dec 17, 2020
b46ce5c
applying negation as per review comment
ramkrish86 Dec 17, 2020
0915e94
Fix checkstyle comments
ramkrish86 Dec 17, 2020
37579e0
fix review comments
ramkrish86 Dec 18, 2020
c833703
Address review comments
ramkrish86 Dec 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
173 changes: 0 additions & 173 deletions hbase-common/src/main/java/org/apache/hadoop/hbase/BBKVComparator.java
View file
Open in desktop

This file was deleted.

12 changes: 10 additions & 2 deletions hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferKeyOnlyKeyValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,11 @@ private int getTimestampOffset() {

@Override
public byte getTypeByte() {
return ByteBufferUtils.toByte(this.buf, this.offset + this.length - 1);
return getTypeByte(this.length);
}

byte getTypeByte(int keyLen) {
return ByteBufferUtils.toByte(this.buf, this.offset + keyLen - 1);
}

@Override
Expand Down Expand Up @@ -236,7 +240,11 @@ public int getFamilyPosition() {

// The position in BB where the family length is added.
private int getFamilyLengthPosition() {
return this.offset + Bytes.SIZEOF_SHORT + getRowLength();
return getFamilyLengthPosition(getRowLength());
}

int getFamilyLengthPosition(int rowLength) {
return this.offset + Bytes.SIZEOF_SHORT + rowLength;
}

@Override
Expand Down