Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-25499 False-positive findbugs issue on branch-2.2 #2877

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

petersomogyi
Copy link
Contributor

HBase Nightly test on branch-2.2 reports warning on InputStream
cleanup while it is used in a try-with-resource block. This commit adds
a SuppressWarnings annotation.

HBase Nightly test on branch-2.2 reports warning on InputStream
cleanup while it is used in a try-with-resource block. This commit adds
a SuppressWarnings annotation.
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.2 Compile Tests _
+1 💚 mvninstall 3m 12s branch-2.2 passed
+1 💚 compile 0m 27s branch-2.2 passed
+1 💚 checkstyle 0m 20s branch-2.2 passed
+1 💚 shadedjars 4m 3s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 25s branch-2.2 passed
+0 🆗 spotbugs 0m 53s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 0m 51s branch-2.2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 51s the patch passed
+1 💚 compile 0m 28s the patch passed
+1 💚 javac 0m 28s the patch passed
+1 💚 checkstyle 0m 18s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 1s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 25m 49s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚 javadoc 0m 23s the patch passed
+1 💚 findbugs 0m 56s the patch passed
_ Other Tests _
+1 💚 unit 5m 7s hbase-rest in the patch passed.
+1 💚 asflicense 0m 15s The patch does not generate ASF License warnings.
58m 19s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2877/1/artifact/out/Dockerfile
GITHUB PR #2877
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d89fe867256d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2877/out/precommit/personality/provided.sh
git revision branch-2.2 / b223e84
Default Java Oracle Corporation-1.8.0_275-b01
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2877/1/testReport/
Max. process+thread count 2292 (vs. ulimit of 12500)
modules C: hbase-rest U: hbase-rest
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2877/1/console
versions git=2.20.1 maven=3.6.3 findbugs=3.1.11
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@petersomogyi petersomogyi merged commit 7e8598b into apache:branch-2.2 Jan 13, 2021
@petersomogyi petersomogyi deleted the HBASE-25499 branch January 13, 2021 08:07
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
HBase Nightly test on branch-2.2 reports warning on InputStream
cleanup while it is used in a try-with-resource block. This commit adds
a SuppressWarnings annotation.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit 7e8598b)
Change-Id: I5f8abacc2dc93cfd61b4a1f3e3e61e8e684dd37e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants