HBASE-22571 Javadoc Warnings related to @return tag #302

murtazahassan123 · 2019-06-12T21:41:47Z

Javadoc Warnings related to @return tag

Apache-HBase · 2019-06-13T03:34:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	245	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 14 new or modified test files.
		_ master Compile Tests _
0	mvndep	28	Maven dependency ordering for branch
+1	mvninstall	295	master passed
+1	compile	122	master passed
+1	checkstyle	145	master passed
+1	shadedjars	287	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	360	master passed
+1	javadoc	89	master passed
		_ Patch Compile Tests _
0	mvndep	13	Maven dependency ordering for patch
+1	mvninstall	277	the patch passed
+1	compile	124	the patch passed
+1	javac	124	the patch passed
-1	checkstyle	78	hbase-server: The patch generated 6 new + 720 unchanged - 1 fixed = 726 total (was 721)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	261	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	784	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	355	the patch passed
+1	javadoc	83	the patch passed
		_ Other Tests _
+1	unit	197	hbase-client in the patch passed.
+1	unit	47	hbase-zookeeper in the patch passed.
-1	unit	15548	hbase-server in the patch failed.
+1	unit	1242	hbase-mapreduce in the patch passed.
+1	asflicense	124	The patch does not generate ASF License warnings.
		21141

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/1/artifact/out/Dockerfile
GITHUB PR	#302
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 91c466cb7c2b 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `853e586`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/1/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/1/testReport/
Max. process+thread count	5349 (vs. ulimit of 10000)
modules	C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet

LGTM overall, but left a few comments. Please also address the Checkstyle issues from the HBase robot.

hbase-client/src/main/java/org/apache/hadoop/hbase/client/SimpleRequestController.java

hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java

hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormat.java

hbase-server/src/main/java/org/apache/hadoop/hbase/client/locking/EntityLock.java

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestOpenTableInCoprocessor.java

hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java

hbase-server/src/test/java/org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java

murtazahassan123 · 2019-06-17T15:06:38Z

Thanks for the kind comments. I have addressed and fixed things according to comments. Kindly have a look in the 2nd commit.

HorizonNet

Left some additional comments with minor improvements.

hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java

hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java

hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormat.java

murtazahassan123 · 2019-06-17T18:02:06Z

Thanks for the feedback. Please find the corrections in the 3rd commit.

Apache-HBase · 2019-06-17T20:27:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	161	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 14 new or modified test files.
		_ master Compile Tests _
0	mvndep	31	Maven dependency ordering for branch
+1	mvninstall	350	master passed
+1	compile	151	master passed
+1	checkstyle	167	master passed
+1	shadedjars	322	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	384	master passed
+1	javadoc	104	master passed
		_ Patch Compile Tests _
0	mvndep	17	Maven dependency ordering for patch
+1	mvninstall	333	the patch passed
+1	compile	168	the patch passed
+1	javac	168	the patch passed
+1	checkstyle	37	The patch passed checkstyle in hbase-client
+1	checkstyle	15	The patch passed checkstyle in hbase-zookeeper
+1	checkstyle	92	hbase-server: The patch generated 0 new + 720 unchanged - 1 fixed = 720 total (was 721)
+1	checkstyle	19	The patch passed checkstyle in hbase-mapreduce
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	334	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	996	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	411	the patch passed
+1	javadoc	97	the patch passed
		_ Other Tests _
+1	unit	143	hbase-client in the patch passed.
+1	unit	50	hbase-zookeeper in the patch passed.
+1	unit	12958	hbase-server in the patch passed.
+1	unit	1360	hbase-mapreduce in the patch passed.
+1	asflicense	152	The patch does not generate ASF License warnings.
		19288

Subsystem	Report/Notes
Docker	Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/2/artifact/out/Dockerfile
GITHUB PR	#302
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 45b597fbef70 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `214553d`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/2/testReport/
Max. process+thread count	5352 (vs. ulimit of 10000)
modules	C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-06-17T21:43:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	20	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 14 new or modified test files.
		_ master Compile Tests _
0	mvndep	32	Maven dependency ordering for branch
+1	mvninstall	266	master passed
+1	compile	120	master passed
+1	checkstyle	150	master passed
+1	shadedjars	276	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	340	master passed
+1	javadoc	85	master passed
		_ Patch Compile Tests _
0	mvndep	14	Maven dependency ordering for patch
+1	mvninstall	257	the patch passed
+1	compile	122	the patch passed
+1	javac	122	the patch passed
+1	checkstyle	32	The patch passed checkstyle in hbase-client
+1	checkstyle	12	The patch passed checkstyle in hbase-zookeeper
+1	checkstyle	83	hbase-server: The patch generated 0 new + 720 unchanged - 1 fixed = 720 total (was 721)
+1	checkstyle	20	hbase-mapreduce: The patch generated 0 new + 37 unchanged - 8 fixed = 37 total (was 45)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	292	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	877	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	390	the patch passed
+1	javadoc	85	the patch passed
		_ Other Tests _
+1	unit	130	hbase-client in the patch passed.
+1	unit	45	hbase-zookeeper in the patch passed.
+1	unit	8220	hbase-server in the patch passed.
+1	unit	972	hbase-mapreduce in the patch passed.
+1	asflicense	107	The patch does not generate ASF License warnings.
		13327

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/3/artifact/out/Dockerfile
GITHUB PR	#302
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 2c8aefd9dea7 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `214553d`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/3/testReport/
Max. process+thread count	5286 (vs. ulimit of 10000)
modules	C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet · 2019-06-22T19:06:26Z

@SyedMurtazaHassan Could you please resolve the merge conflicts.

murtazahassan123 · 2019-06-28T15:40:13Z

@HorizonNet Solved the merge conflict, kindly review.

Apache-HBase · 2019-06-28T17:22:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	30	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 14 new or modified test files.
		_ master Compile Tests _
0	mvndep	15	Maven dependency ordering for branch
+1	mvninstall	243	master passed
+1	compile	119	master passed
+1	checkstyle	145	master passed
+1	shadedjars	265	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	334	master passed
+1	javadoc	86	master passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	239	the patch passed
+1	compile	118	the patch passed
+1	javac	118	the patch passed
+1	checkstyle	28	The patch passed checkstyle in hbase-client
+1	checkstyle	12	The patch passed checkstyle in hbase-zookeeper
-1	checkstyle	79	hbase-server: The patch generated 5 new + 697 unchanged - 0 fixed = 702 total (was 697)
+1	checkstyle	18	hbase-mapreduce: The patch generated 0 new + 37 unchanged - 8 fixed = 37 total (was 45)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	266	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	712	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	362	the patch passed
+1	javadoc	78	the patch passed
		_ Other Tests _
+1	unit	101	hbase-client in the patch passed.
+1	unit	46	hbase-zookeeper in the patch passed.
-1	unit	2387	hbase-server in the patch failed.
+1	unit	988	hbase-mapreduce in the patch passed.
+1	asflicense	64	The patch does not generate ASF License warnings.
		7116

Reason	Tests
Failed junit tests	hadoop.hbase.regionserver.TestRegionServerRegionSpaceUseReport
	hadoop.hbase.client.TestMultiActionMetricsFromClient
	hadoop.hbase.regionserver.TestDateTieredCompactionPolicy
	hadoop.hbase.TestClientClusterMetrics
	hadoop.hbase.replication.regionserver.TestWALEntrySinkFilter
	hadoop.hbase.replication.regionserver.TestReplicationSinkManager

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/4/artifact/out/Dockerfile
GITHUB PR	#302
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 6b5a5b634980 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `0c8dc5d`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/4/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/4/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/4/testReport/
Max. process+thread count	5439 (vs. ulimit of 10000)
modules	C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet · 2019-06-28T21:28:15Z

@SyedMurtazaHassan It seems that you added new Checkstyle issues. Would be great if you could resolve them.

… issues

murtazahassan123 · 2019-07-01T08:58:44Z

@HorizonNet Fixed the checkstyle issues. Kindly have a look.

Apache-HBase · 2019-07-01T12:32:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	33	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 14 new or modified test files.
		_ master Compile Tests _
0	mvndep	16	Maven dependency ordering for branch
+1	mvninstall	244	master passed
+1	compile	119	master passed
+1	checkstyle	132	master passed
+1	shadedjars	267	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	321	master passed
+1	javadoc	82	master passed
		_ Patch Compile Tests _
0	mvndep	13	Maven dependency ordering for patch
+1	mvninstall	235	the patch passed
+1	compile	119	the patch passed
+1	javac	119	the patch passed
+1	checkstyle	30	The patch passed checkstyle in hbase-client
+1	checkstyle	13	The patch passed checkstyle in hbase-zookeeper
+1	checkstyle	81	The patch passed checkstyle in hbase-server
+1	checkstyle	19	hbase-mapreduce: The patch generated 0 new + 37 unchanged - 8 fixed = 37 total (was 45)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	266	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	738	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	361	the patch passed
+1	javadoc	87	the patch passed
		_ Other Tests _
+1	unit	111	hbase-client in the patch passed.
+1	unit	48	hbase-zookeeper in the patch passed.
+1	unit	7939	hbase-server in the patch passed.
-1	unit	1107	hbase-mapreduce in the patch failed.
+1	asflicense	93	The patch does not generate ASF License warnings.
		12824

Reason	Tests
Failed junit tests	hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/5/artifact/out/Dockerfile
GITHUB PR	#302
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 801f589aa972 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `0c8dc5d`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/5/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/5/testReport/
Max. process+thread count	5398 (vs. ulimit of 10000)
modules	C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/5/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

saintstack

LGTM. Nice cleanup.

Presuming @HorizonNet 's comments addressed.

saintstack · 2019-07-01T21:33:14Z

hbase-client/src/main/java/org/apache/hadoop/hbase/client/SimpleRequestController.java

@@ -433,7 +433,7 @@ private void waitForRegion() throws InterruptedIOException {
     *
     * @param loc
     * @param heapSizeOfRow
-     * @return
+     * @return either Include {@link ReturnCode} or Skip {@link ReturnCode}


Another option if the parameter or return code are self-explanatory is to just remove them from javadoc. Perhaps not here but in the below where you add the text 'the row key' as description on a param named 'key'...

saintstack · 2019-07-01T21:33:34Z

hbase-server/src/main/java/org/apache/hadoop/hbase/client/VersionInfoUtil.java

@@ -149,7 +149,7 @@ private static int buildVersionNumber(int major, int minor, int patch) {
  /**
   * Returns the version components
   * Examples: "1.4.3" returns [1, 4, 3], "4.5.6-SNAPSHOT" returns [4, 5, 6, "SNAPSHOT"]
-   * @returns the components of the version string
+   * @return the components of the version string


saintstack · 2019-07-01T21:37:20Z

Re-running build just to make sure test failure flakey.

Apache-HBase · 2019-07-02T01:25:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	69	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 14 new or modified test files.
		_ master Compile Tests _
0	mvndep	20	Maven dependency ordering for branch
+1	mvninstall	260	master passed
+1	compile	118	master passed
+1	checkstyle	137	master passed
+1	shadedjars	266	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	319	master passed
+1	javadoc	83	master passed
		_ Patch Compile Tests _
0	mvndep	14	Maven dependency ordering for patch
+1	mvninstall	242	the patch passed
+1	compile	120	the patch passed
+1	javac	120	the patch passed
+1	checkstyle	29	The patch passed checkstyle in hbase-client
+1	checkstyle	12	The patch passed checkstyle in hbase-zookeeper
+1	checkstyle	77	The patch passed checkstyle in hbase-server
+1	checkstyle	19	hbase-mapreduce: The patch generated 0 new + 37 unchanged - 8 fixed = 37 total (was 45)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	265	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	727	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	360	the patch passed
+1	javadoc	86	the patch passed
		_ Other Tests _
+1	unit	109	hbase-client in the patch passed.
+1	unit	48	hbase-zookeeper in the patch passed.
+1	unit	7944	hbase-server in the patch passed.
-1	unit	1024	hbase-mapreduce in the patch failed.
+1	asflicense	111	The patch does not generate ASF License warnings.
		12832

Reason	Tests
Failed junit tests	hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/6/artifact/out/Dockerfile
GITHUB PR	#302
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux a5bbb8e21bda 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `52eb893`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/6/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/6/testReport/
Max. process+thread count	5384 (vs. ulimit of 10000)
modules	C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/6/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedAction.java

Apache-HBase · 2019-07-08T13:03:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	93	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 14 new or modified test files.
		_ master Compile Tests _
0	mvndep	18	Maven dependency ordering for branch
+1	mvninstall	229	master passed
+1	compile	111	master passed
+1	checkstyle	126	master passed
+1	shadedjars	253	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	322	master passed
+1	javadoc	77	master passed
		_ Patch Compile Tests _
0	mvndep	12	Maven dependency ordering for patch
+1	mvninstall	222	the patch passed
+1	compile	111	the patch passed
+1	javac	111	the patch passed
+1	checkstyle	25	The patch passed checkstyle in hbase-client
+1	checkstyle	11	The patch passed checkstyle in hbase-zookeeper
+1	checkstyle	70	The patch passed checkstyle in hbase-server
+1	checkstyle	15	hbase-mapreduce: The patch generated 0 new + 37 unchanged - 8 fixed = 37 total (was 45)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	252	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	690	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	345	the patch passed
+1	javadoc	78	the patch passed
		_ Other Tests _
+1	unit	102	hbase-client in the patch passed.
+1	unit	45	hbase-zookeeper in the patch passed.
+1	unit	7958	hbase-server in the patch passed.
+1	unit	830	hbase-mapreduce in the patch passed.
+1	asflicense	92	The patch does not generate ASF License warnings.
		12432

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/7/artifact/out/Dockerfile
GITHUB PR	#302
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 167ec46ecc11 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `605f8a1`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/7/testReport/
Max. process+thread count	5062 (vs. ulimit of 10000)
modules	C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/7/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-13T02:29:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	63	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 14 new or modified test files.
		_ master Compile Tests _
0	mvndep	12	Maven dependency ordering for branch
+1	mvninstall	245	master passed
+1	compile	122	master passed
+1	checkstyle	134	master passed
+1	shadedjars	266	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	340	master passed
+1	javadoc	82	master passed
		_ Patch Compile Tests _
0	mvndep	14	Maven dependency ordering for patch
+1	mvninstall	245	the patch passed
+1	compile	120	the patch passed
+1	javac	120	the patch passed
+1	checkstyle	27	The patch passed checkstyle in hbase-client
+1	checkstyle	11	The patch passed checkstyle in hbase-zookeeper
+1	checkstyle	75	The patch passed checkstyle in hbase-server
+1	checkstyle	17	hbase-mapreduce: The patch generated 0 new + 37 unchanged - 8 fixed = 37 total (was 45)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	267	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	747	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	findbugs	367	the patch passed
+1	javadoc	84	the patch passed
		_ Other Tests _
+1	unit	108	hbase-client in the patch passed.
+1	unit	47	hbase-zookeeper in the patch passed.
+1	unit	16617	hbase-server in the patch passed.
+1	unit	2007	hbase-mapreduce in the patch passed.
+1	asflicense	110	The patch does not generate ASF License warnings.
		22493

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/8/artifact/out/Dockerfile
GITHUB PR	#302
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 184c0bd7a027 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `438bf32`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/8/testReport/
Max. process+thread count	5098 (vs. ulimit of 10000)
modules	C: hbase-client hbase-zookeeper hbase-server hbase-mapreduce U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-302/8/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet requested changes Jun 14, 2019

View reviewed changes

HorizonNet requested changes Jun 17, 2019

View reviewed changes

murtazahassan123 added 3 commits June 28, 2019 17:06

HBASE-22571 Javadoc Warnings related to @return tag

4aefda3

HBASE-22571 changes made according to comments by Jan

7e2d6fa

HBASE-22571 made changes according to Jan's 2nd feedback

c61e2b9

murtazahassan123 force-pushed the HBASE-22571 branch from bc1a635 to c61e2b9 Compare June 28, 2019 15:22

HBASE-22571 Javadoc Warnings related to @return tag, fixed checkstyle…

8400368

… issues

saintstack approved these changes Jul 1, 2019

View reviewed changes

HorizonNet reviewed Jul 4, 2019

View reviewed changes

hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedAction.java Outdated Show resolved Hide resolved

HBASE-22571 changed javadoc for return

8086f7e

HorizonNet approved these changes Jul 13, 2019

View reviewed changes

HorizonNet merged commit 9f343c2 into apache:master Jul 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-22571 Javadoc Warnings related to @return tag #302

HBASE-22571 Javadoc Warnings related to @return tag #302

murtazahassan123 commented Jun 12, 2019

Apache-HBase commented Jun 13, 2019

HorizonNet left a comment

murtazahassan123 commented Jun 17, 2019

HorizonNet left a comment

murtazahassan123 commented Jun 17, 2019

Apache-HBase commented Jun 17, 2019

Apache-HBase commented Jun 17, 2019

HorizonNet commented Jun 22, 2019

murtazahassan123 commented Jun 28, 2019

Apache-HBase commented Jun 28, 2019

HorizonNet commented Jun 28, 2019

murtazahassan123 commented Jul 1, 2019

Apache-HBase commented Jul 1, 2019

saintstack left a comment

saintstack Jul 1, 2019

saintstack Jul 1, 2019

saintstack commented Jul 1, 2019

Apache-HBase commented Jul 2, 2019

Apache-HBase commented Jul 8, 2019

Apache-HBase commented Jul 13, 2019

HBASE-22571 Javadoc Warnings related to @return tag #302

HBASE-22571 Javadoc Warnings related to @return tag #302

Conversation

murtazahassan123 commented Jun 12, 2019

Apache-HBase commented Jun 13, 2019

HorizonNet left a comment

Choose a reason for hiding this comment

murtazahassan123 commented Jun 17, 2019

HorizonNet left a comment

Choose a reason for hiding this comment

murtazahassan123 commented Jun 17, 2019

Apache-HBase commented Jun 17, 2019

Apache-HBase commented Jun 17, 2019

HorizonNet commented Jun 22, 2019

murtazahassan123 commented Jun 28, 2019

Apache-HBase commented Jun 28, 2019

HorizonNet commented Jun 28, 2019

murtazahassan123 commented Jul 1, 2019

Apache-HBase commented Jul 1, 2019

saintstack left a comment

Choose a reason for hiding this comment

saintstack Jul 1, 2019

Choose a reason for hiding this comment

saintstack Jul 1, 2019

Choose a reason for hiding this comment

saintstack commented Jul 1, 2019

Apache-HBase commented Jul 2, 2019

Apache-HBase commented Jul 8, 2019

Apache-HBase commented Jul 13, 2019