Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-25805 Upgrade com.lmax.disruptor to 3.4.2 #3194

Merged
merged 1 commit into from Apr 23, 2021
Merged

HBASE-25805 Upgrade com.lmax.disruptor to 3.4.2 #3194

merged 1 commit into from Apr 23, 2021

Conversation

apurtell
Copy link
Contributor

No description provided.

@apurtell apurtell changed the title HBASE-25805 Upgrade com.lmax.distruptor to 3.4.3 HBASE-25805 Upgrade com.lmax.disruptor to 3.4.3 Apr 23, 2021
Reidddddd
Reidddddd approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@Reidddddd Reidddddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 12m 59s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+1 💚 mvninstall 9m 58s branch-1 passed
+1 💚 compile 1m 52s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 compile 1m 57s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 shadedjars 3m 28s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 52s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 4m 23s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
_ Patch Compile Tests _
+1 💚 mvninstall 2m 13s the patch passed
+1 💚 compile 1m 53s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javac 1m 53s the patch passed
+1 💚 compile 1m 57s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 javac 1m 57s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ xml 0m 0s The patch has 1 ill-formed XML file(s).
+1 💚 shadedjars 3m 11s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 5m 0s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 2m 26s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 4m 23s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
_ Other Tests _
-1 ❌ unit 182m 21s root in the patch failed.
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
245m 12s
Reason Tests
XML Parsing Error(s):
pom.xml
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/1/artifact/out/Dockerfile
GITHUB PR #3194
Optional Tests dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
uname Linux 2dee5eb6f75d 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3194/out/precommit/personality/provided.sh
git revision branch-1 / 16304aa
Default Java Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
xml https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/1/artifact/out/xml.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/1/artifact/out/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/1/testReport/
Max. process+thread count 4421 (vs. ulimit of 10000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/1/console
versions git=1.9.1 maven=3.0.5
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+1 💚 mvninstall 10m 51s branch-1 passed
+1 💚 compile 2m 15s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 compile 2m 16s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 shadedjars 4m 1s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 8s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 4m 50s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
_ Patch Compile Tests _
+1 💚 mvninstall 2m 15s the patch passed
+1 💚 compile 1m 51s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javac 1m 51s the patch passed
+1 💚 compile 2m 0s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 javac 2m 0s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ xml 0m 0s The patch has 1 ill-formed XML file(s).
+1 💚 shadedjars 3m 33s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 5m 10s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 2m 20s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 4m 21s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
_ Other Tests _
-1 ❌ unit 132m 29s root in the patch failed.
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
187m 55s
Reason Tests
XML Parsing Error(s):
pom.xml
Failed junit tests hadoop.hbase.client.TestClientScannerRPCTimeout
hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/2/artifact/out/Dockerfile
GITHUB PR #3194
Optional Tests dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
uname Linux 09b2650df1ec 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3194/out/precommit/personality/provided.sh
git revision branch-1 / 16304aa
Default Java Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
xml https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/2/artifact/out/xml.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/2/artifact/out/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/2/testReport/
Max. process+thread count 3647 (vs. ulimit of 10000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/2/console
versions git=1.9.1 maven=3.0.5
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell apurtell mentioned this pull request Apr 23, 2021
Closed
@apurtell
Copy link
Contributor Author

Failed tests are known flakes, but given the results on #3195 let me try 3.4.2 just to see if there is a test result difference. /cc @saintstack

@apurtell
Copy link
Contributor Author

Pushed change to try 3.4.2 instead of 3.4.3.

@apurtell apurtell changed the title HBASE-25805 Upgrade com.lmax.disruptor to 3.4.3 HBASE-25805 Upgrade com.lmax.disruptor to 3.4.2 Apr 23, 2021
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+1 💚 mvninstall 10m 42s branch-1 passed
+1 💚 compile 2m 15s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 compile 2m 15s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 shadedjars 3m 26s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 44s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 4m 23s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
_ Patch Compile Tests _
+1 💚 mvninstall 2m 11s the patch passed
+1 💚 compile 1m 52s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javac 1m 52s the patch passed
+1 💚 compile 1m 55s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 javac 1m 55s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ xml 0m 1s The patch has 1 ill-formed XML file(s).
+1 💚 shadedjars 3m 7s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 5m 3s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 2m 17s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 4m 19s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
_ Other Tests _
-1 ❌ unit 141m 50s root in the patch failed.
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
194m 37s
Reason Tests
XML Parsing Error(s):
pom.xml
Failed junit tests hadoop.hbase.regionserver.TestSplitTransactionOnCluster
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/3/artifact/out/Dockerfile
GITHUB PR #3194
Optional Tests dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
uname Linux 9fb98bb25084 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3194/out/precommit/personality/provided.sh
git revision branch-1 / 16304aa
Default Java Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
xml https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/3/artifact/out/xml.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/3/artifact/out/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/3/testReport/
Max. process+thread count 4032 (vs. ulimit of 10000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3194/3/console
versions git=1.9.1 maven=3.0.5
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
Copy link
Contributor Author

Unit test issues are not related.

@apurtell apurtell merged commit c1aff55 into apache:branch-1 Apr 23, 2021
@apurtell apurtell deleted the HBASE-25805-branch-1 branch April 23, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathv bharathv bharathv approved these changes

@mnpoonia mnpoonia mnpoonia approved these changes

@Reidddddd Reidddddd Reidddddd approved these changes

@virajjasani virajjasani virajjasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@apurtell @Apache-HBase @bharathv @mnpoonia @Reidddddd @virajjasani