Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-25930 Add doAs support for Thrift Server #3326

Merged
merged 1 commit into from Jun 4, 2021

Conversation

Haoning-Sun
Copy link
Contributor

Add doAs support for Thrift Server

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 5s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 2s master passed
+1 💚 compile 0m 40s master passed
+1 💚 shadedjars 9m 5s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 59s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 45s the patch passed
+1 💚 compile 0m 38s the patch passed
+1 💚 javac 0m 38s the patch passed
+1 💚 shadedjars 8m 58s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 58s the patch passed
_ Other Tests _
+1 💚 unit 4m 36s hbase-thrift in the patch passed.
37m 53s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3326/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3326
Optional Tests javac javadoc unit shadedjars compile
uname Linux 65037412e632 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ed8df5e
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3326/1/testReport/
Max. process+thread count 1353 (vs. ulimit of 30000)
modules C: hbase-thrift U: hbase-thrift
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3326/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 50s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 58s master passed
+1 💚 compile 0m 36s master passed
+1 💚 shadedjars 10m 8s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 6s the patch passed
+1 💚 compile 0m 42s the patch passed
+1 💚 javac 0m 42s the patch passed
+1 💚 shadedjars 11m 2s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 43s the patch passed
_ Other Tests _
+1 💚 unit 4m 52s hbase-thrift in the patch passed.
40m 54s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3326/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3326
Optional Tests javac javadoc unit shadedjars compile
uname Linux 321892a92a17 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ed8df5e
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3326/1/testReport/
Max. process+thread count 2129 (vs. ulimit of 30000)
modules C: hbase-thrift U: hbase-thrift
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3326/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 4m 28s master passed
+1 💚 compile 1m 3s master passed
+1 💚 checkstyle 0m 47s master passed
+1 💚 spotbugs 1m 31s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 3s the patch passed
+1 💚 compile 1m 11s the patch passed
+1 💚 javac 1m 11s the patch passed
+1 💚 checkstyle 0m 50s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 19m 53s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 1m 39s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
45m 22s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3326/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3326
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 3fc7b146b2ba 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ed8df5e
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-thrift U: hbase-thrift
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3326/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks correct.

However, the "doAs support" is a related, but different feature for http services, and should not be referred to in the description.
Also, the ticket description and the commit message should match.

Please update commit message to be the same as the ticket description (i.e.
"HBASE-25930 Thrift does not support requests in Kerberos environment")

@meszibalu meszibalu merged commit 1ecff8a into apache:master Jun 4, 2021
asfgit pushed a commit that referenced this pull request Jun 4, 2021
…3326)

Co-authored-by: sunhaoning <sunhaoning@qianxin.com>
Signed-off-by: Istvan Toth <stoty@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
asfgit pushed a commit that referenced this pull request Jun 4, 2021
…3326)

Co-authored-by: sunhaoning <sunhaoning@qianxin.com>
Signed-off-by: Istvan Toth <stoty@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
asfgit pushed a commit that referenced this pull request Jun 4, 2021
…3326)

Co-authored-by: sunhaoning <sunhaoning@qianxin.com>
Signed-off-by: Istvan Toth <stoty@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
asfgit pushed a commit that referenced this pull request Jun 4, 2021
…3326)

Co-authored-by: sunhaoning <sunhaoning@qianxin.com>
Signed-off-by: Istvan Toth <stoty@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants