New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-25930 Add doAs support for Thrift Server #3326
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code change looks correct.
However, the "doAs support" is a related, but different feature for http services, and should not be referred to in the description.
Also, the ticket description and the commit message should match.
Please update commit message to be the same as the ticket description (i.e.
"HBASE-25930 Thrift does not support requests in Kerberos environment")
…3326) Co-authored-by: sunhaoning <sunhaoning@qianxin.com> Signed-off-by: Istvan Toth <stoty@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
…3326) Co-authored-by: sunhaoning <sunhaoning@qianxin.com> Signed-off-by: Istvan Toth <stoty@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
…3326) Co-authored-by: sunhaoning <sunhaoning@qianxin.com> Signed-off-by: Istvan Toth <stoty@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
…3326) Co-authored-by: sunhaoning <sunhaoning@qianxin.com> Signed-off-by: Istvan Toth <stoty@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
Add doAs support for Thrift Server