HBASE-22622 - WALKey Extended Attributes #352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
Pushed fixes for checkstyle nits. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@apurtell @saintstack @Apache9 - adding extended attributes to WALKey as discussed in HBASE-22622. I wasn't able to use a protobuf map class because the "public" protobuf version doesn't support it so it wouldn't be backwards compatible, so I went back to @apurtell 's original suggestion of a repeated key/value attribute. Keys are strings rather than bytes because Java uses reference equality for hashmaps with byte[] keys, and it seemed better than littering the code with ByteBuffers or ImmutableBytesWritable everywhere. I've fixed the checkstyle issues, and the test failures appear to be flapping replication tests (each run gives different results even when only trivial formatting changes have been made) Related coprocessor changes will be in HBASE-22623, unless the community feels it would be better to consolidate the two patches. Thanks for taking a look! |
|
💔 -1 overall
This message was automatically generated. |
HorizonNet
requested changes
Jul 14, 2019
There was a problem hiding this comment.
@gjacoby126 It seems that the change doesn't compile. Could you please take a look at it?
|
@HorizonNet - rebased on master, and was able to build successfully locally. Hopefully now that I've pushed again that will fix it. |
|
🎊 +1 overall
This message was automatically generated. |
apurtell
approved these changes
Jul 15, 2019
| /** | ||
| * Returns a map of all extended attributes injected into this WAL key. | ||
| */ | ||
| default Map<String, byte[]> getExtendedAttributes() { |
There was a problem hiding this comment.
@apurtell - WALKey's interface comments specifically say that setters aren't permitted. They're meant to be immutable, so the extended attributes will be set during construction of the WALKeyImpl
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Test failures in latest precommit look environmental in nature. Will check locally before merging this. |
apurtell
reviewed
Jul 19, 2019
| if (walKey.getExtendedAttributesCount() > 0){ | ||
| this.extendedAttributes = new HashMap<>(walKey.getExtendedAttributesCount()); | ||
| for (WALProtos.Attribute attr : walKey.getExtendedAttributesList()){ | ||
| extendedAttributes.put(attr.getKey(), attr.getValue().toByteArray()); |
There was a problem hiding this comment.
Noticed while backporting. Attribute values may have been compressed and need to be decompressed. Will fix up for commit.
asfgit
pushed a commit
that referenced
this pull request
Jul 20, 2019
Signed-off-by: Andrew Purtell <apurtell@apache.org> Co-authored-by: Andrew Purtell <apurtell@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jul 20, 2019
Signed-off-by: Andrew Purtell <apurtell@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Jul 20, 2019
Signed-off-by: Andrew Purtell <apurtell@apache.org>
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.