Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because almost all of the heap allocation will happen in another separated allocator named HEAP #365

Merged
merged 1 commit into from
Jul 20, 2019
Merged

HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because almost all of the heap allocation will happen in another separated allocator named HEAP #365

merged 1 commit into from
Jul 20, 2019

Conversation

openinx
Copy link
Member

@openinx openinx commented Jul 9, 2019

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 84 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0 mvndep 25 Maven dependency ordering for branch
+1 mvninstall 276 master passed
+1 compile 79 master passed
+1 checkstyle 109 master passed
+1 shadedjars 317 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 279 master passed
+1 javadoc 57 master passed
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
+1 mvninstall 262 the patch passed
+1 compile 78 the patch passed
+1 javac 78 the patch passed
+1 checkstyle 106 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 299 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 895 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 301 the patch passed
+1 javadoc 59 the patch passed
_ Other Tests _
+1 unit 187 hbase-common in the patch passed.
+1 unit 14728 hbase-server in the patch passed.
+1 asflicense 50 The patch does not generate ASF License warnings.
18578
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/2/artifact/out/Dockerfile
GITHUB PR #365
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux c9f89faaca9d 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 605f8a1
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/2/testReport/
Max. process+thread count 4923 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 72 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0 mvndep 35 Maven dependency ordering for branch
+1 mvninstall 297 master passed
+1 compile 79 master passed
+1 checkstyle 93 master passed
+1 shadedjars 283 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 256 master passed
+1 javadoc 57 master passed
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
+1 mvninstall 255 the patch passed
+1 compile 77 the patch passed
+1 javac 77 the patch passed
+1 checkstyle 94 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 283 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 828 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 284 the patch passed
+1 javadoc 55 the patch passed
_ Other Tests _
+1 unit 179 hbase-common in the patch passed.
-1 unit 19855 hbase-server in the patch failed.
+1 asflicense 75 The patch does not generate ASF License warnings.
23537
Reason Tests
Failed junit tests hadoop.hbase.tool.TestSecureBulkLoadHFiles
hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs
hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.master.procedure.TestProcedurePriority
hadoop.hbase.replication.TestReplicationSyncUpTool
hadoop.hbase.namespace.TestNamespaceAuditor
hadoop.hbase.replication.TestReplicationSmallTestsSync
hadoop.hbase.tool.TestBulkLoadHFiles
hadoop.hbase.util.TestFromClientSide3WoUnsafe
hadoop.hbase.master.procedure.TestSCPWithReplicas
hadoop.hbase.replication.TestReplicationSmallTests
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/1/artifact/out/Dockerfile
GITHUB PR #365
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 162750ac65d7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 605f8a1
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/1/testReport/
Max. process+thread count 5183 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 70 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0 mvndep 29 Maven dependency ordering for branch
+1 mvninstall 277 master passed
+1 compile 84 master passed
+1 checkstyle 99 master passed
+1 shadedjars 309 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 215 master passed
+1 javadoc 61 master passed
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
+1 mvninstall 270 the patch passed
+1 compile 87 the patch passed
+1 javac 87 the patch passed
+1 checkstyle 102 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 294 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 814 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 333 the patch passed
+1 javadoc 59 the patch passed
_ Other Tests _
+1 unit 184 hbase-common in the patch passed.
-1 unit 15733 hbase-server in the patch failed.
+1 asflicense 52 The patch does not generate ASF License warnings.
19445
Reason Tests
Failed junit tests hadoop.hbase.master.procedure.TestSCPWithReplicas
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/3/artifact/out/Dockerfile
GITHUB PR #365
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 85e2861d7beb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 438bf32
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/3/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/3/testReport/
Max. process+thread count 5295 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

anoopsjohn
anoopsjohn approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@anoopsjohn anoopsjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 27 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0 mvndep 23 Maven dependency ordering for branch
+1 mvninstall 233 master passed
+1 compile 71 master passed
+1 checkstyle 85 master passed
+1 shadedjars 254 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 243 master passed
+1 javadoc 50 master passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 235 the patch passed
+1 compile 68 the patch passed
+1 javac 68 the patch passed
+1 checkstyle 86 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 250 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 695 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 265 the patch passed
+1 javadoc 51 the patch passed
_ Other Tests _
+1 unit 169 hbase-common in the patch passed.
+1 unit 7871 hbase-server in the patch passed.
+1 asflicense 51 The patch does not generate ASF License warnings.
11048
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/4/artifact/out/Dockerfile
GITHUB PR #365
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f276bdba5faa 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 74731c2
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/4/testReport/
Max. process+thread count 4363 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/4/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@openinx
HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because …
5c503d0 
…all of the heap allocation will happen in another separated allocator named HEAP
@openinx
Copy link
Member Author

openinx commented Jul 16, 2019

Thanks the +1 from @anoopsjohn , I think I forget to update the patch before...say when in disabled reservior case, we can share the global HEAP allocator. Yeah, I've updated the patch(Also some extra UT)
Let's see the hadoop QA, if OK I will commit the patch.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 55 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0 mvndep 28 Maven dependency ordering for branch
+1 mvninstall 274 master passed
+1 compile 74 master passed
+1 checkstyle 91 master passed
+1 shadedjars 256 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 243 master passed
+1 javadoc 49 master passed
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
+1 mvninstall 225 the patch passed
+1 compile 73 the patch passed
+1 javac 73 the patch passed
+1 checkstyle 85 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 255 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 708 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 191 the patch passed
+1 javadoc 48 the patch passed
_ Other Tests _
-1 unit 157 hbase-common in the patch failed.
-1 unit 37 hbase-server in the patch failed.
+1 asflicense 20 The patch does not generate ASF License warnings.
3187
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/5/artifact/out/Dockerfile
GITHUB PR #365
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b44788d8afc3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / cc38de1
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/5/artifact/out/patch-unit-hbase-common.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/5/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/5/testReport/
Max. process+thread count 126 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/5/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 29 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
0 mvndep 22 Maven dependency ordering for branch
+1 mvninstall 234 master passed
+1 compile 69 master passed
+1 checkstyle 84 master passed
+1 shadedjars 255 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 247 master passed
+1 javadoc 49 master passed
_ Patch Compile Tests _
0 mvndep 12 Maven dependency ordering for patch
+1 mvninstall 228 the patch passed
+1 compile 72 the patch passed
+1 javac 72 the patch passed
+1 checkstyle 88 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 259 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 745 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 268 the patch passed
+1 javadoc 52 the patch passed
_ Other Tests _
+1 unit 173 hbase-common in the patch passed.
+1 unit 7778 hbase-server in the patch passed.
+1 asflicense 57 The patch does not generate ASF License warnings.
11049
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/6/artifact/out/Dockerfile
GITHUB PR #365
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 0f46a549805b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 72e58a8
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/6/testReport/
Max. process+thread count 4741 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-365/6/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@openinx openinx merged commit 00075ea into apache:master Jul 20, 2019
asfgit pushed a commit that referenced this pull request Jul 20, 2019
@openinx
HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because …
6fb03e6 
…all of the heap allocation will happen in another separated allocator named HEAP (#365)
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@openinx @Apache9
HBASE-22663 The HeapAllocationRatio in WebUI is not accurate because …
75a072a 
…all of the heap allocation will happen in another separated allocator named HEAP (apache#365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoopsjohn anoopsjohn anoopsjohn approved these changes

@saintstack saintstack Awaiting requested review from saintstack

@infraio infraio Awaiting requested review from infraio

@ramkrish86 ramkrish86 Awaiting requested review from ramkrish86

@Apache9 Apache9 Awaiting requested review from Apache9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@openinx @Apache-HBase @anoopsjohn