Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22681 The 'assert highestUnsyncedTxid < entry.getTxid();' in Ab… #376

Merged
merged 1 commit into from Jul 13, 2019

Conversation

@Apache9
Copy link
Contributor

commented Jul 12, 2019

…stractFWAL.append may fail when using AsyncFSWAL

…stractFWAL.append may fail when using AsyncFSWAL
@Apache9

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

Please see the comments in

https://issues.apache.org/jira/browse/HBASE-22681

The newly introduced UT can not pass due to a race in LogRoller, so here we just fix the problem in AsyncFSWAL, without adding the new test, will file a new issue to add the UT and also fix the race in LogRoller.

@xcangCRM

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

I see from the JIRA you mentioned you want to use Set instead of the Dequeue. Is this not the case anymore?

@Apache-HBase

This comment has been minimized.

Copy link

commented Jul 13, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 117 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 355 master passed
+1 compile 66 master passed
+1 checkstyle 92 master passed
+1 shadedjars 341 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 251 master passed
+1 javadoc 48 master passed
_ Patch Compile Tests _
+1 mvninstall 333 the patch passed
+1 compile 68 the patch passed
+1 javac 68 the patch passed
+1 checkstyle 90 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 351 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1089 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 266 the patch passed
+1 javadoc 39 the patch passed
_ Other Tests _
+1 unit 12983 hbase-server in the patch passed.
+1 asflicense 31 The patch does not generate ASF License warnings.
16944
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-376/1/artifact/out/Dockerfile
GITHUB PR #376
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 44802e305c1e 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 438bf32
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-376/1/testReport/
Max. process+thread count 4798 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-376/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache9

This comment has been minimized.

Copy link
Contributor Author

commented Jul 13, 2019

I see from the JIRA you mentioned you want to use Set instead of the Dequeue. Is this not the case anymore?

After considering I do not think we need to use a Set, just check the txid is enough. Using a TreeSet will introduce unnecessary compare operations.

Copy link
Member

left a comment

So here we ensure the entry we put into the unackedAppends is always increasing.. LGTM.

@Apache9 Apache9 merged commit 032c18f into apache:master Jul 13, 2019
asfgit pushed a commit that referenced this pull request Jul 13, 2019
…stractFWAL.append may fail when using AsyncFSWAL (#376)

Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Jul 13, 2019
…stractFWAL.append may fail when using AsyncFSWAL (#376)

Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Jul 13, 2019
…stractFWAL.append may fail when using AsyncFSWAL (#376)

Signed-off-by: Zheng Hu <openinx@gmail.com>
asfgit pushed a commit that referenced this pull request Jul 13, 2019
…stractFWAL.append may fail when using AsyncFSWAL (#376)

Signed-off-by: Zheng Hu <openinx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.