HBASE-26249 Ameliorate compaction made by bul… #3831

sunhelly · 2021-11-09T14:32:11Z

…k-loading files

HBASE-25213 introduced the idea of trigger compaction after bulk load.
This issue makes two changes of the idea,

use requestSystemCompaction instead, which is with NO_PRIORITY as same as CompactionChecker;
do not repeatedly add CompactionRunner for the same store, to avoid repeatedly compact one store in a short time. This is important for regionservers with hundreds of regions.

Apache-HBase · 2021-11-09T15:22:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 10s	master passed
+1 💚	compile	3m 13s	master passed
+1 💚	checkstyle	1m 8s	master passed
+1 💚	spotbugs	2m 6s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 48s	the patch passed
+1 💚	compile	3m 13s	the patch passed
+1 💚	javac	3m 13s	the patch passed
-0 ⚠️	checkstyle	1m 5s	hbase-server: The patch generated 3 new + 151 unchanged - 0 fixed = 154 total (was 151)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 26s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 15s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		49m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3831
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 358a585c2e98 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e1ca056`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-09T17:32:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 1s	master passed
+1 💚	compile	1m 29s	master passed
+1 💚	shadedjars	9m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 57s	the patch passed
+1 💚	compile	1m 28s	the patch passed
+1 💚	javac	1m 28s	the patch passed
+1 💚	shadedjars	9m 35s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 52s	the patch passed
		_ Other Tests _
-1 ❌	unit	140m 46s	hbase-server in the patch failed.
		178m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3831
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 90996220725b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e1ca056`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/1/testReport/
Max. process+thread count	3550 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-09T17:36:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 5s	master passed
+1 💚	compile	1m 11s	master passed
+1 💚	shadedjars	9m 28s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 57s	the patch passed
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
+1 💚	shadedjars	8m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
-1 ❌	unit	148m 16s	hbase-server in the patch failed.
		183m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3831
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 43035ac7cb9b 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e1ca056`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/1/testReport/
Max. process+thread count	3647 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-10T08:04:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 47s	master passed
+1 💚	compile	3m 13s	master passed
+1 💚	checkstyle	1m 6s	master passed
+1 💚	spotbugs	2m 2s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 47s	the patch passed
+1 💚	compile	3m 12s	the patch passed
+1 💚	javac	3m 12s	the patch passed
-0 ⚠️	checkstyle	1m 7s	hbase-server: The patch generated 3 new + 154 unchanged - 0 fixed = 157 total (was 154)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 17s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 15s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		48m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3831
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux fb6f9a7e48f0 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `76ceda3`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	95 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-10T10:08:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 27s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	8m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 27s	the patch passed
+1 💚	compile	1m 14s	the patch passed
+1 💚	javac	1m 14s	the patch passed
+1 💚	shadedjars	8m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	140m 30s	hbase-server in the patch passed.
		172m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3831
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 275830b07bc2 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `76ceda3`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/2/testReport/
Max. process+thread count	3694 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-10T12:00:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 35s	master passed
+1 💚	compile	1m 7s	master passed
+1 💚	shadedjars	9m 3s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 14s	the patch passed
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
+1 💚	shadedjars	9m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	245m 4s	hbase-server in the patch passed.
		284m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3831
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 60fa28d5e40a 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `76ceda3`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/2/testReport/
Max. process+thread count	2446 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

In general I think the approach is good.

But on the API design, do we really need to expose isUnderCompaction method? What about just add a flag to indicate whether to still request compaction if the store is already under compaction? As the name of the interface is CompactionRequester...

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java

sunhelly · 2021-11-22T06:11:54Z

But on the API design, do we really need to expose isUnderCompaction method? What about just add a flag to indicate whether to still request compaction if the store is already under compaction? As the name of the interface is CompactionRequester...

This is a good idea, I will add a flag to replace the isUnderCompaction method, thanks @Apache9

...rver/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequester.java

Apache-HBase · 2021-11-22T09:46:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 45s	master passed
+1 💚	compile	3m 47s	master passed
+1 💚	checkstyle	1m 23s	master passed
+1 💚	spotbugs	2m 33s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 28s	the patch passed
+1 💚	compile	3m 49s	the patch passed
+1 💚	javac	3m 49s	the patch passed
-0 ⚠️	checkstyle	1m 11s	hbase-server: The patch generated 1 new + 147 unchanged - 0 fixed = 148 total (was 147)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	hadoopcheck	17m 22s	The patch causes 10 errors with Hadoop v3.3.1.
+1 💚	spotbugs	2m 36s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		44m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3831
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux f9014fa3fd1a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `04635f4`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
hadoopcheck	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/3/artifact/yetus-general-check/output/patch-javac-3.3.1.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-22T13:43:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 45s	master passed
+1 💚	compile	1m 45s	master passed
+1 💚	shadedjars	10m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 55s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 1s	the patch passed
+1 💚	compile	1m 37s	the patch passed
+1 💚	javac	1m 37s	the patch passed
+1 💚	shadedjars	10m 27s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 55s	the patch passed
		_ Other Tests _
+1 💚	unit	237m 12s	hbase-server in the patch passed.
		280m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3831
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 816d9ea36324 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `04635f4`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/3/testReport/
Max. process+thread count	2731 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-22T14:36:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 1s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 45s	master passed
+1 💚	compile	3m 14s	master passed
+1 💚	checkstyle	1m 7s	master passed
+1 💚	spotbugs	2m 1s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 49s	the patch passed
+1 💚	compile	3m 12s	the patch passed
+1 💚	javac	3m 12s	the patch passed
-0 ⚠️	checkstyle	1m 7s	hbase-server: The patch generated 1 new + 147 unchanged - 0 fixed = 148 total (was 147)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 24s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 36s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		50m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3831
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux e8daaef893f0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `04635f4`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-22T18:18:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 20s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 51s	master passed
+1 💚	compile	1m 34s	master passed
+1 💚	shadedjars	10m 49s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 57s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 13s	the patch passed
+1 💚	compile	1m 36s	the patch passed
+1 💚	javac	1m 36s	the patch passed
+1 💚	shadedjars	10m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 51s	the patch passed
		_ Other Tests _
+1 💚	unit	231m 12s	hbase-server in the patch passed.
		272m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3831
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7104e92f9f45 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `04635f4`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/4/testReport/
Max. process+thread count	2825 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-22T19:16:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 1s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 8s	master passed
+1 💚	compile	3m 26s	master passed
+1 💚	checkstyle	1m 6s	master passed
+1 💚	spotbugs	2m 9s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 28s	the patch passed
+1 💚	compile	3m 35s	the patch passed
+1 💚	javac	3m 35s	the patch passed
+1 💚	checkstyle	1m 11s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	22m 25s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 25s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		54m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3831
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux ea796d371c68 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `04635f4`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-22T23:00:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 49s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 20s	master passed
+1 💚	compile	1m 38s	master passed
+1 💚	shadedjars	11m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 21s	the patch passed
+1 💚	compile	1m 50s	the patch passed
+1 💚	javac	1m 50s	the patch passed
+1 💚	shadedjars	10m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 58s	the patch passed
		_ Other Tests _
+1 💚	unit	234m 36s	hbase-server in the patch passed.
		278m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3831
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a965056145a1 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `04635f4`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/5/testReport/
Max. process+thread count	2864 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3831/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

This reverts commit 5e62e2a.

Signed-off-by: Duo Zhang <zhangduo@apache.org>

…apache#3831) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…#3831) (#3874) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…ng files (#3831) (#3874)" This reverts commit 5843a9a.

…3874) Signed-off-by: Duo Zhang <zhangduo@apache.org>

sunhelly force-pushed the HBASE-26249-avoid-repeat-compact-after-bulk-load branch from ff85540 to 91cfa19 Compare November 10, 2021 07:15

sunhelly changed the title ~~HBASE-26249 Avoid repeatedly trigger same store compactions after bul…~~ HBASE-26249 Ameliorate compaction made by bul… Nov 16, 2021

sunhelly requested a review from Apache9 November 16, 2021 13:56

sunhelly added the enhancement label Nov 18, 2021

Apache9 reviewed Nov 21, 2021

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java Outdated Show resolved Hide resolved

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java Outdated Show resolved Hide resolved

sunhelly force-pushed the HBASE-26249-avoid-repeat-compact-after-bulk-load branch 2 times, most recently from 07732b6 to f9696e5 Compare November 22, 2021 09:02

Apache9 reviewed Nov 22, 2021

View reviewed changes

...rver/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequester.java Outdated Show resolved Hide resolved

HBASE-26249 Ameliorate compaction made by bulk-loading files

04af6c5

sunhelly force-pushed the HBASE-26249-avoid-repeat-compact-after-bulk-load branch from f9696e5 to 04af6c5 Compare November 22, 2021 10:29

Apache9 approved these changes Nov 22, 2021

View reviewed changes

fix checkstyle issue

0403237

sunhelly merged commit 5e62e2a into apache:master Nov 23, 2021

asfgit pushed a commit that referenced this pull request Nov 23, 2021

Revert "HBASE-26249 Ameliorate compaction made by bul… (#3831)"

2aafd31

This reverts commit 5e62e2a.

asfgit pushed a commit that referenced this pull request Nov 23, 2021

HBASE-26249 Ameliorate compaction made by bulk-loading files (#3831)

b870b6d

Signed-off-by: Duo Zhang <zhangduo@apache.org>

sunhelly added a commit to sunhelly/hbase that referenced this pull request Nov 23, 2021

Backport HBASE-26249 Ameliorate compaction made by bulk-loading files (…

3700487

…apache#3831) Signed-off-by: Duo Zhang <zhangduo@apache.org>

sunhelly mentioned this pull request Nov 23, 2021

Backport HBASE-26249 Ameliorate compaction made by bulk-loading files… #3874

Merged

sunhelly added a commit that referenced this pull request Nov 23, 2021

Backport HBASE-26249 Ameliorate compaction made by bulk-loading files (…

5843a9a

…#3831) (#3874) Signed-off-by: Duo Zhang <zhangduo@apache.org>

asfgit pushed a commit that referenced this pull request Nov 23, 2021

Revert "Backport HBASE-26249 Ameliorate compaction made by bulk-loadi…

6140625

…ng files (#3831) (#3874)" This reverts commit 5843a9a.

asfgit pushed a commit that referenced this pull request Nov 23, 2021

HBASE-26249 Ameliorate compaction made by bulk-loading files (#3831) (#…

f8d03d1

…3874) Signed-off-by: Duo Zhang <zhangduo@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26249 Ameliorate compaction made by bul… #3831

HBASE-26249 Ameliorate compaction made by bul… #3831

sunhelly commented Nov 9, 2021 •

edited

Apache-HBase commented Nov 9, 2021

Apache-HBase commented Nov 9, 2021

Apache-HBase commented Nov 9, 2021

Apache-HBase commented Nov 10, 2021

Apache-HBase commented Nov 10, 2021

Apache-HBase commented Nov 10, 2021

Apache9 left a comment

sunhelly commented Nov 22, 2021

Apache-HBase commented Nov 22, 2021

Apache-HBase commented Nov 22, 2021

Apache-HBase commented Nov 22, 2021

Apache-HBase commented Nov 22, 2021

Apache-HBase commented Nov 22, 2021

Apache-HBase commented Nov 22, 2021

HBASE-26249 Ameliorate compaction made by bul… #3831

HBASE-26249 Ameliorate compaction made by bul… #3831

Conversation

sunhelly commented Nov 9, 2021 • edited

Apache-HBase commented Nov 9, 2021

Apache-HBase commented Nov 9, 2021

Apache-HBase commented Nov 9, 2021

Apache-HBase commented Nov 10, 2021

Apache-HBase commented Nov 10, 2021

Apache-HBase commented Nov 10, 2021

Apache9 left a comment

Choose a reason for hiding this comment

sunhelly commented Nov 22, 2021

Apache-HBase commented Nov 22, 2021

Apache-HBase commented Nov 22, 2021

Apache-HBase commented Nov 22, 2021

Apache-HBase commented Nov 22, 2021

Apache-HBase commented Nov 22, 2021

Apache-HBase commented Nov 22, 2021

sunhelly commented Nov 9, 2021 •

edited