New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26450 Server configuration will overwrite HStore configuration … #3843
Conversation
…After using shell command 'updateConfiguration'
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Nice catch.
this.storeEngine.compactionPolicy.setConf(conf); | ||
this.offPeakHours = OffPeakHours.getInstance(conf); | ||
this.conf = storeConf; | ||
this.storeEngine.compactionPolicy.setConf(storeConf); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so the problem is here, the 'conf' here is the conf from the parameter, not 'this.conf'...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Precisely!
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
…after using shell command 'update_config' (#3843) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Baiqiang Zhao <zhaobaiqiang@apache.org>
…after using shell command 'update_config' (#3843) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Baiqiang Zhao <zhaobaiqiang@apache.org>
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
…after using shell command 'update_config' (#3843) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Baiqiang Zhao <zhaobaiqiang@apache.org>
…after using shell command 'update_config' (apache#3843) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Baiqiang Zhao <zhaobaiqiang@apache.org>
…After using shell command 'updateConfiguration'