HBASE-22730 XML Parsing error on branch-1

[petersomogyi]

No description provided.

[busbey]

when I try to load the sourceforge URLs they work. is the xml parser no longer allowing http or something?

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	107	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1	mvninstall	200	branch-1 passed
+1	checkstyle	360	branch-1 passed
+1	javadoc	12	branch-1 passed with JDK v1.8.0_222
+1	javadoc	12	branch-1 passed with JDK v1.7.0_232
		_ Patch Compile Tests _
+1	mvninstall	153	the patch passed
+1	checkstyle	380	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
-1	xml	0	The patch has 2 ill-formed XML file(s).
+1	javadoc	10	the patch passed with JDK v1.8.0_222
+1	javadoc	12	the patch passed with JDK v1.7.0_232
		_ Other Tests _
+1	unit	13	hbase-checkstyle in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		1369

Reason	Tests
XML	Parsing Error(s):
	hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml
	hbase-checkstyle/src/main/resources/hbase/checkstyle.xml

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-407/1/artifact/out/Dockerfile
GITHUB PR	#407
Optional Tests	dupname asflicense checkstyle javac javadoc unit xml
uname	Linux 5d86d7a7a4a9 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-407/out/precommit/personality/provided.sh
git revision	branch-1 / e1427d1
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
xml	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-407/1/artifact/out/xml.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-407/1/testReport/
Max. process+thread count	65 (vs. ulimit of 10000)
modules	C: hbase-checkstyle U: hbase-checkstyle
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-407/1/console
versions	git=1.9.1 maven=3.0.5
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[petersomogyi]

when I try to load the sourceforge URLs they work. is the xml parser no longer allowing http or something?

No, the problem is different.

The http://checkstyle.sourceforge.net/dtds/suppressions_1_1.dtd file contains the following DOCTYPE:

<!DOCTYPE suppressions PUBLIC
    "-//Checkstyle//DTD SuppressionFilter Configuration 1.1//EN"
    "https://checkstyle.org/dtds/suppressions_1_1.dtd">

Currently the XMLs have Puppy Crawl content and that causes the XML validation failure.

[Fatal Error] suppressions_1_1.dtd:1:3: The markup declarations contained or pointed to by the document type declaration must be well-formed.
java.lang.RuntimeException: org.xml.sax.SAXParseExceptionpublicId: -//Puppy Crawl//DTD Suppressions 1.0//EN; systemId: http://checkstyle.sourceforge.net/dtds/suppressions_1_1.dtd; lineNumber: 1; columnNumber: 3; The markup declarations contained or pointed to by the document type declaration must be well-formed.

By running jrunscript -e "XMLDocument(arguments[0])" checkstyle-suppressions.xml the error is not reproducible anymore.

[petersomogyi]

The precommit job used JDK 7 where the validation does not work.
script engine for language js can not be found

[apurtell]

What is the solution for " script engine for language js can not be found"? Disable the check?

[busbey]

We could fix the script engine problem with any of:

• Switching to a jdk7 that has a JavaScript engine still (I do not know what JDK is freely available, updated, and has a JavaScript engine)
• Disabling the check entirely
• Make the existing check only run when we're using jdk8 (so currently nightly only)
• Replacing the check with one based on xmllint (and installing xmllint in our docker image)

None of these is relevant to the current PR, though I agree that it's annoying that this keeps popping up on branch-1 changes. I think there's a jira that covers it?

[petersomogyi]

I think there's a jira that covers it?

I thought the same but couldn't find it now. I'll create one and add the options you mentioned as possible solutions to the issue description.