HBASE-26727 Fix CallDroppedException reporting #4088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
force-pushed
the
HBASE-26727
branch
from
13f284b
to
2fc2d5f
Compare
bbeaudreault
commented
Feb 4, 2022
| @@ -62,4 +63,5 @@ | |||
| void quotaExceededException(); | |||
| void rpcThrottlingException(); | |||
| void callDroppedException(); | |||
| void callTimedOut(); | |||
There was a problem hiding this comment.
I added this in this PR because it's a type of call drop that can happen a lot under excess load. I did not roll it into callDroppedException, because it does not manifest as a CallDroppedException on the client side.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Feb 5, 2022
| @@ -222,6 +223,7 @@ public void drop() { | |||
| call.setResponse(null, null, CALL_DROPPED_EXCEPTION, "Call dropped, server " | |||
| + (address != null ? address : "(channel closed)") + " is overloaded, please retry."); | |||
| call.sendResponseIfReady(); | |||
| this.rpcServer.getMetrics().exception(CALL_DROPPED_EXCEPTION); | |||
There was a problem hiding this comment.
Where do we call this method in the past? Will this introduce double accounting?
There was a problem hiding this comment.
As far as I can tell, we do not report them. We added this exception in https://issues.apache.org/jira/browse/HBASE-26623, but the problem is when we drop a call here it doesn't end up hitting any of the other invocations of this method. So the value is always 0 despite throwing these exceptions to clients.
There was a problem hiding this comment.
Typically this is called in a few places, for example in RpcServer or in a few try/catches in RSRpcServices. But a couple exceptions need to be handled a level above this. For example CallQueueTooBigException is handled in the connection and RequestTooBig in the netty frame decoder.
So this exception is another example of a special case like CallQueueTooBig/RequestTooBig, that doesn't get handled by the default try/catches we have in RpcServer/RSRpcServices.
|
@Apache9 any other thoughts here? Would love to get it merged, it's been working ok for us. |
asfgit
pushed a commit
that referenced
this pull request
Feb 19, 2022
Signed-off-by: Andrew Purtell <apurtell@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Feb 19, 2022
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.