Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22739 check bound where removeRegion #411

Closed
wants to merge 1 commit into from
Closed

HBASE-22739 check bound where removeRegion #411

wants to merge 1 commit into from

Conversation

casuallc
Copy link

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 76 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1 mvninstall 319 branch-2.1 passed
+1 compile 57 branch-2.1 passed
+1 checkstyle 88 branch-2.1 passed
+1 shadedjars 281 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 42 branch-2.1 passed
0 spotbugs 180 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 178 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 296 the patch passed
+1 compile 58 the patch passed
+1 javac 58 the patch passed
-1 checkstyle 84 hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 273 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1326 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 javadoc 35 the patch passed
+1 findbugs 184 the patch passed
_ Other Tests _
-1 unit 14933 hbase-server in the patch failed.
+1 asflicense 22 The patch does not generate ASF License warnings.
18651
Reason Tests
Failed junit tests hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
hadoop.hbase.client.TestAsyncClusterAdminApi2
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/1/artifact/out/Dockerfile
GITHUB PR #411
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f81f0839677e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revision branch-2.1 / 100a625
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/1/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/1/testReport/
Max. process+thread count 4546 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 105 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1 mvninstall 348 branch-2.1 passed
+1 compile 53 branch-2.1 passed
+1 checkstyle 78 branch-2.1 passed
+1 shadedjars 244 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 34 branch-2.1 passed
0 spotbugs 184 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 182 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 290 the patch passed
+1 compile 56 the patch passed
+1 javac 56 the patch passed
-1 checkstyle 79 hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 236 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1346 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 javadoc 33 the patch passed
+1 findbugs 177 the patch passed
_ Other Tests _
-1 unit 13645 hbase-server in the patch failed.
+1 asflicense 30 The patch does not generate ASF License warnings.
17316
Reason Tests
Failed junit tests hadoop.hbase.replication.TestMasterReplication
hadoop.hbase.client.TestAdmin1
hadoop.hbase.replication.TestReplicationSmallTests
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/2/artifact/out/Dockerfile
GITHUB PR #411
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 77f4d2966b17 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revision branch-2.1 / fd26716
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/2/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/2/testReport/
Max. process+thread count 5071 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 100 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1 mvninstall 356 branch-2.1 passed
+1 compile 62 branch-2.1 passed
+1 checkstyle 103 branch-2.1 passed
+1 shadedjars 283 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 37 branch-2.1 passed
0 spotbugs 195 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 193 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 322 the patch passed
+1 compile 62 the patch passed
+1 javac 62 the patch passed
-1 checkstyle 94 hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 278 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1347 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 javadoc 34 the patch passed
+1 findbugs 186 the patch passed
_ Other Tests _
-1 unit 13923 hbase-server in the patch failed.
+1 asflicense 26 The patch does not generate ASF License warnings.
17813
Reason Tests
Failed junit tests hadoop.hbase.replication.regionserver.TestReplicationSource
hadoop.hbase.client.TestAdmin1
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/4/artifact/out/Dockerfile
GITHUB PR #411
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 10eb93d7d328 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revision branch-2.1 / f8b592e
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/4/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/4/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/4/testReport/
Max. process+thread count 4344 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/4/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 67 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1 mvninstall 288 branch-2.1 passed
+1 compile 50 branch-2.1 passed
+1 checkstyle 73 branch-2.1 passed
+1 shadedjars 237 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 36 branch-2.1 passed
0 spotbugs 172 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 170 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 273 the patch passed
+1 compile 57 the patch passed
+1 javac 57 the patch passed
-1 checkstyle 79 hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 234 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1164 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 javadoc 33 the patch passed
+1 findbugs 194 the patch passed
_ Other Tests _
-1 unit 16861 hbase-server in the patch failed.
+1 asflicense 95 The patch does not generate ASF License warnings.
20282
Reason Tests
Failed junit tests hadoop.hbase.quotas.TestSpaceQuotas
hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs
hadoop.hbase.replication.TestReplicationSmallTests
hadoop.hbase.client.TestAsyncTableAdminApi
hadoop.hbase.replication.TestMasterReplication
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.client.TestAdmin1
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/3/artifact/out/Dockerfile
GITHUB PR #411
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux aee43a4b4871 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revision branch-2.1 / f8b592e
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/3/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/3/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/3/testReport/
Max. process+thread count 4986 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 197 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1 mvninstall 466 branch-2.1 passed
+1 compile 57 branch-2.1 passed
+1 checkstyle 86 branch-2.1 passed
+1 shadedjars 257 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 39 branch-2.1 passed
0 spotbugs 181 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 178 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 329 the patch passed
+1 compile 59 the patch passed
+1 javac 59 the patch passed
-1 checkstyle 72 hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 240 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1260 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 javadoc 32 the patch passed
+1 findbugs 165 the patch passed
_ Other Tests _
-1 unit 15573 hbase-server in the patch failed.
+1 asflicense 61 The patch does not generate ASF License warnings.
19558
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/5/artifact/out/Dockerfile
GITHUB PR #411
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 89d4f7176330 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revision branch-2.1 / e54c401
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/5/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/5/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/5/testReport/
Max. process+thread count 5148 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/5/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 64 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1 mvninstall 361 branch-2.1 passed
+1 compile 70 branch-2.1 passed
+1 checkstyle 104 branch-2.1 passed
+1 shadedjars 322 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 43 branch-2.1 passed
0 spotbugs 205 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 202 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 361 the patch passed
+1 compile 67 the patch passed
+1 javac 67 the patch passed
-1 checkstyle 86 hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 291 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1483 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 javadoc 40 the patch passed
+1 findbugs 225 the patch passed
_ Other Tests _
-1 unit 13890 hbase-server in the patch failed.
+1 asflicense 33 The patch does not generate ASF License warnings.
18105
Reason Tests
Failed junit tests hadoop.hbase.client.TestAsyncTableGetMultiThreaded
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/6/artifact/out/Dockerfile
GITHUB PR #411
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 5856f5837720 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revision branch-2.1 / 31c99ff
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/6/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/6/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/6/testReport/
Max. process+thread count 5208 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/6/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 78 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 1 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
-1 mvninstall 133 root in branch-2.1 failed.
-1 compile 38 hbase-server in branch-2.1 failed.
+1 checkstyle 73 branch-2.1 passed
-1 shadedjars 166 branch has 24 errors when building our shaded downstream artifacts.
+1 javadoc 29 branch-2.1 passed
0 spotbugs 231 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 35 hbase-server in branch-2.1 failed.
_ Patch Compile Tests _
-1 mvninstall 134 root in the patch failed.
-1 compile 37 hbase-server in the patch failed.
-1 javac 37 hbase-server in the patch failed.
-1 checkstyle 71 hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 166 patch has 24 errors when building our shaded downstream artifacts.
-1 hadoopcheck 95 The patch causes 24 errors with Hadoop v2.7.7.
-1 hadoopcheck 194 The patch causes 24 errors with Hadoop v2.8.5.
-1 hadoopcheck 293 The patch causes 24 errors with Hadoop v3.0.3.
-1 hadoopcheck 395 The patch causes 24 errors with Hadoop v3.1.2.
+1 javadoc 29 the patch passed
-1 findbugs 35 hbase-server in the patch failed.
_ Other Tests _
-1 unit 36 hbase-server in the patch failed.
+1 asflicense 10 The patch does not generate ASF License warnings.
1526
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/Dockerfile
GITHUB PR #411
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 66bc47482314 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revision branch-2.1 / d45b2d4
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/branch-compile-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/branch-shadedjars.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/branch-findbugs-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-compile-hbase-server.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-javac-2.7.7.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-javac-3.0.3.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-javac-3.1.2.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/testReport/
Max. process+thread count 96 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/7/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 63 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
-1 mvninstall 134 root in branch-2.1 failed.
-1 compile 33 hbase-server in branch-2.1 failed.
+1 checkstyle 69 branch-2.1 passed
-1 shadedjars 159 branch has 36 errors when building our shaded downstream artifacts.
+1 javadoc 29 branch-2.1 passed
0 spotbugs 222 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 33 hbase-server in branch-2.1 failed.
_ Patch Compile Tests _
-1 mvninstall 131 root in the patch failed.
-1 compile 34 hbase-server in the patch failed.
-1 javac 34 hbase-server in the patch failed.
-1 checkstyle 71 hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 160 patch has 36 errors when building our shaded downstream artifacts.
-1 hadoopcheck 89 The patch causes 36 errors with Hadoop v2.7.7.
-1 hadoopcheck 186 The patch causes 36 errors with Hadoop v2.8.5.
-1 hadoopcheck 284 The patch causes 36 errors with Hadoop v3.0.3.
-1 hadoopcheck 378 The patch causes 36 errors with Hadoop v3.1.2.
+1 javadoc 29 the patch passed
-1 findbugs 33 hbase-server in the patch failed.
_ Other Tests _
-1 unit 33 hbase-server in the patch failed.
+1 asflicense 9 The patch does not generate ASF License warnings.
1453
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/Dockerfile
GITHUB PR #411
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 2f7040e2a26e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revision branch-2.1 / 65a6b27
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/branch-compile-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/branch-shadedjars.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/branch-findbugs-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-compile-hbase-server.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-javac-2.7.7.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-javac-3.0.3.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-javac-3.1.2.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/testReport/
Max. process+thread count 87 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/8/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1 mvninstall 272 branch-2.1 passed
+1 compile 49 branch-2.1 passed
+1 checkstyle 74 branch-2.1 passed
+1 shadedjars 233 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 31 branch-2.1 passed
0 spotbugs 158 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 155 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 271 the patch passed
+1 compile 51 the patch passed
+1 javac 51 the patch passed
-1 checkstyle 74 hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 228 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1134 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 javadoc 36 the patch passed
+1 findbugs 182 the patch passed
_ Other Tests _
+1 unit 8339 hbase-server in the patch passed.
+1 asflicense 26 The patch does not generate ASF License warnings.
11536
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/9/artifact/out/Dockerfile
GITHUB PR #411
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 6a99de151a68 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revision branch-2.1 / 11b647b
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/9/artifact/out/diff-checkstyle-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/9/testReport/
Max. process+thread count 4423 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/9/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 93 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1 mvninstall 320 branch-2.1 passed
+1 compile 57 branch-2.1 passed
+1 checkstyle 92 branch-2.1 passed
+1 shadedjars 260 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 33 branch-2.1 passed
0 spotbugs 187 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 185 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 321 the patch passed
+1 compile 58 the patch passed
+1 javac 58 the patch passed
-1 checkstyle 92 hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 283 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1761 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 javadoc 48 the patch passed
+1 findbugs 220 the patch passed
_ Other Tests _
-1 unit 14170 hbase-server in the patch failed.
+1 asflicense 30 The patch does not generate ASF License warnings.
18526
Reason Tests
Failed junit tests hadoop.hbase.client.TestFromClientSide
hadoop.hbase.client.TestAdmin1
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/10/artifact/out/Dockerfile
GITHUB PR #411
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b3f38f685855 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revision branch-2.1 / 29f8e19
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/10/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/10/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/10/testReport/
Max. process+thread count 4828 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/10/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 121 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1 mvninstall 468 branch-2.1 passed
+1 compile 52 branch-2.1 passed
+1 checkstyle 78 branch-2.1 passed
+1 shadedjars 256 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 31 branch-2.1 passed
0 spotbugs 170 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 167 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 299 the patch passed
+1 compile 50 the patch passed
+1 javac 50 the patch passed
-1 checkstyle 73 hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 228 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1227 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 javadoc 31 the patch passed
+1 findbugs 162 the patch passed
_ Other Tests _
+1 unit 12696 hbase-server in the patch passed.
+1 asflicense 33 The patch does not generate ASF License warnings.
16328
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/11/artifact/out/Dockerfile
GITHUB PR #411
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 0a0ec76dff95 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revision branch-2.1 / 29f8e19
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/11/artifact/out/diff-checkstyle-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/11/testReport/
Max. process+thread count 4992 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/11/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 66 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1 mvninstall 364 branch-2.1 passed
+1 compile 66 branch-2.1 passed
+1 checkstyle 91 branch-2.1 passed
+1 shadedjars 299 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 42 branch-2.1 passed
0 spotbugs 205 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 202 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 351 the patch passed
+1 compile 66 the patch passed
+1 javac 66 the patch passed
-1 checkstyle 96 hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 301 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1446 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 javadoc 43 the patch passed
+1 findbugs 205 the patch passed
_ Other Tests _
-1 unit 13960 hbase-server in the patch failed.
+1 asflicense 30 The patch does not generate ASF License warnings.
18058
Reason Tests
Failed junit tests hadoop.hbase.client.TestAsyncTableGetMultiThreaded
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/12/artifact/out/Dockerfile
GITHUB PR #411
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 88412f50d540 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revision branch-2.1 / 29f8e19
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/12/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/12/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/12/testReport/
Max. process+thread count 5031 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/12/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 363 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1 mvninstall 329 branch-2.1 passed
+1 compile 57 branch-2.1 passed
+1 checkstyle 93 branch-2.1 passed
+1 shadedjars 256 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 34 branch-2.1 passed
0 spotbugs 176 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 174 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 311 the patch passed
+1 compile 55 the patch passed
+1 javac 55 the patch passed
-1 checkstyle 91 hbase-server: The patch generated 1 new + 61 unchanged - 0 fixed = 62 total (was 61)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 268 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1416 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 javadoc 36 the patch passed
+1 findbugs 184 the patch passed
_ Other Tests _
-1 unit 11592 hbase-server in the patch failed.
+1 asflicense 28 The patch does not generate ASF License warnings.
15718
Reason Tests
Failed junit tests hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.TestRegionRebalancing
hadoop.hbase.master.TestCatalogJanitorCluster
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/15/artifact/out/Dockerfile
GITHUB PR #411
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux e0ba864c4955 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-411/out/precommit/personality/provided.sh
git revision branch-2.1 / 9799e0b
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/15/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/15/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/15/testReport/
Max. process+thread count 4627 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-411/15/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@casuallc casuallc closed this Jul 31, 2019
@@ -870,6 +870,9 @@ void regionMoved(int region, int oldServer, int newServer) {
if (regions[i] == regionIndex) {
break;
}
if (i == regions.length - 1) {
return Arrays.copyOf(regions, regions.length);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here i think we can just return regions. No need to copy the entire array, unless you have a strong reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants