HBASE-26759 Fix trace continuity through CallRunner #4126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I think the problem here is that we forget to end the span created in ServerRpcConnection? Anyway, I think we should have a big span to trace the whole rpc processing... |
|
I did not attempt to perform an audit of the span lifecycle, only reconnected the orphaned span to what appears to be its proper parent. If you think there are bugs in properly closing spans, I hope that we can find them by way of the pom change i have over on https://github.com/apache/hbase/pull/4106/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8 |
|
I believe this patch fixes the issue because I no longer see a litany of these spans attached to a test-root span, and instead see spans of this name attached to a region scanner lifecycle, |
|
I do find it strange that we have a span explicitly for a |
This comment was marked as outdated.
This comment was marked as outdated.
|
I mean we have a span here I think it will be the parent span for the spans at server side, and seems it has not been ended properly? |
I see that the trace scope is closed properly, but I think you're correct that the trace is not ended, neither with success nor failure.
My impression was that this span in |
We appear to be generating spans with without a parent context with the name `RegionScanner.close`. This was a symptom of span scope disconnect through the `CallRunner` execution path.
ndimiduk
force-pushed
the
26759-orphaned-span-RegionScanner.close
branch
from
4780035
to
01ab773
Compare
ndimiduk
changed the title
RegionScanner.close spans
|
@Apache9 please take another look. |
|
🎊 +1 overall
This message was automatically generated. |
Ah, sorry, forgot to reply here. No additional scope. Let me check the newest PR. |
Apache9
approved these changes
Mar 4, 2022
| if (!this.rpcServer.scheduler.dispatch(new CallRunner(this.rpcServer, call))) { | ||
| if (this.rpcServer.scheduler.dispatch(new CallRunner(this.rpcServer, call, span))) { | ||
| // unset span do that it's not closed in the finally block | ||
| span = null; |
There was a problem hiding this comment.
Yes, the code structure here is not friendly for tracing...
Thanks for the detailed comments!
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Mar 5, 2022
Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Mar 5, 2022
Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We appear to be generating spans with without a parent context with the name
RegionScanner.close.