HBASE-26784 Use HIGH_QOS for ResultScanner.close requests #4163

bbeaudreault · 2022-03-04T15:01:50Z

The first commit here is cherry-picked (no conflicts) from the master branch PR: #4146

The second commit adds support for the branch-2 specific blocking client, as well as a test inspired by the async test. While the test classes might look somewhat similar, there are subtle differences that make it hard to DRY. So I just kept it simple with 2 distinct classes.

Apache-HBase · 2022-03-04T15:41:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 47s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 44s	branch-2 passed
+1 💚	compile	2m 58s	branch-2 passed
+1 💚	checkstyle	0m 55s	branch-2 passed
+1 💚	spotbugs	2m 0s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 21s	the patch passed
+1 💚	compile	2m 53s	the patch passed
-0 ⚠️	javac	0m 42s	hbase-client generated 2 new + 159 unchanged - 0 fixed = 161 total (was 159)
-0 ⚠️	checkstyle	0m 17s	hbase-client: The patch generated 13 new + 6 unchanged - 0 fixed = 19 total (was 6)
-0 ⚠️	checkstyle	0m 37s	hbase-server: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	7m 49s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 8s	the patch passed
		_ Other Tests _
-1 ❌	asflicense	0m 15s	The patch generated 1 ASF License warnings.
		31m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux f4ca8a2123d7 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `df90a4b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
asflicense	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count	60 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-04T20:51:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 47s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 3s	branch-2 passed
+1 💚	compile	0m 57s	branch-2 passed
+1 💚	shadedjars	3m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 40s	the patch passed
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
-1 ❌	shadedjars	1m 42s	patch has 10 errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 21s	hbase-client in the patch passed.
+1 💚	unit	320m 13s	hbase-server in the patch passed.
		341m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 044d63e4e55f 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `df90a4b`
Default Java	AdoptOpenJDK-11.0.10+9
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/1/testReport/
Max. process+thread count	2056 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-04T21:29:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 32s	branch-2 passed
+1 💚	compile	0m 56s	branch-2 passed
+1 💚	shadedjars	3m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 17s	the patch passed
+1 💚	compile	0m 56s	the patch passed
+1 💚	javac	0m 56s	the patch passed
-1 ❌	shadedjars	1m 34s	patch has 10 errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 8s	hbase-client in the patch passed.
+1 💚	unit	355m 17s	hbase-server in the patch passed.
		379m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e0fa7ad6860a 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `df90a4b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/1/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/1/testReport/
Max. process+thread count	1987 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-04T22:07:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 46s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 5s	branch-2 passed
+1 💚	compile	3m 30s	branch-2 passed
+1 💚	checkstyle	1m 7s	branch-2 passed
+1 💚	spotbugs	2m 38s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 42s	the patch passed
+1 💚	compile	3m 15s	the patch passed
+1 💚	javac	3m 15s	the patch passed
-0 ⚠️	checkstyle	0m 21s	hbase-client: The patch generated 7 new + 6 unchanged - 0 fixed = 13 total (was 6)
-0 ⚠️	checkstyle	0m 49s	hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 40s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 26s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 18s	The patch does not generate ASF License warnings.
		36m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux b709d3f447fc 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `bed30b1`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	60 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault · 2022-03-04T22:31:14Z

The remaining checkstyle warnings are all ImportOrder, which are hard to understand. The imports look properly sorted to me.

Looking at our checkstyle.xml, I see there are some groups defined so I figured maybe it was that. But we don't have separated=true, and these are already grouped together. I tried search the codebase for examples of, for example one of my violations, org.junit.Before, and couldn't find any way in which my imports are different from those.

I tried running mvn checkstyle:check locally, but it failed to run at all. Without that it'd be hard to iterate on this using the CI to check my ordering, so if someone has guidance I'd be happy to make changes. Otherwise I'll just leave that as is.

apurtell · 2022-03-05T00:18:49Z

@bbeaudreault Import order is a bit counterintuitive. It goes like this:

static imports ...
everything else except org.apache.hbase.thirdparty and org.apache.hadoop.hbase.shaded ...
org.apache.hbase.thirdparty ...
org.apache.hadoop.hbase.shaded ...

bbeaudreault · 2022-03-05T00:51:55Z

Thanks again! I gave that a shot

Apache-HBase · 2022-03-05T03:18:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 45s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 38s	branch-2 passed
+1 💚	compile	0m 57s	branch-2 passed
+1 💚	shadedjars	3m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 39s	the patch passed
+1 💚	compile	0m 57s	the patch passed
+1 💚	javac	0m 57s	the patch passed
+1 💚	shadedjars	3m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 23s	hbase-client in the patch passed.
+1 💚	unit	325m 16s	hbase-server in the patch passed.
		347m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4c0fbd9ab984 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `bed30b1`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/2/testReport/
Max. process+thread count	2281 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-05T03:52:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 36s	branch-2 passed
+1 💚	compile	0m 55s	branch-2 passed
+1 💚	shadedjars	3m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 17s	the patch passed
+1 💚	compile	0m 55s	the patch passed
+1 💚	javac	0m 55s	the patch passed
+1 💚	shadedjars	3m 17s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 10s	hbase-client in the patch passed.
+1 💚	unit	360m 28s	hbase-server in the patch passed.
		381m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c11e08a9e77f 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `bed30b1`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/2/testReport/
Max. process+thread count	1964 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-05T04:24:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 47s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 19s	branch-2 passed
+1 💚	compile	2m 55s	branch-2 passed
+1 💚	checkstyle	0m 54s	branch-2 passed
+1 💚	spotbugs	1m 55s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 17s	the patch passed
+1 💚	compile	2m 56s	the patch passed
+1 💚	javac	2m 56s	the patch passed
-0 ⚠️	checkstyle	0m 17s	hbase-client: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
-0 ⚠️	checkstyle	0m 37s	hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	7m 41s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 18s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		30m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 600f0f3789c0 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `01acd87`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	60 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-05T09:38:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 5s	branch-2 passed
+1 💚	compile	0m 57s	branch-2 passed
+1 💚	shadedjars	3m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 39s	the patch passed
+1 💚	compile	0m 56s	the patch passed
+1 💚	javac	0m 56s	the patch passed
+1 💚	shadedjars	3m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 20s	hbase-client in the patch passed.
+1 💚	unit	321m 59s	hbase-server in the patch passed.
		344m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 915b4238b840 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `01acd87`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/3/testReport/
Max. process+thread count	2071 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-05T10:25:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 32s	branch-2 passed
+1 💚	compile	1m 1s	branch-2 passed
+1 💚	shadedjars	4m 0s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
+1 💚	shadedjars	3m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 24s	hbase-client in the patch passed.
+1 💚	unit	368m 35s	hbase-server in the patch passed.
		391m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ad539b7e2eb1 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `01acd87`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/3/testReport/
Max. process+thread count	2000 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-05T14:18:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 19s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 59s	branch-2 passed
+1 💚	compile	3m 27s	branch-2 passed
+1 💚	checkstyle	1m 12s	branch-2 passed
+1 💚	spotbugs	2m 30s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	3m 40s	the patch passed
+1 💚	javac	3m 40s	the patch passed
-0 ⚠️	checkstyle	0m 42s	hbase-server: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 56s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 36s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 18s	The patch does not generate ASF License warnings.
		37m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 93b95d19b1ba 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0a7e49c`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	60 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-05T19:49:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 57s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 45s	branch-2 passed
+1 💚	compile	0m 52s	branch-2 passed
+1 💚	shadedjars	3m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	0m 52s	the patch passed
+1 💚	javac	0m 52s	the patch passed
+1 💚	shadedjars	3m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 21s	hbase-client in the patch passed.
+1 💚	unit	345m 36s	hbase-server in the patch passed.
		369m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5f3fe035a6f2 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0a7e49c`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/4/testReport/
Max. process+thread count	2170 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-05T19:59:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 45s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 14s	branch-2 passed
+1 💚	compile	1m 24s	branch-2 passed
+1 💚	shadedjars	3m 59s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 58s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 22s	the patch passed
+1 💚	compile	1m 14s	the patch passed
+1 💚	javac	1m 14s	the patch passed
+1 💚	shadedjars	4m 3s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 55s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 16s	hbase-client in the patch passed.
+1 💚	unit	352m 25s	hbase-server in the patch passed.
		378m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 41e45715775f 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0a7e49c`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/4/testReport/
Max. process+thread count	1999 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-05T20:38:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 59s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 45s	branch-2 passed
+1 💚	compile	3m 44s	branch-2 passed
+1 💚	checkstyle	1m 5s	branch-2 passed
+1 💚	spotbugs	2m 32s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 41s	the patch passed
+1 💚	compile	3m 32s	the patch passed
+1 💚	javac	3m 32s	the patch passed
+1 💚	checkstyle	0m 56s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 48s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 46s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		37m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 06b60cbb7f33 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0a7e49c`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	60 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-06T01:47:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 3s	branch-2 passed
+1 💚	compile	1m 5s	branch-2 passed
+1 💚	shadedjars	3m 30s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 41s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
+1 💚	shadedjars	3m 30s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 25s	hbase-client in the patch passed.
+1 💚	unit	324m 6s	hbase-server in the patch passed.
		346m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8151292d1adb 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0a7e49c`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/5/testReport/
Max. process+thread count	2357 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-06T02:29:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 48s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 47s	branch-2 passed
+1 💚	compile	1m 32s	branch-2 passed
+1 💚	shadedjars	4m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 4s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 24s	the patch passed
+1 💚	compile	1m 9s	the patch passed
+1 💚	javac	1m 9s	the patch passed
+1 💚	shadedjars	4m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 59s	hbase-client in the patch passed.
+1 💚	unit	359m 50s	hbase-server in the patch passed.
		388m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4163
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0557141c2221 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `0a7e49c`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/5/testReport/
Max. process+thread count	1985 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4163/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2022-03-07T12:44:21Z

Thanks again! I gave that a shot

@bbeaudreault if you happen to use an editor that supports EditorConfig, the import order is defined in our .editorconfig file. For example, IntelliJ supports sourcing this file for its import order configuration.

bbeaudreault · 2022-03-07T15:23:38Z

Thanks @ndimiduk I was not aware of that file. My company has an IntelliJ plugin which overrides may of the defaults to work for our internal requirements, so that's probably why i wasn't able to take advantage of that file by default. I've updated it now and that will be very helpful to avoid all of these import issues :)

bbeaudreault · 2022-03-07T19:41:44Z

This PR should be all set -- the build shows checks failed, but all 3 post-backs are +1's. No checkstyle/javac issues remaining.

…quests (apache#4163) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>

Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>

bbeaudreault added 2 commits March 4, 2022 08:15

HBASE-26784 Use HIGH_QOS for ResultScanner.close requests

32ed4c2

Add implementation and test for blocking client

756603c

bbeaudreault added 3 commits March 4, 2022 10:58

add license

4ada781

checkstyle

22b41a4

clean up tests

2fec464

checkstyle

2c50e2f

apurtell approved these changes Mar 5, 2022

View reviewed changes

fix imports

374d301

single import

12a69e2

imports again

141f732

sunhelly merged commit 5bae04e into apache:branch-2 Mar 8, 2022

bbeaudreault mentioned this pull request Mar 8, 2022

HBASE-26784 Addendum: Close scanner request should properly inherit original timeout and priority #4183

Merged

asfgit pushed a commit that referenced this pull request Mar 8, 2022

HBASE-26784 Use HIGH_QOS for ResultScanner.close requests (#4163)

6facc82

Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26784 Use HIGH_QOS for ResultScanner.close requests #4163

HBASE-26784 Use HIGH_QOS for ResultScanner.close requests #4163

bbeaudreault commented Mar 4, 2022

Apache-HBase commented Mar 4, 2022

Apache-HBase commented Mar 4, 2022

Apache-HBase commented Mar 4, 2022

Apache-HBase commented Mar 4, 2022

bbeaudreault commented Mar 4, 2022 •

edited

Loading

apurtell commented Mar 5, 2022 •

edited

Loading

bbeaudreault commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 6, 2022

Apache-HBase commented Mar 6, 2022

ndimiduk commented Mar 7, 2022

bbeaudreault commented Mar 7, 2022

bbeaudreault commented Mar 7, 2022

HBASE-26784 Use HIGH_QOS for ResultScanner.close requests #4163

HBASE-26784 Use HIGH_QOS for ResultScanner.close requests #4163

Conversation

bbeaudreault commented Mar 4, 2022

Apache-HBase commented Mar 4, 2022

Apache-HBase commented Mar 4, 2022

Apache-HBase commented Mar 4, 2022

Apache-HBase commented Mar 4, 2022

bbeaudreault commented Mar 4, 2022 • edited Loading

apurtell commented Mar 5, 2022 • edited Loading

bbeaudreault commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 5, 2022

Apache-HBase commented Mar 6, 2022

Apache-HBase commented Mar 6, 2022

ndimiduk commented Mar 7, 2022

bbeaudreault commented Mar 7, 2022

bbeaudreault commented Mar 7, 2022

bbeaudreault commented Mar 4, 2022 •

edited

Loading

apurtell commented Mar 5, 2022 •

edited

Loading