Hbase 26275, update error message when executing deleteall with ROWPREFIXFILTER in meta table #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge apache/hbase
… table hbase:meta
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
sunhelly
reviewed
Mar 16, 2022
| @@ -243,7 +243,7 @@ def _deleteall_internal(row, column = nil, | |||
| args = {}, all_version = true) | |||
| # delete operation doesn't need read permission. Retaining the read check for | |||
| # meta table as a part of HBASE-5837. | |||
| if is_meta_table? | |||
| if is_meta_table? and !(row.is_a?(Hash) and row.key?('ROWPREFIXFILTER')) | |||
There was a problem hiding this comment.
It's dangerous to delete rows in meta table by 'ROWPREFIXFILTER', right? If the rowPrefix matches some rows unexpected, the meta data will be deleted unexpected. I think maybe this is why the origin design seperated meta table here.
There was a problem hiding this comment.
Yes, I have this concen too. Let me fix the error message?
There was a problem hiding this comment.
Of course, you can try to make the descriptions more clearly.
sunhelly
approved these changes
Mar 16, 2022
|
🎊 +1 overall
This message was automatically generated. |
|
Hi, @xicm , you can make a proper title for the issue, thanks. |
|
🎊 +1 overall
This message was automatically generated. |
xicm
changed the title
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Mar 16, 2022
…FIXFILTER in meta table (#4205) Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Mar 16, 2022
…FIXFILTER in meta table (#4205) Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Mar 16, 2022
…FIXFILTER in meta table (#4205) Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…FIXFILTER in meta table (apache#4205) Signed-off-by: Xiaolin Ha <haxiaolin@apache.org> (cherry picked from commit 8d161e4) Change-Id: I11d1ab3da521cb11b99813ab752a4a7a6be6bc0d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if it's reasonable and safe for allowing ROWPREFIXFILTER in deleteAll;
If not, we should raise a clear error message.