New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26876 Use toStringBinary for rowkey in RegionServerCallable error string #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
sunhelly
approved these changes
Mar 23, 2022
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Mar 25, 2022
…or string (#4269) Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Mar 25, 2022
…or string (#4269) Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
bbeaudreault
added a commit
to HubSpot/hbase
that referenced
this pull request
Mar 26, 2022
…ServerCallable error string (apache#4269) Signed-off-by: Xiaolin Ha <haxiaolin@apache.org>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…or string (apache#4269) Signed-off-by: Xiaolin Ha <haxiaolin@apache.org> (cherry picked from commit 42ad0a2) Change-Id: Ic21f7b0f4c0e6283cc3ded42cad3ddc690267bc6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change, did not think it worth a dedicated test. The AsyncTable client callers already appropriately use toStringBinary. For example, here: https://github.com/apache/hbase/blob/branch-2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncSingleRequestRpcRetryingCaller.java#L85. I checked a few other places I knew of as well.