HBASE-26927 Add snapshot scanner UT with SFT and some cleanups to Tes… #4322

wchevreuil · 2022-04-04T21:31:46Z

…tTableSnapshotScanner

Apache-HBase · 2022-04-04T22:13:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 6s	master passed
+1 💚	compile	2m 51s	master passed
+1 💚	checkstyle	0m 50s	master passed
+1 💚	spotbugs	1m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 41s	the patch passed
+1 💚	compile	2m 41s	the patch passed
-0 ⚠️	javac	2m 41s	hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)
+1 💚	checkstyle	0m 38s	hbase-server: The patch generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 50s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 44s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		37m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4322/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4322
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 85959f7e5817 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7f9d1f2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4322/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count	69 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4322/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser

Should also delete the tearDownCluster() calls in the @Test method's finally blocks in TestTableSnapshotScanner. Also clean up the arg-list for testScanner(..) since the cleaning up is down in the @After.

Apache-HBase · 2022-04-05T01:00:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 38s	master passed
+1 💚	compile	0m 35s	master passed
+1 💚	shadedjars	3m 57s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 10s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
+1 💚	shadedjars	3m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	187m 9s	hbase-server in the patch passed.
		204m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4322/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4322
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ed140b1fd6a7 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7f9d1f2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4322/1/testReport/
Max. process+thread count	3321 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4322/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-04-05T01:01:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 54s	master passed
+1 💚	compile	0m 46s	master passed
+1 💚	shadedjars	3m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	compile	0m 45s	the patch passed
+1 💚	javac	0m 45s	the patch passed
+1 💚	shadedjars	3m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	187m 34s	hbase-server in the patch passed.
		205m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4322/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4322
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8cf558bf8ff2 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7f9d1f2`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4322/1/testReport/
Max. process+thread count	3073 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4322/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-04-05T11:10:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 38s	master passed
+1 💚	compile	2m 18s	master passed
+1 💚	checkstyle	0m 35s	master passed
+1 💚	spotbugs	1m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 4s	the patch passed
+1 💚	compile	2m 18s	the patch passed
+1 💚	javac	2m 18s	the patch passed
+1 💚	checkstyle	0m 33s	hbase-server: The patch generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 43s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 19s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		30m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4322/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4322
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux aa6e4b2a986f 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7f9d1f2`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	65 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4322/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-04-05T14:11:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 46s	master passed
+1 💚	compile	0m 48s	master passed
+1 💚	shadedjars	3m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	3m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	the patch passed
		_ Other Tests _
+1 💚	unit	193m 44s	hbase-server in the patch passed.
		211m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4322/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4322
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux aba0b6ab3824 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7f9d1f2`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4322/2/testReport/
Max. process+thread count	2771 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4322/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser

Thanks Wellington!

#4322) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Josh Elser <elserj@apache.org> (cherry picked from commit ae3718b)

HBASE-26927 Add snapshot scanner UT with SFT and some cleanups to Tes…

c26a6f7

…tTableSnapshotScanner

wchevreuil requested review from joshelser and Apache9 April 4, 2022 21:31

joshelser requested changes Apr 4, 2022

View reviewed changes

addressing review comments

a804647

wchevreuil requested a review from joshelser April 5, 2022 12:32

Apache9 approved these changes Apr 5, 2022

View reviewed changes

joshelser approved these changes Apr 5, 2022

View reviewed changes

wchevreuil merged commit ae3718b into apache:master Apr 5, 2022

wchevreuil added a commit that referenced this pull request Apr 5, 2022

HBASE-26927 Add snapshot scanner UT with SFT and some cleanups to Tes… (

1c14046

#4322) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Josh Elser <elserj@apache.org> (cherry picked from commit ae3718b)

wchevreuil added a commit that referenced this pull request Apr 5, 2022

HBASE-26927 Add snapshot scanner UT with SFT and some cleanups to Tes… (

beed73b

#4322) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Josh Elser <elserj@apache.org> (cherry picked from commit ae3718b)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26927 Add snapshot scanner UT with SFT and some cleanups to Tes… #4322

HBASE-26927 Add snapshot scanner UT with SFT and some cleanups to Tes… #4322

wchevreuil commented Apr 4, 2022

Apache-HBase commented Apr 4, 2022

joshelser left a comment

Apache-HBase commented Apr 5, 2022

Apache-HBase commented Apr 5, 2022

Apache-HBase commented Apr 5, 2022

Apache-HBase commented Apr 5, 2022

joshelser left a comment

HBASE-26927 Add snapshot scanner UT with SFT and some cleanups to Tes… #4322

HBASE-26927 Add snapshot scanner UT with SFT and some cleanups to Tes… #4322

Conversation

wchevreuil commented Apr 4, 2022

Apache-HBase commented Apr 4, 2022

joshelser left a comment

Choose a reason for hiding this comment

Apache-HBase commented Apr 5, 2022

Apache-HBase commented Apr 5, 2022

Apache-HBase commented Apr 5, 2022

Apache-HBase commented Apr 5, 2022

joshelser left a comment

Choose a reason for hiding this comment