New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport "HBASE-26648 Improve fidelity of RegionLocator spans" to branch-2 #4380
Merged
ndimiduk
merged 2 commits into
apache:branch-2
from
ndimiduk:26648-regionlocator-tracing-branch-2
May 3, 2022
Merged
Backport "HBASE-26648 Improve fidelity of RegionLocator spans" to branch-2 #4380
ndimiduk
merged 2 commits into
apache:branch-2
from
ndimiduk:26648-regionlocator-tracing-branch-2
May 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndimiduk
added
the
backport
This PR is a back port of some issue or issues already committed to master
label
Apr 28, 2022
This comment was marked as outdated.
This comment was marked as outdated.
Apache9
approved these changes
Apr 28, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ndimiduk
force-pushed
the
26648-regionlocator-tracing-branch-2
branch
from
April 29, 2022 09:01
4394c4a
to
6ecc736
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ndimiduk
force-pushed
the
26648-regionlocator-tracing-branch-2
branch
from
May 2, 2022 14:25
6ecc736
to
4481f89
Compare
Signed-off-by: Duo Zhang <zhangduo@apache.org>
ndimiduk
force-pushed
the
26648-regionlocator-tracing-branch-2
branch
from
May 2, 2022 14:26
4481f89
to
dcf0406
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Test failure is legit. Looks like we resolve meta regions via RPC on master, but i guess that feature isn't enabled on branch-2. |
Addendum extends the test case to cover both `RpcConnectionRegistry` and `ZKConnectionRegistry`.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Duo Zhang zhangduo@apache.org