HBASE-27039 Some methods of MasterRegion should be annotated for testing only #4433

2005hithlj · 2022-05-16T00:44:50Z

https://issues.apache.org/jira/browse/HBASE-27039

…ing only

Apache-HBase · 2022-05-16T01:22:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 49s	master passed
+1 💚	compile	2m 12s	master passed
+1 💚	checkstyle	0m 29s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 3s	the patch passed
+1 💚	compile	2m 11s	the patch passed
+1 💚	javac	2m 11s	the patch passed
+1 💚	checkstyle	0m 27s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 54s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 18s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		32m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4433/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4433
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 195ee88bb986 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `369adcd`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4433/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-16T04:27:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 44s	master passed
+1 💚	compile	0m 34s	master passed
+1 💚	shadedjars	3m 57s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 5s	the patch passed
+1 💚	compile	0m 34s	the patch passed
+1 💚	javac	0m 34s	the patch passed
+1 💚	shadedjars	3m 56s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	198m 0s	hbase-server in the patch passed.
		217m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4433/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4433
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 41ec173e3211 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `369adcd`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4433/1/testReport/
Max. process+thread count	2483 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4433/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

carp84

One thing I'm not sure is whether these methods are designed for test only or reserved for later usage, would you mind double check @2005hithlj ? Thanks.

Apache9 · 2022-05-22T02:28:00Z

Are these methods actually used in tests? If not, I think we can just remove them...

For me, at least I do not think the get method is for testing only...

2005hithlj · 2022-05-22T09:17:46Z

Thanks for the review. @Apache9 @carp84
At present, I have seen that these methods are only used for testing, including the 'get' method.
If they will be used later, I will close this PR.

Apache9 · 2022-05-22T10:32:04Z

Thanks for the review. @Apache9 @carp84 At present, I have seen that these methods are only used for testing, including the 'get' method. If they will be used later, I will close this PR.

Checked again, I think it is OK to add the test only annotation to get method too. But let's add some comments. The design for master region is to only load all the data to memory at once when starting, so typically you should not use the get method to get a single row of data at runtime.

2005hithlj · 2022-05-22T22:36:51Z

Thanks for the review. @Apache9 @carp84 At present, I have seen that these methods are only used for testing, including the 'get' method. If they will be used later, I will close this PR.

Checked again, I think it is OK to add the test only annotation to get method too. But let's add some comments. The design for master region is to only load all the data to memory at once when starting, so typically you should not use the get method to get a single row of data at runtime.

OK, I will add some comment. Thanks. @Apache9

…ing only

Apache-HBase · 2022-05-22T23:23:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 29s	master passed
+1 💚	compile	2m 19s	master passed
+1 💚	checkstyle	0m 32s	master passed
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 20s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	2m 13s	the patch passed
+1 💚	javac	2m 13s	the patch passed
+1 💚	checkstyle	0m 30s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 52s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 28s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		32m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4433/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4433
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux c3864e9f0b94 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1be2c83`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4433/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-23T02:19:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 18s	master passed
+1 💚	compile	0m 43s	master passed
+1 💚	shadedjars	4m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	0m 43s	the patch passed
+1 💚	javac	0m 43s	the patch passed
+1 💚	shadedjars	4m 0s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	190m 6s	hbase-server in the patch passed.
		209m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4433/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4433
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b1525c787097 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1be2c83`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4433/2/testReport/
Max. process+thread count	2817 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4433/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-23T02:30:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 51s	master passed
+1 💚	compile	0m 36s	master passed
+1 💚	shadedjars	4m 3s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 16s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
+1 💚	shadedjars	3m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	200m 51s	hbase-server in the patch passed.
		220m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4433/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4433
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d140bf7ff4ca 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1be2c83`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4433/2/testReport/
Max. process+thread count	2433 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4433/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

2005hithlj · 2022-05-23T03:43:22Z

@Apache9 Could you take a look? Thanks.

…ing only (#4433) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 15002fc)

…ing only (apache#4433) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…for testing only (apache#4433)" This reverts commit b0bac94.

…ing only (apache#4433) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 15002fc) Change-Id: I44188f67e3a7f44d8ef54099b375023a6a821641

HBASE-27039 Some methods of MasterRegion should be annotated for test…

9263971

…ing only

carp84 reviewed May 17, 2022

View reviewed changes

HBASE-27039 Some methods of MasterRegion should be annotated for test…

90ac843

…ing only

Apache9 approved these changes Jun 2, 2022

View reviewed changes

Apache9 merged commit 15002fc into apache:master Jun 2, 2022

Apache9 pushed a commit that referenced this pull request Jun 2, 2022

HBASE-27039 Some methods of MasterRegion should be annotated for test…

3ce6e1a

…ing only (#4433) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 15002fc)

Apache9 pushed a commit that referenced this pull request Jun 2, 2022

HBASE-27039 Some methods of MasterRegion should be annotated for test…

a93b7cd

…ing only (#4433) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 15002fc)

Apache9 pushed a commit that referenced this pull request Jun 2, 2022

HBASE-27039 Some methods of MasterRegion should be annotated for test…

8270b5d

…ing only (#4433) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 15002fc)

wenwj0 pushed a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022

HBASE-27039 Some methods of MasterRegion should be annotated for test…

b0bac94

…ing only (apache#4433) Signed-off-by: Duo Zhang <zhangduo@apache.org>

wenwj0 added a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022

Revert "HBASE-27039 Some methods of MasterRegion should be annotated …

4afb18e

…for testing only (apache#4433)" This reverts commit b0bac94.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27039 Some methods of MasterRegion should be annotated for testing only #4433

HBASE-27039 Some methods of MasterRegion should be annotated for testing only #4433

2005hithlj commented May 16, 2022

Apache-HBase commented May 16, 2022

Apache-HBase commented May 16, 2022

carp84 left a comment

Apache9 commented May 22, 2022

2005hithlj commented May 22, 2022

Apache9 commented May 22, 2022

2005hithlj commented May 22, 2022

Apache-HBase commented May 22, 2022

Apache-HBase commented May 23, 2022

Apache-HBase commented May 23, 2022

2005hithlj commented May 23, 2022

HBASE-27039 Some methods of MasterRegion should be annotated for testing only #4433

HBASE-27039 Some methods of MasterRegion should be annotated for testing only #4433

Conversation

2005hithlj commented May 16, 2022

Apache-HBase commented May 16, 2022

Apache-HBase commented May 16, 2022

carp84 left a comment

Choose a reason for hiding this comment

Apache9 commented May 22, 2022

2005hithlj commented May 22, 2022

Apache9 commented May 22, 2022

2005hithlj commented May 22, 2022

Apache-HBase commented May 22, 2022

Apache-HBase commented May 23, 2022

Apache-HBase commented May 23, 2022

2005hithlj commented May 23, 2022