HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g… #4442

huaxiangsun · 2022-05-18T06:05:03Z

…etAllRegionLocations()

huaxiangsun · 2022-05-18T06:06:22Z

Hi @Apache9, retry with a new patch, can you review? Thanks.

Apache-HBase · 2022-05-18T06:42:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 45s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 21s	master passed
+1 💚	compile	2m 47s	master passed
+1 💚	checkstyle	0m 42s	master passed
-1 ❌	spotless	0m 16s	branch has 25 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 51s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 6s	the patch passed
+1 💚	compile	2m 49s	the patch passed
+1 💚	javac	2m 49s	the patch passed
+1 💚	checkstyle	0m 39s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	hadoopcheck	6m 58s	The patch causes 10 errors with Hadoop v3.2.2.
-1 ❌	hadoopcheck	7m 41s	The patch causes 10 errors with Hadoop v3.3.1.
-1 ❌	spotless	0m 11s	patch has 25 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	2m 9s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		26m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4442
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 3648b18a3776 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b787648`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/1/artifact/yetus-general-check/output/branch-spotless.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/1/artifact/yetus-general-check/output/patch-javac-3.2.2.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/1/artifact/yetus-general-check/output/patch-javac-3.3.1.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	68 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-18T09:53:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 26s	master passed
+1 💚	compile	1m 22s	master passed
+1 💚	shadedjars	5m 7s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 27s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 11s	the patch passed
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
+1 💚	shadedjars	3m 47s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 11s	hbase-client in the patch passed.
-1 ❌	unit	188m 31s	hbase-server in the patch failed.
		218m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4442
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d026af427986 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b787648`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/1/testReport/
Max. process+thread count	2521 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-18T10:03:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 23s	master passed
+1 💚	compile	0m 58s	master passed
+1 💚	shadedjars	3m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 11s	the patch passed
+1 💚	compile	0m 58s	the patch passed
+1 💚	javac	0m 58s	the patch passed
+1 💚	shadedjars	3m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 13s	hbase-client in the patch passed.
-1 ❌	unit	208m 46s	hbase-server in the patch failed.
		228m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4442
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2b6d49800167 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b787648`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/1/testReport/
Max. process+thread count	2376 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

huaxiangsun · 2022-05-18T20:34:20Z

I run locally the failed tests, they are ok. The test should not have anything related with the patch, let me rerun.

Apache-HBase · 2022-05-18T21:11:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 54s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 13s	master passed
+1 💚	compile	2m 45s	master passed
+1 💚	checkstyle	0m 38s	master passed
+1 💚	spotless	0m 37s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 44s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 7s	the patch passed
+1 💚	compile	2m 42s	the patch passed
+1 💚	javac	2m 42s	the patch passed
+1 💚	checkstyle	0m 38s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 33s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
-1 ❌	spotless	0m 32s	patch has 22 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	2m 0s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		34m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4442
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux b67149dfb12b 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `76d20fc`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-19T00:27:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 17s	master passed
+1 💚	compile	1m 19s	master passed
+1 💚	shadedjars	5m 28s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 9s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 34s	the patch passed
+1 💚	compile	1m 13s	the patch passed
+1 💚	javac	1m 13s	the patch passed
+1 💚	shadedjars	5m 1s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 50s	hbase-client in the patch passed.
+1 💚	unit	201m 22s	hbase-server in the patch passed.
		230m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4442
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e3e9f1dfe0d4 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `76d20fc`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/2/testReport/
Max. process+thread count	2518 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-05-19T01:34:00Z

hbase-client/src/main/java/org/apache/hadoop/hbase/ClientMetaTableAccessor.java

+    if (metaReplicaMode == CatalogReplicaMode.LOAD_BALANCE) {
+      addListener(metaTable.getDescriptor(), (desc, error) -> {
+        if (error != null) {
+          LOG.warn("Failed to get meta table descriptotr, error={}", error);


Here we do not want to log the stacktrace so we use error={}?

We need the stacktrace, update in the new patch.

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java

Apache9 · 2022-05-19T01:36:00Z

.../java/org/apache/hadoop/hbase/replication/regionserver/TestMetaRegionReplicaReplication.java

@@ -385,6 +386,12 @@ private void primaryNoChangeReplicaIncrease(final long[] before, final long[] af
    }
  }

+  private void PrimaryIncreaseReplicaIncrease(final long[] before, final long[] after) {


the leading char should be lower case :)

.../java/org/apache/hadoop/hbase/replication/regionserver/TestMetaRegionReplicaReplication.java

…etAllRegionLocations()

Apache-HBase · 2022-05-19T20:06:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 49s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 27s	master passed
+1 💚	compile	2m 47s	master passed
+1 💚	checkstyle	0m 42s	master passed
+1 💚	spotless	0m 48s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 53s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 4s	the patch passed
+1 💚	compile	2m 48s	the patch passed
+1 💚	javac	2m 48s	the patch passed
+1 💚	checkstyle	0m 38s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 45s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
-1 ❌	spotless	0m 32s	patch has 22 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	2m 1s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		36m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4442
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux c69e314cc9bc 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `76d20fc`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/3/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-19T23:15:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 13s	master passed
+1 💚	compile	0m 58s	master passed
+1 💚	shadedjars	3m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 12s	the patch passed
+1 💚	compile	0m 58s	the patch passed
+1 💚	javac	0m 58s	the patch passed
+1 💚	shadedjars	3m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 10s	hbase-client in the patch passed.
+1 💚	unit	205m 27s	hbase-server in the patch passed.
		224m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4442
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 14301b19e1b9 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `76d20fc`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/3/testReport/
Max. process+thread count	2356 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-19T23:24:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 22s	master passed
+1 💚	compile	0m 56s	master passed
+1 💚	shadedjars	3m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 24s	the patch passed
+1 💚	compile	0m 56s	the patch passed
+1 💚	javac	0m 56s	the patch passed
+1 💚	shadedjars	3m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 7s	hbase-client in the patch passed.
+1 💚	unit	215m 6s	hbase-server in the patch passed.
		234m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4442
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 36ee3218025d 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `76d20fc`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/3/testReport/
Max. process+thread count	2581 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4442/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

huaxiangsun · 2022-05-23T15:53:04Z

Thanks @Apache9 for the review.

Apache9 · 2022-05-24T07:30:09Z

Please push an addendum to fix the spotless errors?

Thanks.

…etAllRegionLocations() (apache#4442) Signed-off-by: Duo Zhang <zhangduo@apache.org>

huaxiangsun · 2022-05-26T14:52:16Z

Please push an addendum to fix the spotless errors?
Terribly sorry, @Apache9. Did not notice your message earlier, will be more careful next time when merging PR. Thanks for committing an addendum.

…etAllRegionLocations() (apache#4442) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…etAllRegionLocations() (#4442) (#4464) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…etAllRegionLocations() (apache#4442) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…etAllRegionLocations() (#4442) (#4484) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…etAllRegionLocations() (#4442) (#4485) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…etAllRegionLocations() (apache#4442) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…ocator#getAllRegionLocations() (apache#4442)" This reverts commit 33041da.

…etAllRegionLocations() (apache#4442) (apache#4485) Signed-off-by: Duo Zhang <zhangduo@apache.org> Change-Id: Ic784e85e153325f91b88a1b8aa7ad25d041eeb78

huaxiangsun requested a review from Apache9 May 18, 2022 06:05

Apache9 reviewed May 19, 2022

View reviewed changes

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g…

1ea3008

…etAllRegionLocations()

huaxiangsun force-pushed the m.HBASE-26649 branch from db1d9bb to 1ea3008 Compare May 19, 2022 19:20

Apache9 approved these changes May 23, 2022

View reviewed changes

huaxiangsun merged commit 623f8af into apache:master May 23, 2022

Apache9 mentioned this pull request May 24, 2022

HBASE-27028 Add a shell command for flushing master local region #4457

Merged

huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request May 26, 2022

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g…

9db9f24

…etAllRegionLocations() (apache#4442) Signed-off-by: Duo Zhang <zhangduo@apache.org>

huaxiangsun mentioned this pull request May 26, 2022

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g… #4464

Merged

huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request May 26, 2022

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g…

1ad53f1

…etAllRegionLocations() (apache#4442) Signed-off-by: Duo Zhang <zhangduo@apache.org>

huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request May 26, 2022

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g…

7787ad2

…etAllRegionLocations() (apache#4442) Signed-off-by: Duo Zhang <zhangduo@apache.org>

huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request May 26, 2022

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g…

1ceb7e7

…etAllRegionLocations() (apache#4442) Signed-off-by: Duo Zhang <zhangduo@apache.org>

huaxiangsun added a commit that referenced this pull request Jun 2, 2022

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g…

672b0a5

…etAllRegionLocations() (#4442) (#4464) Signed-off-by: Duo Zhang <zhangduo@apache.org>

huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request Jun 2, 2022

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g…

89d9181

…etAllRegionLocations() (apache#4442) Signed-off-by: Duo Zhang <zhangduo@apache.org>

huaxiangsun mentioned this pull request Jun 2, 2022

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g… #4484

Merged

huaxiangsun added a commit to huaxiangsun/hbase that referenced this pull request Jun 2, 2022

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g…

4c0e69c

…etAllRegionLocations() (apache#4442) Signed-off-by: Duo Zhang <zhangduo@apache.org>

huaxiangsun mentioned this pull request Jun 2, 2022

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g… #4485

Merged

huaxiangsun added a commit that referenced this pull request Jun 3, 2022

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g…

5a13ad8

…etAllRegionLocations() (#4442) (#4484) Signed-off-by: Duo Zhang <zhangduo@apache.org>

huaxiangsun added a commit that referenced this pull request Jun 3, 2022

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g…

976dbe8

…etAllRegionLocations() (#4442) (#4485) Signed-off-by: Duo Zhang <zhangduo@apache.org>

wenwj0 pushed a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g…

33041da

…etAllRegionLocations() (apache#4442) Signed-off-by: Duo Zhang <zhangduo@apache.org>

wenwj0 added a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022

Revert "HBASE-26649 Support meta replica LoadBalance mode for RegionL…

ce2460b

…ocator#getAllRegionLocations() (apache#4442)" This reverts commit 33041da.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g… #4442

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g… #4442

huaxiangsun commented May 18, 2022

huaxiangsun commented May 18, 2022

Apache-HBase commented May 18, 2022

Apache-HBase commented May 18, 2022

Apache-HBase commented May 18, 2022

huaxiangsun commented May 18, 2022

Apache-HBase commented May 18, 2022

Apache-HBase commented May 19, 2022

Apache9 May 19, 2022

huaxiangsun May 19, 2022

Apache9 May 19, 2022

huaxiangsun May 19, 2022

Apache-HBase commented May 19, 2022

Apache-HBase commented May 19, 2022

Apache-HBase commented May 19, 2022

huaxiangsun commented May 23, 2022

Apache9 commented May 24, 2022

huaxiangsun commented May 26, 2022

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g… #4442

HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g… #4442

Conversation

huaxiangsun commented May 18, 2022

huaxiangsun commented May 18, 2022

Apache-HBase commented May 18, 2022

Apache-HBase commented May 18, 2022

Apache-HBase commented May 18, 2022

huaxiangsun commented May 18, 2022

Apache-HBase commented May 18, 2022

Apache-HBase commented May 19, 2022

Apache9 May 19, 2022

Choose a reason for hiding this comment

huaxiangsun May 19, 2022

Choose a reason for hiding this comment

Apache9 May 19, 2022

Choose a reason for hiding this comment

huaxiangsun May 19, 2022

Choose a reason for hiding this comment

Apache-HBase commented May 19, 2022

Apache-HBase commented May 19, 2022

Apache-HBase commented May 19, 2022

huaxiangsun commented May 23, 2022

Apache9 commented May 24, 2022

huaxiangsun commented May 26, 2022