HBASE-27046 The filenum in AbstractFSWAL should be monotone increasing #4449

Apache9 · 2022-05-19T08:06:53Z

No description provided.

Apache-HBase · 2022-05-19T08:44:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 59s	master passed
+1 💚	compile	2m 16s	master passed
+1 💚	checkstyle	0m 32s	master passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 6s	the patch passed
+1 💚	compile	2m 10s	the patch passed
+1 💚	javac	2m 10s	the patch passed
+1 💚	checkstyle	0m 28s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	hadoopcheck	8m 42s	The patch causes 10 errors with Hadoop v3.3.1.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 17s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		26m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4449
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux f423c6c9e276 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `76d20fc`
Default Java	AdoptOpenJDK-1.8.0_282-b08
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/1/artifact/yetus-general-check/output/patch-javac-3.3.1.txt
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-19T12:37:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 21s	master passed
+1 💚	compile	0m 39s	master passed
+1 💚	shadedjars	3m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 13s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	shadedjars	3m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	242m 40s	hbase-server in the patch failed.
		259m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4449
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 41330ea4a14f 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `76d20fc`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/1/testReport/
Max. process+thread count	2529 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-02T13:19:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 29s	master passed
+1 💚	compile	2m 15s	master passed
+1 💚	checkstyle	0m 29s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 6s	the patch passed
+1 💚	compile	2m 10s	the patch passed
+1 💚	javac	2m 10s	the patch passed
+1 💚	checkstyle	0m 27s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 55s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 17s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		31m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4449
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 9fbf616ad127 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e555ac4`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ddupg

+1

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java

GeorryHuang

+1

Apache-HBase · 2022-06-02T16:17:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 24s	master passed
+1 💚	compile	0m 40s	master passed
+1 💚	shadedjars	3m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 19s	the patch passed
+1 💚	compile	0m 40s	the patch passed
+1 💚	javac	0m 40s	the patch passed
+1 💚	shadedjars	3m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
-1 ❌	unit	192m 12s	hbase-server in the patch failed.
		209m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4449
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cdbcec400e2e 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e555ac4`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/2/testReport/
Max. process+thread count	2551 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

#4449) Signed-off-by: Xin Sun <ddupgs@gmail.com> Signed-off-by: GeorryHuang <huangzhuoyue@apache.org> (cherry picked from commit 313a37f)

Apache-HBase · 2022-06-02T16:57:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 0s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 29s	master passed
+1 💚	compile	0m 43s	master passed
+1 💚	shadedjars	4m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	shadedjars	4m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	226m 58s	hbase-server in the patch passed.
		249m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4449
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8b7ec00107f7 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e555ac4`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/2/testReport/
Max. process+thread count	2731 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-02T17:01:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 6s	#4449 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#4449
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/3/console
versions	git=2.25.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-02T17:16:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 2s	#4449 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#4449
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/3/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-06-02T17:17:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 2s	#4449 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#4449
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4449/3/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

apache#4449) Signed-off-by: Xin Sun <ddupgs@gmail.com> Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>

…ncreasing (apache#4449)" This reverts commit 595d9df.

apache#4449) Signed-off-by: Xin Sun <ddupgs@gmail.com> Signed-off-by: GeorryHuang <huangzhuoyue@apache.org> (cherry picked from commit 313a37f) Change-Id: I013dbf9d8d999d55b13046a59c87e903dcc22125

HBASE-27046 The filenum in AbstractFSWAL should be monotone increasing

4c09e07

Apache9 self-assigned this May 19, 2022

ddupg approved these changes Jun 2, 2022

View reviewed changes

GeorryHuang reviewed Jun 2, 2022

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java Show resolved Hide resolved

GeorryHuang approved these changes Jun 2, 2022

View reviewed changes

Apache9 merged commit 313a37f into apache:master Jun 2, 2022

Apache9 added a commit that referenced this pull request Jun 2, 2022

HBASE-27046 The filenum in AbstractFSWAL should be monotone increasing (

9ea3e39

#4449) Signed-off-by: Xin Sun <ddupgs@gmail.com> Signed-off-by: GeorryHuang <huangzhuoyue@apache.org> (cherry picked from commit 313a37f)

Apache9 added a commit that referenced this pull request Jun 2, 2022

HBASE-27046 The filenum in AbstractFSWAL should be monotone increasing (

2625c67

#4449) Signed-off-by: Xin Sun <ddupgs@gmail.com> Signed-off-by: GeorryHuang <huangzhuoyue@apache.org> (cherry picked from commit 313a37f)

Apache9 added a commit that referenced this pull request Jun 2, 2022

HBASE-27046 The filenum in AbstractFSWAL should be monotone increasing (

f97af48

#4449) Signed-off-by: Xin Sun <ddupgs@gmail.com> Signed-off-by: GeorryHuang <huangzhuoyue@apache.org> (cherry picked from commit 313a37f)

wenwj0 pushed a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022

HBASE-27046 The filenum in AbstractFSWAL should be monotone increasing (

595d9df

apache#4449) Signed-off-by: Xin Sun <ddupgs@gmail.com> Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>

wenwj0 added a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022

Revert "HBASE-27046 The filenum in AbstractFSWAL should be monotone i…

8b9e29c

…ncreasing (apache#4449)" This reverts commit 595d9df.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27046 The filenum in AbstractFSWAL should be monotone increasing #4449

HBASE-27046 The filenum in AbstractFSWAL should be monotone increasing #4449

Apache9 commented May 19, 2022

Apache-HBase commented May 19, 2022

Apache-HBase commented May 19, 2022

Apache-HBase commented Jun 2, 2022

ddupg left a comment

GeorryHuang left a comment

Apache-HBase commented Jun 2, 2022

Apache-HBase commented Jun 2, 2022

Apache-HBase commented Jun 2, 2022

Apache-HBase commented Jun 2, 2022

Apache-HBase commented Jun 2, 2022

HBASE-27046 The filenum in AbstractFSWAL should be monotone increasing #4449

HBASE-27046 The filenum in AbstractFSWAL should be monotone increasing #4449

Conversation

Apache9 commented May 19, 2022

Apache-HBase commented May 19, 2022

Apache-HBase commented May 19, 2022

Apache-HBase commented Jun 2, 2022

ddupg left a comment

Choose a reason for hiding this comment

GeorryHuang left a comment

Choose a reason for hiding this comment

Apache-HBase commented Jun 2, 2022

Apache-HBase commented Jun 2, 2022

Apache-HBase commented Jun 2, 2022

Apache-HBase commented Jun 2, 2022

Apache-HBase commented Jun 2, 2022