HBASE-27194 Add test coverage for SimpleRpcServer #4616

apurtell · 2022-07-12T21:01:25Z

Add test coverage for SimpleRpcServer.

Improve the way we test both SimpleRpcServer and NettyRpcServer: Use LoadTestKVGenerator to generate random values with varying sizes between 1000 bytes and 1M bytes, and also to verify them when reading the values back.

Add secure test coverage for both SimpleRpcServer and NettyRpcServer.

Add test coverage for SimpleRpcServer. Improve the way we test both SimpleRpcServer and NettyRpcServer. Use LoadTestKVGenerator to generate random values with varying sizes between 1000 bytes and 1M bytes, and also to verify them when reading the values back. Add secure test coverage for both SimpleRpcServer and NettyRpcServer.

Apache-HBase · 2022-07-12T21:47:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 33s	master passed
+1 💚	compile	2m 16s	master passed
+1 💚	checkstyle	0m 28s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 4s	the patch passed
+1 💚	compile	2m 12s	the patch passed
+1 💚	javac	2m 12s	the patch passed
+1 💚	checkstyle	0m 27s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 45s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 19s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		31m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4616/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4616
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux ce18e62f7f69 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7cb7100`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	69 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4616/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

apurtell · 2022-07-12T21:52:23Z

Local test results

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.ipc.TestSimpleRpcServer
[INFO] Running org.apache.hadoop.hbase.ipc.TestSecureNettyRpcServer
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.248 s - in org.apache.hadoop.hbase.ipc.TestSimpleRpcServer
[INFO] Running org.apache.hadoop.hbase.ipc.TestSecureSimpleRpcServer
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.826 s - in org.apache.hadoop.hbase.ipc.TestSecureSimpleRpcServer
[INFO] Running org.apache.hadoop.hbase.ipc.TestNettyRpcServer
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 44.923 s - in org.apache.hadoop.hbase.ipc.TestSecureNettyRpcServer
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 38.031 s - in org.apache.hadoop.hbase.ipc.TestNettyRpcServer

virajjasani

Awesome, +1 (pending QA)

Apache-HBase · 2022-07-13T01:00:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 57s	master passed
+1 💚	compile	0m 47s	master passed
+1 💚	shadedjars	3m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 39s	the patch passed
+1 💚	compile	0m 46s	the patch passed
+1 💚	javac	0m 46s	the patch passed
+1 💚	shadedjars	3m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	206m 24s	hbase-server in the patch passed.
		224m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4616/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4616
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 62328c59a636 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7cb7100`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4616/1/testReport/
Max. process+thread count	2719 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4616/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-13T01:13:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 36s	master passed
+1 💚	compile	0m 40s	master passed
+1 💚	shadedjars	3m 50s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 18s	the patch passed
+1 💚	compile	0m 41s	the patch passed
+1 💚	javac	0m 41s	the patch passed
+1 💚	shadedjars	3m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	220m 12s	hbase-server in the patch passed.
		237m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4616/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4616
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c47617eea61d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7cb7100`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4616/1/testReport/
Max. process+thread count	2495 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4616/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcServer.java

Add test coverage for SimpleRpcServer. Improve the way we test both SimpleRpcServer and NettyRpcServer. Use LoadTestKVGenerator to generate random values with varying sizes between 1000 bytes and 1M bytes, and also to verify them when reading the values back. Add secure test coverage for both SimpleRpcServer and NettyRpcServer. Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

When backporting to branch-2 it was discovered that the order of tear down operations requires the KDC to be torn down first, although on master branch the original code did not produce the same errors (a NPE in KDC#stop). Forward port the difference for maintainability. Signed-off-by: Andrew Purtell <apurtell@apache.org>

apurtell requested review from Apache9 and virajjasani July 12, 2022 21:01

virajjasani approved these changes Jul 12, 2022

View reviewed changes

Apache9 approved these changes Jul 13, 2022

View reviewed changes

hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcServer.java Outdated Show resolved Hide resolved

hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcServer.java Outdated Show resolved Hide resolved

Address review feedback

cf775e8

apurtell merged commit 84f0d14 into apache:master Jul 13, 2022

apurtell deleted the HBASE-27194 branch July 13, 2022 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27194 Add test coverage for SimpleRpcServer #4616

HBASE-27194 Add test coverage for SimpleRpcServer #4616

apurtell commented Jul 12, 2022

Apache-HBase commented Jul 12, 2022

apurtell commented Jul 12, 2022 •

edited

virajjasani left a comment

Apache-HBase commented Jul 13, 2022

Apache-HBase commented Jul 13, 2022

HBASE-27194 Add test coverage for SimpleRpcServer #4616

HBASE-27194 Add test coverage for SimpleRpcServer #4616

Conversation

apurtell commented Jul 12, 2022

Apache-HBase commented Jul 12, 2022

apurtell commented Jul 12, 2022 • edited

virajjasani left a comment

Choose a reason for hiding this comment

Apache-HBase commented Jul 13, 2022

Apache-HBase commented Jul 13, 2022

apurtell commented Jul 12, 2022 •

edited