Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-27205 Fix tests that rely on EnvironmentEdgeManager in branch-2.4 (addendum) #4631

Merged
merged 1 commit into from Jul 18, 2022
Merged

HBASE-27205 Fix tests that rely on EnvironmentEdgeManager in branch-2.4 (addendum) #4631

merged 1 commit into from Jul 18, 2022

Conversation

bbeaudreault
Copy link
Contributor

@bbeaudreault bbeaudreault commented Jul 16, 2022 •
edited

I wasn't sure if an addendum was the way to go here, so let me know if a new jira would be better

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 53s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2.4 Compile Tests _
+1 💚 mvninstall 2m 15s branch-2.4 passed
+1 💚 compile 2m 10s branch-2.4 passed
+1 💚 checkstyle 0m 29s branch-2.4 passed
+1 💚 spotless 0m 45s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 13s branch-2.4 passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 51s the patch passed
+1 💚 compile 2m 9s the patch passed
+1 💚 javac 2m 9s the patch passed
+1 💚 checkstyle 0m 28s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 10m 52s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.
+1 💚 spotless 0m 38s patch has no errors when running spotless:check.
+1 💚 spotbugs 1m 18s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
30m 16s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4631
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux dd28b878f858 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.4 / cc62da2
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 68 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 54s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+1 💚 mvninstall 2m 28s branch-2.4 passed
+1 💚 compile 0m 37s branch-2.4 passed
+1 💚 shadedjars 4m 21s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 24s branch-2.4 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 14s the patch passed
+1 💚 compile 0m 36s the patch passed
+1 💚 javac 0m 36s the patch passed
+1 💚 shadedjars 4m 17s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 22s the patch passed
_ Other Tests _
+1 💚 unit 160m 36s hbase-server in the patch passed.
178m 17s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4631
Optional Tests javac javadoc unit shadedjars compile
uname Linux 083c35522774 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.4 / cc62da2
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/testReport/
Max. process+thread count 2858 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 57s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+1 💚 mvninstall 2m 11s branch-2.4 passed
+1 💚 compile 0m 31s branch-2.4 passed
+1 💚 shadedjars 4m 12s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 23s branch-2.4 passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 53s the patch passed
+1 💚 compile 0m 32s the patch passed
+1 💚 javac 0m 32s the patch passed
+1 💚 shadedjars 4m 11s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 20s the patch passed
_ Other Tests _
+1 💚 unit 164m 44s hbase-server in the patch passed.
181m 33s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #4631
Optional Tests javac javadoc unit shadedjars compile
uname Linux a64539e818ca 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.4 / cc62da2
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/testReport/
Max. process+thread count 2534 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4631/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell
Copy link
Contributor

lgtm thanks for jumping on this @bbeaudreault

@bbeaudreault
Copy link
Contributor Author

@virajjasani no rush, but any chance you can test this patch out in your environment's tests to ensure that it solves the issue. If possible would like to avoid having to push a bunch more addendums. As mentioned, I ran them a bunch myself but would be good to know it solves your issue specifically.

@virajjasani
Copy link
Contributor

Sounds good, on it.

@virajjasani
Copy link
Contributor

We are all good here, thanks a lot @bbeaudreault!

@bbeaudreault
Copy link
Contributor Author

Great, thanks for checking!

@bbeaudreault bbeaudreault merged commit f5f248d into apache:branch-2.4 Jul 18, 2022
@bbeaudreault bbeaudreault deleted the HBASE-27205-addendum branch July 18, 2022 18:54
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@bbeaudreault
HBASE-27205 Fix tests that rely on EnvironmentEdgeManager in branch-2…
ba70a32 
….4 (addendum) (apache#4631)

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit f5f248d)
Change-Id: I061fe714855e6f4963b1743c53ced9f4dd9f44b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apurtell apurtell apurtell approved these changes

@virajjasani virajjasani virajjasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@bbeaudreault @Apache-HBase @apurtell @virajjasani