HBASE-27236 Clean up error-prone warnings in hbase-hbtop #4649

apurtell · 2022-07-25T06:05:19Z

No description provided.

Apache-HBase · 2022-07-25T06:30:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 25s	master passed
+1 💚	compile	0m 13s	master passed
+1 💚	shadedjars	3m 44s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	0m 12s	the patch passed
+1 💚	javac	0m 12s	the patch passed
+1 💚	shadedjars	3m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 26s	hbase-hbtop in the patch passed.
		15m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4649
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0fcfb58e819c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b1706a8`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/1/testReport/
Max. process+thread count	152 (vs. ulimit of 30000)
modules	C: hbase-hbtop U: hbase-hbtop
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-25T06:30:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 19s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 53s	master passed
+1 💚	compile	0m 13s	master passed
+1 💚	shadedjars	3m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	shadedjars	3m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 31s	hbase-hbtop in the patch passed.
		15m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4649
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0a9b27f33d6a 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b1706a8`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/1/testReport/
Max. process+thread count	183 (vs. ulimit of 30000)
modules	C: hbase-hbtop U: hbase-hbtop
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-25T06:45:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 21s	master passed
+1 💚	compile	0m 22s	master passed
+1 💚	checkstyle	0m 9s	master passed
+1 💚	spotless	0m 56s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 21s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 55s	the patch passed
+1 💚	compile	0m 22s	the patch passed
+1 💚	javac	0m 22s	hbase-hbtop generated 0 new + 0 unchanged - 8 fixed = 0 total (was 8)
-0 ⚠️	checkstyle	0m 8s	hbase-hbtop: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 33s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 45s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 24s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		29m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4649
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 316f5bb8c1bd 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b1706a8`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-hbtop.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-hbtop U: hbase-hbtop
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/HBTop.java

apurtell · 2022-07-26T00:35:36Z

Rebased. Address review feedback.

Apache-HBase · 2022-07-26T01:05:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 30s	master passed
+1 💚	compile	0m 9s	master passed
+1 💚	shadedjars	3m 57s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 11s	the patch passed
+1 💚	compile	0m 10s	the patch passed
+1 💚	javac	0m 10s	the patch passed
+1 💚	shadedjars	3m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 23s	hbase-hbtop in the patch passed.
		15m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4649
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0f32ac9d1fcb 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ca545c4`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/2/testReport/
Max. process+thread count	155 (vs. ulimit of 30000)
modules	C: hbase-hbtop U: hbase-hbtop
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-26T01:05:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 20s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 52s	master passed
+1 💚	compile	0m 13s	master passed
+1 💚	shadedjars	3m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 40s	the patch passed
+1 💚	compile	0m 13s	the patch passed
+1 💚	javac	0m 13s	the patch passed
+1 💚	shadedjars	3m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 31s	hbase-hbtop in the patch passed.
		15m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4649
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f3084ffdc338 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ca545c4`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/2/testReport/
Max. process+thread count	179 (vs. ulimit of 30000)
modules	C: hbase-hbtop U: hbase-hbtop
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-07-26T01:21:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 43s	master passed
+1 💚	compile	0m 29s	master passed
+1 💚	checkstyle	0m 13s	master passed
+1 💚	spotless	0m 54s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 52s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	hbase-hbtop generated 0 new + 0 unchanged - 8 fixed = 0 total (was 8)
-0 ⚠️	checkstyle	0m 8s	hbase-hbtop: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 24s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 47s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 30s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		31m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4649
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 81cf102ceb31 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ca545c4`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-hbtop.txt
Max. process+thread count	67 (vs. ulimit of 30000)
modules	C: hbase-hbtop U: hbase-hbtop
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4649/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Duo Zhang <zhangduo@apache.org>

apurtell requested review from Apache9 and virajjasani July 25, 2022 06:05

Apache9 approved these changes Jul 25, 2022

View reviewed changes

hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/HBTop.java Outdated Show resolved Hide resolved

apurtell added 2 commits July 25, 2022 17:33

HBASE-27236 Clean up error-prone warnings in hbase-hbtop

3a24787

Address review feedback, fix typo

4dbc70e

apurtell force-pushed the HBASE-27236 branch from 43fd205 to 4dbc70e Compare July 26, 2022 00:35

apurtell requested a review from Apache9 July 26, 2022 00:35

apurtell merged commit 234cdf7 into apache:master Jul 27, 2022

apurtell deleted the HBASE-27236 branch July 27, 2022 01:04

asfgit pushed a commit that referenced this pull request Jul 27, 2022

HBASE-27236 Clean up error-prone warnings in hbase-hbtop (#4649)

6f3538b

Signed-off-by: Duo Zhang <zhangduo@apache.org>

asfgit pushed a commit that referenced this pull request Jul 27, 2022

HBASE-27236 Clean up error-prone warnings in hbase-hbtop (#4649)

32cc65e

Signed-off-by: Duo Zhang <zhangduo@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27236 Clean up error-prone warnings in hbase-hbtop #4649

HBASE-27236 Clean up error-prone warnings in hbase-hbtop #4649

apurtell commented Jul 25, 2022

Apache-HBase commented Jul 25, 2022

Apache-HBase commented Jul 25, 2022

Apache-HBase commented Jul 25, 2022

apurtell commented Jul 26, 2022

Apache-HBase commented Jul 26, 2022

Apache-HBase commented Jul 26, 2022

Apache-HBase commented Jul 26, 2022

HBASE-27236 Clean up error-prone warnings in hbase-hbtop #4649

HBASE-27236 Clean up error-prone warnings in hbase-hbtop #4649

Conversation

apurtell commented Jul 25, 2022

Apache-HBase commented Jul 25, 2022

Apache-HBase commented Jul 25, 2022

Apache-HBase commented Jul 25, 2022

apurtell commented Jul 26, 2022

Apache-HBase commented Jul 26, 2022

Apache-HBase commented Jul 26, 2022

Apache-HBase commented Jul 26, 2022