-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27246 RSGroupMappingScript#getRSGroup has thread safety problem #4657
Conversation
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Why not just create a ShellCommandExecutor everytime? |
Checked the ShellCommandExecutor constructor and find no time costly step. Has changed to local variable creation. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Let's change the title? |
Please run spotless:apply to fix the style issue? Thanks. |
🎊 +1 overall
This message was automatically generated. |
Sorry for the delay, but has already run the spotless to fix the style. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
…apache#4657) Co-authored-by: Sean Xiao Yutong <sean.xiaoyt@shopee.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit b44bfc5) Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java (cherry picked from commit c8969e1) Change-Id: I99297454aea61bbbf33f980f67e0b5673b14537c
https://issues.apache.org/jira/browse/HBASE-27246