HBASE-27321 The ReplicationLogCleaner is not thread safe but can be c… #4730

Apache9 · 2022-08-25T11:14:33Z

…alled from different threads at the same time

Apache-HBase · 2022-08-25T11:57:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 22s	master passed
+1 💚	compile	0m 49s	master passed
+1 💚	shadedjars	4m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 10s	the patch passed
+1 💚	compile	0m 49s	the patch passed
+1 💚	javac	0m 49s	the patch passed
+1 💚	shadedjars	4m 0s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 33s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 28s	hbase-common in the patch passed.
-1 ❌	unit	8m 7s	hbase-server in the patch failed.
		27m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4730
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a73252d7b171 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `92cf962`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/1/testReport/
Max. process+thread count	569 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-25T12:01:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 28s	master passed
+1 💚	compile	2m 44s	master passed
+1 💚	checkstyle	0m 40s	master passed
+1 💚	spotless	0m 38s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 41s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 8s	the patch passed
+1 💚	compile	2m 43s	the patch passed
+1 💚	javac	2m 43s	the patch passed
-0 ⚠️	checkstyle	0m 28s	hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 13s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
-1 ❌	spotbugs	1m 22s	hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		31m 14s

Reason	Tests
FindBugs	module:hbase-server
	Inconsistent synchronization of org.apache.hadoop.hbase.master.cleaner.CleanerChore.future; locked 75% of time Unsynchronized access at CleanerChore.java:75% of time Unsynchronized access at CleanerChore.java:[line 244]

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4730
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux b9ebda4b963b 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `92cf962`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-25T15:38:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	15m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 55s	master passed
+1 💚	compile	1m 6s	master passed
+1 💚	shadedjars	3m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	1m 5s	the patch passed
+1 💚	javac	1m 5s	the patch passed
+1 💚	shadedjars	3m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 6s	hbase-common in the patch passed.
+1 💚	unit	211m 40s	hbase-server in the patch passed.
		248m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4730
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ccb2d0d7c9a5 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `92cf962`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/1/testReport/
Max. process+thread count	2606 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-25T16:11:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 14s	master passed
+1 💚	compile	2m 44s	master passed
+1 💚	checkstyle	0m 38s	master passed
+1 💚	spotless	0m 36s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 38s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 10s	the patch passed
+1 💚	compile	2m 43s	the patch passed
+1 💚	javac	2m 43s	the patch passed
-0 ⚠️	checkstyle	0m 27s	hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 9s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 36s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 52s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		30m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4730
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 0adc25fe84e6 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `92cf962`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-25T19:33:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 48s	master passed
+1 💚	compile	1m 7s	master passed
+1 💚	shadedjars	3m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 38s	the patch passed
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
+1 💚	shadedjars	3m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 8s	hbase-common in the patch passed.
+1 💚	unit	210m 43s	hbase-server in the patch passed.
		233m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4730
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1fc67bbf67a0 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `92cf962`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/2/testReport/
Max. process+thread count	2647 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-25T19:37:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 25s	master passed
+1 💚	compile	0m 59s	master passed
+1 💚	shadedjars	3m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 15s	the patch passed
+1 💚	compile	0m 56s	the patch passed
+1 💚	javac	0m 56s	the patch passed
+1 💚	shadedjars	3m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 44s	hbase-common in the patch passed.
+1 💚	unit	215m 31s	hbase-server in the patch passed.
		236m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4730
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8f6a161e4d69 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `92cf962`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/2/testReport/
Max. process+thread count	2457 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-25T20:08:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 9s	master passed
+1 💚	compile	2m 41s	master passed
+1 💚	checkstyle	0m 37s	master passed
+1 💚	spotless	0m 35s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 7s	the patch passed
+1 💚	compile	2m 39s	the patch passed
+1 💚	javac	2m 39s	the patch passed
+1 💚	checkstyle	0m 38s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 0s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 35s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 48s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		29m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4730
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 7ba945e26335 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `92cf962`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-25T20:12:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 9s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	4m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 6s	the patch passed
+1 💚	compile	1m 5s	the patch passed
+1 💚	javac	1m 5s	the patch passed
+1 💚	shadedjars	4m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 4s	hbase-common in the patch passed.
-1 ❌	unit	11m 47s	hbase-server in the patch failed.
		34m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4730
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux eeedf37c26ce 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `92cf962`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/3/testReport/
Max. process+thread count	584 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-25T23:51:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 10s	master passed
+1 💚	compile	0m 49s	master passed
+1 💚	shadedjars	4m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s	the patch passed
+1 💚	compile	1m 16s	the patch passed
+1 💚	javac	1m 16s	the patch passed
+1 💚	shadedjars	5m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 54s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 49s	hbase-common in the patch passed.
-1 ❌	unit	230m 4s	hbase-server in the patch failed.
		253m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4730
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4c3ae827b330 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `92cf962`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/3/testReport/
Max. process+thread count	2646 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-08-26T01:44:53Z

Ah, let me check the TestCleanerChore.

Apache9 · 2022-08-26T01:49:04Z

2022-08-25T20:03:33,978 WARN  [hfile_cleaner-dir-scan-pool-1] cleaner.CleanerChore(411): Attempted to delete:file:/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4730/yetus-jdk11-hadoop3-check/src/hbase-server/target/test-data/9bca84d1-7e68-2548-36e6-a8726d0c142c/child/file, but couldn't. Run cleaner chain and attempt to delete on next pass.

Strange...

Apache9 · 2022-08-26T01:55:16Z

2022-08-25T20:03:33,977 DEBUG [cleaner.Chore.1] hbase.ScheduledChore(165): test-retry-ioe execution time: 22 ms.
2022-08-25T20:03:33,978 WARN  [hfile_cleaner-dir-scan-pool-1] cleaner.CleanerChore(411): Attempted to delete:file:/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4730/yetus-jdk11-hadoop3-check/src/hbase-server/target/test-data/9bca84d1-7e68-2548-36e6-a8726d0c142c/child/file, but couldn't. Run cleaner chain and attempt to delete on next pass.
2022-08-25T20:03:33,979 DEBUG [cleaner.Chore.2] hbase.ScheduledChore(165): test-retry-ioe execution time: 32 ms.

OK, seems we execute the chore at the same time concurrently in different chore thread. Let me dig more on how could this happen.

…alled from different threads at the same time

Apache-HBase · 2022-08-26T05:27:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 43s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 18s	master passed
+1 💚	compile	3m 36s	master passed
+1 💚	checkstyle	1m 0s	master passed
+1 💚	spotless	0m 54s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 23s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 6s	the patch passed
+1 💚	compile	4m 11s	the patch passed
+1 💚	javac	4m 11s	the patch passed
+1 💚	checkstyle	0m 55s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 27s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 43s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 17s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 19s	The patch does not generate ASF License warnings.
		42m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4730
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 29fe1d8233d0 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `92cf962`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-26T08:44:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 38s	master passed
+1 💚	compile	1m 5s	master passed
+1 💚	shadedjars	3m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
+1 💚	shadedjars	3m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 7s	hbase-common in the patch passed.
+1 💚	unit	217m 7s	hbase-server in the patch passed.
		239m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4730
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e8dab7eaaa97 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `92cf962`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/4/testReport/
Max. process+thread count	2724 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-26T08:50:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 46s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 44s	master passed
+1 💚	compile	0m 51s	master passed
+1 💚	shadedjars	4m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 56s	the patch passed
+1 💚	compile	1m 13s	the patch passed
+1 💚	javac	1m 13s	the patch passed
+1 💚	shadedjars	5m 0s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 45s	hbase-common in the patch passed.
+1 💚	unit	221m 5s	hbase-server in the patch passed.
		245m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4730
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7c23709f1b83 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `92cf962`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/4/testReport/
Max. process+thread count	2601 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4730/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ddupg

+1

…alled from different threads at the same time (#4730) Signed-off-by: Xin Sun <ddupgs@gmail.com> (cherry picked from commit 37651ee)

Apache9 self-assigned this Aug 25, 2022

Apache9 force-pushed the HBASE-27321 branch from 85f8e7e to 1e751f2 Compare August 25, 2022 13:29

HBASE-27321 The ReplicationLogCleaner is not thread safe but can be c…

c366b78

…alled from different threads at the same time

Apache9 force-pushed the HBASE-27321 branch from a880b4d to c366b78 Compare August 26, 2022 04:36

ddupg approved these changes Aug 26, 2022

View reviewed changes

Apache9 merged commit 37651ee into apache:master Aug 27, 2022

Apache9 added a commit that referenced this pull request Aug 27, 2022

HBASE-27321 The ReplicationLogCleaner is not thread safe but can be c…

935b0d2

…alled from different threads at the same time (#4730) Signed-off-by: Xin Sun <ddupgs@gmail.com> (cherry picked from commit 37651ee)

ndimiduk mentioned this pull request Mar 1, 2024

HBASE-28413 Fix race condition in TestCleanerChore.retriesIOExceptionInStatus #5735

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27321 The ReplicationLogCleaner is not thread safe but can be c… #4730

HBASE-27321 The ReplicationLogCleaner is not thread safe but can be c… #4730

Apache9 commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache9 commented Aug 26, 2022

Apache9 commented Aug 26, 2022

Apache9 commented Aug 26, 2022

Apache-HBase commented Aug 26, 2022

Apache-HBase commented Aug 26, 2022

Apache-HBase commented Aug 26, 2022

ddupg left a comment

HBASE-27321 The ReplicationLogCleaner is not thread safe but can be c… #4730

HBASE-27321 The ReplicationLogCleaner is not thread safe but can be c… #4730

Conversation

Apache9 commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache-HBase commented Aug 25, 2022

Apache9 commented Aug 26, 2022

Apache9 commented Aug 26, 2022

Apache9 commented Aug 26, 2022

Apache-HBase commented Aug 26, 2022

Apache-HBase commented Aug 26, 2022

Apache-HBase commented Aug 26, 2022

ddupg left a comment

Choose a reason for hiding this comment