HBASE-27419 Update to hbase-thirdparty 4.1.2 #4818

Apache9 · 2022-10-07T15:10:01Z

No description provided.

Apache-HBase · 2022-10-07T15:53:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 56s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 22s	master passed
+1 💚	compile	6m 26s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 6s	the patch passed
+1 💚	compile	6m 12s	the patch passed
-0 ⚠️	javac	6m 12s	root generated 1 new + 702 unchanged - 1 fixed = 703 total (was 703)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	7m 56s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 30s	The patch does not generate ASF License warnings.
		33m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4818
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile
uname	Linux 4f21b71a6f29 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46d37a7`
Default Java	Temurin-1.8.0_345-b01
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count	138 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

apurtell · 2022-10-07T18:23:14Z

hbase-protocol-shaded/pom.xml

@@ -34,7 +34,7 @@
    <!--Version of protobuf that hbase uses internally (we shade our pb)
         Must match what is out in hbase-thirdparty include.
    -->
-    <internal.protobuf.version>3.21.1</internal.protobuf.version>
+    <internal.protobuf.version>3.21.7</internal.protobuf.version>


Maybe there is a way to tie this setting to hbase-thirdparty somehow. Have hbase-thirdparty export a version property in its POM that we can use here.

Will open a new issue if I find a way to do this.

apurtell · 2022-10-07T18:23:45Z

hbase-examples/pom.xml

@@ -33,7 +33,7 @@
    <!--Version of protobuf that hbase uses internally (we shade our pb)
         Must match what is out in hbase-thirdparty include.
    -->
-    <internal.protobuf.version>3.17.3</internal.protobuf.version>
+    <internal.protobuf.version>3.21.7</internal.protobuf.version>


apurtell · 2022-10-07T18:24:30Z

pom.xml

+  <repositories>
+    <repository>
+      <id>staging</id>
+      <url>https://repository.apache.org/content/repositories/orgapachehbase-1496/</url>


Should we just wait for a release? We don't need 'staging' here then.

Apache-HBase · 2022-10-07T20:20:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 49s	master passed
+1 💚	compile	1m 58s	master passed
+1 💚	shadedjars	3m 49s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 23s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 29s	the patch passed
+1 💚	compile	1m 56s	the patch passed
+1 💚	javac	1m 56s	the patch passed
+1 💚	shadedjars	3m 48s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	273m 33s	root in the patch passed.
		299m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4818
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b3be86ebce9b 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46d37a7`
Default Java	Eclipse Adoptium-11.0.16.1+1
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/1/testReport/
Max. process+thread count	4978 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-07T22:29:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 26s	master passed
+1 💚	compile	1m 30s	master passed
+1 💚	shadedjars	4m 11s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 41s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 6s	the patch passed
+1 💚	compile	1m 29s	the patch passed
+1 💚	javac	1m 29s	the patch passed
+1 💚	shadedjars	4m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	401m 59s	root in the patch passed.
		428m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4818
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 73dc7656bac2 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46d37a7`
Default Java	Temurin-1.8.0_345-b01
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/1/testReport/
Max. process+thread count	4867 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-10T14:23:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 19s	master passed
+1 💚	compile	6m 2s	master passed
+1 💚	spotless	0m 37s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 3s	the patch passed
+1 💚	compile	5m 56s	the patch passed
-0 ⚠️	javac	5m 56s	root generated 12 new + 691 unchanged - 12 fixed = 703 total (was 703)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	8m 8s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 36s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 24s	The patch does not generate ASF License warnings.
		32m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4818
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile
uname	Linux d53c3478ce90 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46d37a7`
Default Java	Temurin-1.8.0_345-b01
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count	140 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-10T18:38:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 17s	master passed
+1 💚	compile	2m 33s	master passed
+1 💚	shadedjars	4m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 53s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 7s	the patch passed
+1 💚	compile	2m 16s	the patch passed
+1 💚	javac	2m 16s	the patch passed
+1 💚	shadedjars	4m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 0s	the patch passed
		_ Other Tests _
-1 ❌	unit	256m 53s	root in the patch failed.
		287m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4818
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3c4a7625294a 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46d37a7`
Default Java	Eclipse Adoptium-11.0.16.1+1
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/testReport/
Max. process+thread count	2408 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-10T21:32:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 50s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 39s	master passed
+1 💚	compile	1m 49s	master passed
+1 💚	shadedjars	4m 37s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 6s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	1m 52s	the patch passed
+1 💚	javac	1m 52s	the patch passed
+1 💚	shadedjars	5m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	435m 19s	root in the patch passed.
		462m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4818
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a835ac402e83 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `46d37a7`
Default Java	Temurin-1.8.0_345-b01
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/testReport/
Max. process+thread count	4786 (vs. ulimit of 30000)
modules	C: hbase-protocol-shaded hbase-examples . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4818/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit 79f853e)

Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit 79f853e) Change-Id: I98e5be059bc3f0f2de3205a82a79616a30a5fad0

Apache9 self-assigned this Oct 7, 2022

apurtell approved these changes Oct 7, 2022

View reviewed changes

HBASE-27419 Update to hbase-thirdparty 4.1.2

ab7e909

Apache9 force-pushed the HBASE-27419 branch from 4044eb3 to ab7e909 Compare October 10, 2022 13:35

Apache9 merged commit 79f853e into apache:master Oct 11, 2022

Apache9 added a commit that referenced this pull request Oct 11, 2022

HBASE-27419 Update to hbase-thirdparty 4.1.2 (#4818)

36abd38

Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit 79f853e)

Apache9 added a commit that referenced this pull request Oct 11, 2022

HBASE-27419 Update to hbase-thirdparty 4.1.2 (#4818)

ec8acd6

Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit 79f853e)

Apache9 added a commit that referenced this pull request Oct 11, 2022

HBASE-27419 Update to hbase-thirdparty 4.1.2 (#4818)

1ad9574

Signed-off-by: Andrew Purtell <apurtell@apache.org> (cherry picked from commit 79f853e)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27419 Update to hbase-thirdparty 4.1.2 #4818

HBASE-27419 Update to hbase-thirdparty 4.1.2 #4818

Apache9 commented Oct 7, 2022

Apache-HBase commented Oct 7, 2022

apurtell Oct 7, 2022 •

edited

Apache9 Oct 10, 2022

apurtell Oct 7, 2022 •

edited

apurtell Oct 7, 2022

Apache-HBase commented Oct 7, 2022

Apache-HBase commented Oct 7, 2022

Apache-HBase commented Oct 10, 2022

Apache-HBase commented Oct 10, 2022

Apache-HBase commented Oct 10, 2022

HBASE-27419 Update to hbase-thirdparty 4.1.2 #4818

HBASE-27419 Update to hbase-thirdparty 4.1.2 #4818

Conversation

Apache9 commented Oct 7, 2022

Apache-HBase commented Oct 7, 2022

apurtell Oct 7, 2022 • edited

Choose a reason for hiding this comment

Apache9 Oct 10, 2022

Choose a reason for hiding this comment

apurtell Oct 7, 2022 • edited

Choose a reason for hiding this comment

apurtell Oct 7, 2022

Choose a reason for hiding this comment

Apache-HBase commented Oct 7, 2022

Apache-HBase commented Oct 7, 2022

Apache-HBase commented Oct 10, 2022

Apache-HBase commented Oct 10, 2022

Apache-HBase commented Oct 10, 2022

apurtell Oct 7, 2022 •

edited

apurtell Oct 7, 2022 •

edited