Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-27420 Allow non-loopback for zk standalone server in minizkcluster #4819

Merged
merged 2 commits into from Oct 11, 2022
Merged

HBASE-27420 Allow non-loopback for zk standalone server in minizkcluster #4819

merged 2 commits into from Oct 11, 2022

Conversation

sanjeet006py
Copy link
Contributor

Link to JIRA: https://issues.apache.org/jira/browse/HBASE-27420

Add a provision to allow zk to listen for client connections on non-loopback IP.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 40s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 30s master passed
+1 💚 compile 0m 10s master passed
+1 💚 shadedjars 4m 3s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 11s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 3s the patch passed
+1 💚 compile 0m 10s the patch passed
+1 💚 javac 0m 10s the patch passed
+1 💚 shadedjars 4m 2s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 9s the patch passed
_ Other Tests _
+1 💚 unit 0m 35s hbase-zookeeper in the patch passed.
15m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4819
Optional Tests javac javadoc unit shadedjars compile
uname Linux c210aab837af 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 46d37a7
Default Java Temurin-1.8.0_345-b01
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/testReport/
Max. process+thread count 211 (vs. ulimit of 30000)
modules C: hbase-zookeeper U: hbase-zookeeper
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 59s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 38s master passed
+1 💚 compile 0m 15s master passed
+1 💚 shadedjars 3m 49s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 14s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 34s the patch passed
+1 💚 compile 0m 13s the patch passed
+1 💚 javac 0m 13s the patch passed
+1 💚 shadedjars 3m 46s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 12s the patch passed
_ Other Tests _
+1 💚 unit 0m 41s hbase-zookeeper in the patch passed.
16m 25s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4819
Optional Tests javac javadoc unit shadedjars compile
uname Linux a203c029c16c 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 46d37a7
Default Java Eclipse Adoptium-11.0.16.1+1
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/testReport/
Max. process+thread count 279 (vs. ulimit of 30000)
modules C: hbase-zookeeper U: hbase-zookeeper
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 59s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 2m 25s master passed
+1 💚 compile 0m 21s master passed
+1 💚 checkstyle 0m 10s master passed
+1 💚 spotless 0m 41s branch has no errors when running spotless:check.
+1 💚 spotbugs 0m 23s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 10s the patch passed
+1 💚 compile 0m 19s the patch passed
+1 💚 javac 0m 19s the patch passed
-0 ⚠️ checkstyle 0m 9s hbase-zookeeper: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 7m 56s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
-1 ❌ spotless 0m 18s patch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 💚 spotbugs 0m 25s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
21m 47s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4819
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux a2b017fd04fd 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 46d37a7
Default Java Temurin-1.8.0_345-b01
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-zookeeper.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 64 (vs. ulimit of 30000)
modules C: hbase-zookeeper U: hbase-zookeeper
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 2s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 46s master passed
+1 💚 compile 0m 15s master passed
+1 💚 shadedjars 3m 47s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 14s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 32s the patch passed
+1 💚 compile 0m 14s the patch passed
+1 💚 javac 0m 14s the patch passed
+1 💚 shadedjars 3m 49s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 12s the patch passed
_ Other Tests _
+1 💚 unit 0m 41s hbase-zookeeper in the patch passed.
16m 39s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4819
Optional Tests javac javadoc unit shadedjars compile
uname Linux 96dbbcdb4b34 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 46d37a7
Default Java Eclipse Adoptium-11.0.16.1+1
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/testReport/
Max. process+thread count 221 (vs. ulimit of 30000)
modules C: hbase-zookeeper U: hbase-zookeeper
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 49s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 41s master passed
+1 💚 compile 0m 10s master passed
+1 💚 shadedjars 3m 59s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 9s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 4s the patch passed
+1 💚 compile 0m 10s the patch passed
+1 💚 javac 0m 10s the patch passed
+1 💚 shadedjars 3m 58s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 9s the patch passed
_ Other Tests _
+1 💚 unit 0m 34s hbase-zookeeper in the patch passed.
15m 54s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4819
Optional Tests javac javadoc unit shadedjars compile
uname Linux bd5b4ab8eb90 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 46d37a7
Default Java Temurin-1.8.0_345-b01
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/testReport/
Max. process+thread count 160 (vs. ulimit of 30000)
modules C: hbase-zookeeper U: hbase-zookeeper
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 57s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 2m 14s master passed
+1 💚 compile 0m 19s master passed
+1 💚 checkstyle 0m 9s master passed
+1 💚 spotless 0m 39s branch has no errors when running spotless:check.
+1 💚 spotbugs 0m 21s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 10s the patch passed
+1 💚 compile 0m 19s the patch passed
+1 💚 javac 0m 19s the patch passed
+1 💚 checkstyle 0m 8s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 7m 53s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚 spotless 0m 40s patch has no errors when running spotless:check.
+1 💚 spotbugs 0m 25s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
21m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4819
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 483c6c71339d 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 46d37a7
Default Java Temurin-1.8.0_345-b01
Max. process+thread count 60 (vs. ulimit of 30000)
modules C: hbase-zookeeper U: hbase-zookeeper
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4819/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@apurtell apurtell merged commit b656456 into apache:master Oct 11, 2022
asfgit pushed a commit that referenced this pull request Oct 11, 2022
@sanjeet006py @apurtell
HBASE-27420 Allow non-loopback for zk standalone server in minizkclus…
440d168 
…ter (#4819)

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Co-authored-by: Sanjeet Malhotra <sanjeetmalhotra@salesforce.com>
asfgit pushed a commit that referenced this pull request Oct 11, 2022
@sanjeet006py @apurtell
HBASE-27420 Allow non-loopback for zk standalone server in minizkclus…
00f72f3 
…ter (#4819)

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Co-authored-by: Sanjeet Malhotra <sanjeetmalhotra@salesforce.com>
asfgit pushed a commit that referenced this pull request Oct 11, 2022
@sanjeet006py @apurtell
HBASE-27420 Allow non-loopback for zk standalone server in minizkclus…
72c79b6 
…ter (#4819)

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Co-authored-by: Sanjeet Malhotra <sanjeetmalhotra@salesforce.com>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@sanjeet006py @apurtell
HBASE-27420 Allow non-loopback for zk standalone server in minizkclus…
43f8c76 
…ter (apache#4819)

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Co-authored-by: Sanjeet Malhotra <sanjeetmalhotra@salesforce.com>
(cherry picked from commit 00f72f3)
Change-Id: I25f25c6f38796ab207608f35587bd1637f23ef1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apurtell apurtell apurtell approved these changes

@virajjasani virajjasani virajjasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sanjeet006py @Apache-HBase @apurtell @virajjasani