Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-27406 Make "/prometheus" endpoint accessible from HBase UI #4833

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

lucakovacs
Copy link
Contributor

Before this change, Prometheus metrics were only accessible via the '/prometheus' endpoint.

I made changes in the UI, so instead of Metrics Dump there's a dropdown menu called Metrics with the JMX and Prometheus metrics.

I also included the metrics description, so there are four endpoints available from there:

  • JMX
  • JMX with description
  • Prometheus
  • Prometheus with description

Apache JIRA: https://issues.apache.org/jira/browse/HBASE-27406

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 18s master passed
+1 💚 spotless 0m 38s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 2s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 spotless 0m 36s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 21s The patch does not generate ASF License warnings.
8m 4s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4833
Optional Tests dupname asflicense javac spotless
uname Linux 801624ec7a90 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b68229c
Default Java Temurin-1.8.0_345-b01
Max. process+thread count 64 (vs. ulimit of 30000)
modules C: hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 56s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 20s master passed
+1 💚 javadoc 1m 1s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 13s the patch passed
+1 💚 javadoc 1m 0s the patch passed
_ Other Tests _
+1 💚 unit 213m 13s hbase-server in the patch passed.
+1 💚 unit 8m 43s hbase-thrift in the patch passed.
+1 💚 unit 3m 26s hbase-rest in the patch passed.
234m 55s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4833
Optional Tests javac javadoc unit
uname Linux 0c890954de29 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b68229c
Default Java Temurin-1.8.0_345-b01
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/testReport/
Max. process+thread count 2657 (vs. ulimit of 30000)
modules C: hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 2s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 28s master passed
+1 💚 javadoc 1m 15s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 16s the patch passed
+1 💚 javadoc 1m 19s the patch passed
_ Other Tests _
+1 💚 unit 238m 14s hbase-server in the patch passed.
+1 💚 unit 7m 12s hbase-thrift in the patch passed.
+1 💚 unit 4m 22s hbase-rest in the patch passed.
262m 39s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4833
Optional Tests javac javadoc unit
uname Linux 0d9ffc01c3e5 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b68229c
Default Java Eclipse Adoptium-11.0.16.1+1
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/testReport/
Max. process+thread count 2737 (vs. ulimit of 30000)
modules C: hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@meszibalu meszibalu merged commit dffc8e0 into apache:master Oct 20, 2022
asfgit pushed a commit that referenced this pull request Oct 20, 2022
Signed-off-by: Andor Molnar <andor@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit dffc8e0)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
…e#4833)

Signed-off-by: Andor Molnar <andor@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit dffc8e0)
(cherry picked from commit a31b148)
Change-Id: Id24f0f4215fe5bd46a5ace61ae33c5ee9c1ecebb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants