HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature #485

mymeiyi · 2019-08-13T08:28:01Z

No description provided.

openinx · 2019-08-13T09:09:36Z

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java

@@ -319,19 +320,22 @@ void checkTempDir(final Path tmpdir, final Configuration c, final FileSystem fs)
        HFileArchiver.archiveRegions(c, fs, this.rootdir, tableDir,


The archiveRegions will archive all the hfiles and if all successfull... Then it will remains some dirs such as /.tmp/data/ns/table ? If we've deleted a namespace or table , the ns or table dir under .tmp will be also removed (If no, the we will remain many useless dir, that's not good) ?
Another concern is : if hfiles archiving failure happen and enable the snapshot acl sync, will we remain much hfiles under the .tmp dir ? will be storage consuming if so... maybe we need a UT ?

The tmp namespace or table dirs are deleted if namespace or table are dropped. There are UTs in TestSnapshotScannerHDFSAclController to check it.
Add a warn log to record unarchived regions, if this problem happens in practice, we can fix this? And add UT in TestSnapshotScannerHDFSAclController.

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java

Apache-HBase · 2019-08-13T11:23:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	39	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	334	master passed
+1	compile	57	master passed
+1	checkstyle	78	master passed
+1	shadedjars	290	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	38	master passed
0	spotbugs	260	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	259	master passed
		_ Patch Compile Tests _
+1	mvninstall	298	the patch passed
+1	compile	53	the patch passed
+1	javac	53	the patch passed
+1	checkstyle	75	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	273	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	957	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	33	the patch passed
+1	findbugs	282	the patch passed
		_ Other Tests _
+1	unit	6928	hbase-server in the patch passed.
+1	asflicense	26	The patch does not generate ASF License warnings.
		10418

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/1/artifact/out/Dockerfile
GITHUB PR	#485
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 2c0c387df2d0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh
git revision	master / `9d6a653`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/1/testReport/
Max. process+thread count	4816 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-13T13:08:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	226	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	372	master passed
+1	compile	62	master passed
+1	checkstyle	95	master passed
+1	shadedjars	330	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	47	master passed
0	spotbugs	298	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	296	master passed
		_ Patch Compile Tests _
+1	mvninstall	342	the patch passed
+1	compile	60	the patch passed
+1	javac	60	the patch passed
+1	checkstyle	90	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	307	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1046	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	36	the patch passed
+1	findbugs	268	the patch passed
		_ Other Tests _
-1	unit	10894	hbase-server in the patch failed.
+1	asflicense	32	The patch does not generate ASF License warnings.
		14934

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide3

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/2/artifact/out/Dockerfile
GITHUB PR	#485
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 865df48e1831 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh
git revision	master / `07ab9ed`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/2/testReport/
Max. process+thread count	4478 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-13T14:48:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	231	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	474	master passed
+1	compile	83	master passed
+1	checkstyle	78	master passed
+1	shadedjars	324	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	57	master passed
0	spotbugs	281	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	276	master passed
		_ Patch Compile Tests _
+1	mvninstall	448	the patch passed
+1	compile	58	the patch passed
+1	javac	58	the patch passed
+1	checkstyle	75	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	277	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1001	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	47	the patch passed
+1	findbugs	265	the patch passed
		_ Other Tests _
-1	unit	12641	hbase-server in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		16861

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide3

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/3/artifact/out/Dockerfile
GITHUB PR	#485
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e9f095acc5c6 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh
git revision	master / `8c1edb3`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/3/testReport/
Max. process+thread count	4998 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-13T22:57:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	82	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	412	master passed
+1	compile	61	master passed
+1	checkstyle	91	master passed
+1	shadedjars	327	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	45	master passed
0	spotbugs	302	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	298	master passed
		_ Patch Compile Tests _
+1	mvninstall	360	the patch passed
+1	compile	56	the patch passed
+1	javac	56	the patch passed
+1	checkstyle	89	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	300	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1338	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	92	the patch passed
+1	findbugs	581	the patch passed
		_ Other Tests _
-1	unit	11269	hbase-server in the patch failed.
+1	asflicense	25	The patch does not generate ASF License warnings.
		16047

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/4/artifact/out/Dockerfile
GITHUB PR	#485
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b74a7b405420 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh
git revision	master / `e69af5a`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/4/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/4/testReport/
Max. process+thread count	4940 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/4/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-14T03:14:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	112	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	376	master passed
+1	compile	57	master passed
+1	checkstyle	90	master passed
+1	shadedjars	291	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	38	master passed
0	spotbugs	265	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	263	master passed
		_ Patch Compile Tests _
+1	mvninstall	336	the patch passed
+1	compile	60	the patch passed
+1	javac	60	the patch passed
+1	checkstyle	88	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	304	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1052	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	37	the patch passed
+1	findbugs	287	the patch passed
		_ Other Tests _
-1	unit	12004	hbase-server in the patch failed.
+1	asflicense	33	The patch does not generate ASF License warnings.
		15847

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAsyncRegionAdminApi

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/5/artifact/out/Dockerfile
GITHUB PR	#485
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b97c032bf2ed 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485@2/out/precommit/personality/provided.sh
git revision	master / `27ed2ac`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/5/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/5/testReport/
Max. process+thread count	4743 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-14T13:40:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	36	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	325	master passed
+1	compile	54	master passed
+1	checkstyle	77	master passed
+1	shadedjars	271	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	38	master passed
0	spotbugs	246	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	243	master passed
		_ Patch Compile Tests _
+1	mvninstall	297	the patch passed
+1	compile	50	the patch passed
+1	javac	50	the patch passed
-1	checkstyle	73	hbase-server: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	269	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	918	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	35	the patch passed
+1	findbugs	244	the patch passed
		_ Other Tests _
+1	unit	6862	hbase-server in the patch passed.
+1	asflicense	25	The patch does not generate ASF License warnings.
		10201

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/6/artifact/out/Dockerfile
GITHUB PR	#485
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d1f755e8aea1 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh
git revision	master / `27ed2ac`
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/6/artifact/out/diff-checkstyle-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/6/testReport/
Max. process+thread count	4872 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-14T20:04:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	325	master passed
+1	compile	51	master passed
+1	checkstyle	74	master passed
+1	shadedjars	273	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	master passed
0	spotbugs	248	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	246	master passed
		_ Patch Compile Tests _
+1	mvninstall	298	the patch passed
+1	compile	53	the patch passed
+1	javac	53	the patch passed
-1	checkstyle	74	hbase-server: The patch generated 1 new + 12 unchanged - 0 fixed = 13 total (was 12)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	264	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	915	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	32	the patch passed
+1	findbugs	239	the patch passed
		_ Other Tests _
+1	unit	7131	hbase-server in the patch passed.
+1	asflicense	32	The patch does not generate ASF License warnings.
		10451

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/7/artifact/out/Dockerfile
GITHUB PR	#485
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 1407a5b3e703 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh
git revision	master / `53db390`
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/7/artifact/out/diff-checkstyle-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/7/testReport/
Max. process+thread count	4042 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/7/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…sed for user scan snapshot feature

Apache-HBase · 2019-08-15T05:43:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	318	master passed
+1	compile	51	master passed
+1	checkstyle	71	master passed
+1	shadedjars	260	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	33	master passed
0	spotbugs	243	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	242	master passed
		_ Patch Compile Tests _
+1	mvninstall	294	the patch passed
+1	compile	53	the patch passed
+1	javac	53	the patch passed
+1	checkstyle	70	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	264	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	895	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	31	the patch passed
+1	findbugs	250	the patch passed
		_ Other Tests _
-1	unit	8921	hbase-server in the patch failed.
+1	asflicense	27	The patch does not generate ASF License warnings.
		12182

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/9/artifact/out/Dockerfile
GITHUB PR	#485
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 98c3fbd06017 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh
git revision	master / `d9d5f69`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/9/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/9/testReport/
Max. process+thread count	4883 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/9/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-15T07:29:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	29	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	354	master passed
+1	compile	59	master passed
+1	checkstyle	91	master passed
+1	shadedjars	308	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	38	master passed
0	spotbugs	286	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	284	master passed
		_ Patch Compile Tests _
+1	mvninstall	328	the patch passed
+1	compile	62	the patch passed
+1	javac	62	the patch passed
+1	checkstyle	87	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	297	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1021	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	39	the patch passed
+1	findbugs	290	the patch passed
		_ Other Tests _
-1	unit	11431	hbase-server in the patch failed.
+1	asflicense	26	The patch does not generate ASF License warnings.
		15156

Reason	Tests
Failed junit tests	hadoop.hbase.snapshot.TestFlushSnapshotFromClient
	hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/10/artifact/out/Dockerfile
GITHUB PR	#485
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux da8b701f9f52 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh
git revision	master / `8ffc45a`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/10/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/10/testReport/
Max. process+thread count	4667 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/10/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-15T07:33:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	96	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	361	master passed
+1	compile	58	master passed
+1	checkstyle	91	master passed
+1	shadedjars	297	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	41	master passed
0	spotbugs	302	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	298	master passed
		_ Patch Compile Tests _
+1	mvninstall	346	the patch passed
+1	compile	64	the patch passed
+1	javac	64	the patch passed
+1	checkstyle	102	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	315	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1232	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	45	the patch passed
+1	findbugs	332	the patch passed
		_ Other Tests _
-1	unit	17582	hbase-server in the patch failed.
+1	asflicense	38	The patch does not generate ASF License warnings.
		21805

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAsyncTableAdminApi3
	hadoop.hbase.regionserver.TestRegionReplicaFailover
	hadoop.hbase.client.TestAdmin2
	hadoop.hbase.master.TestMasterShutdown
	hadoop.hbase.client.TestCloneSnapshotFromClientNormal
	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.master.assignment.TestOpenRegionProcedureHang
	hadoop.hbase.client.TestAsyncReplicationAdminApiWithClusters
	hadoop.hbase.client.TestSnapshotTemporaryDirectory

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/8/artifact/out/Dockerfile
GITHUB PR	#485
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux be5c109ad6db 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh
git revision	master / `53db390`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/8/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/8/testReport/
Max. process+thread count	4965 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/8/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-16T00:41:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	40	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	357	master passed
+1	compile	55	master passed
+1	checkstyle	73	master passed
+1	shadedjars	264	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	36	master passed
0	spotbugs	266	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	264	master passed
		_ Patch Compile Tests _
+1	mvninstall	279	the patch passed
+1	compile	54	the patch passed
+1	javac	54	the patch passed
+1	checkstyle	70	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	264	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	912	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	34	the patch passed
+1	findbugs	271	the patch passed
		_ Other Tests _
-1	unit	9343	hbase-server in the patch failed.
+1	asflicense	28	The patch does not generate ASF License warnings.
		12702

Reason	Tests
Failed junit tests	hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/11/artifact/out/Dockerfile
GITHUB PR	#485
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 851b8d201dc9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-485/out/precommit/personality/provided.sh
git revision	master / `edf6f68`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/11/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/11/testReport/
Max. process+thread count	4636 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-485/11/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…sed for user scan snapshot feature (#485)

…sed for user scan snapshot feature (apache#485)

openinx reviewed Aug 13, 2019

View reviewed changes

mymeiyi force-pushed the hdfs-acl-tmp-dir branch from 2b6d2bf to c8e1319 Compare August 14, 2019 10:48

HBASE-22842 Tmp directory should not be deleted when master restart u…

f3d1696

…sed for user scan snapshot feature

mymeiyi force-pushed the hdfs-acl-tmp-dir branch from c8e1319 to f3d1696 Compare August 15, 2019 01:26

openinx approved these changes Aug 15, 2019

View reviewed changes

mymeiyi merged commit 60971be into apache:master Aug 16, 2019

mymeiyi pushed a commit that referenced this pull request Aug 16, 2019

HBASE-22842 Tmp directory should not be deleted when master restart u…

3ff3938

…sed for user scan snapshot feature (#485)

mymeiyi deleted the hdfs-acl-tmp-dir branch September 4, 2019 06:48

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020

HBASE-22842 Tmp directory should not be deleted when master restart u…

5d3f03a

…sed for user scan snapshot feature (apache#485)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature #485

HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature #485

mymeiyi commented Aug 13, 2019

openinx Aug 13, 2019

mymeiyi Aug 14, 2019

Apache-HBase commented Aug 13, 2019

Apache-HBase commented Aug 13, 2019

Apache-HBase commented Aug 13, 2019

Apache-HBase commented Aug 13, 2019

Apache-HBase commented Aug 14, 2019

Apache-HBase commented Aug 14, 2019

Apache-HBase commented Aug 14, 2019

Apache-HBase commented Aug 15, 2019

Apache-HBase commented Aug 15, 2019

Apache-HBase commented Aug 15, 2019

Apache-HBase commented Aug 16, 2019

		@@ -319,19 +320,22 @@ void checkTempDir(final Path tmpdir, final Configuration c, final FileSystem fs)
		HFileArchiver.archiveRegions(c, fs, this.rootdir, tableDir,

HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature #485

HBASE-22842 Tmp directory should not be deleted when master restart used for user scan snapshot feature #485

Conversation

mymeiyi commented Aug 13, 2019

openinx Aug 13, 2019

Choose a reason for hiding this comment

mymeiyi Aug 14, 2019

Choose a reason for hiding this comment

Apache-HBase commented Aug 13, 2019

Apache-HBase commented Aug 13, 2019

Apache-HBase commented Aug 13, 2019

Apache-HBase commented Aug 13, 2019

Apache-HBase commented Aug 14, 2019

Apache-HBase commented Aug 14, 2019

Apache-HBase commented Aug 14, 2019

Apache-HBase commented Aug 15, 2019

Apache-HBase commented Aug 15, 2019

Apache-HBase commented Aug 15, 2019

Apache-HBase commented Aug 16, 2019