New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27449 Use xmllint to parse version and revision in release scripts #4850
Conversation
One of the disadvantage is that, you need to install xmllint when running do-release-docker, because we need to parse pom.xml to get the version when receiving user input, which is before we enter the docker container... For ubuntu users, |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@ndimiduk I changed the implementatioin for maven_set_version. I use parse_version to test whether the version if literally '${revision}', if so, we will use versions:set-property, otherwise we use versions:set. I think this is better as when we change more projects to use ${revision} placeholder, we do not need to change the release scripts. WDYT? And I tried locally, the scripts could successfully generate 2.5.2 release and 3.0.0-alpha-4 release, in the dry run mode. Thanks. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup here too.
Also upgrade our Dockerfile for release scripts to use ubuntu 22.04, maven 3.8.6 and yetus 0.14.1. Use python3 only.
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Also upgrade our Dockerfile for release scripts to use ubuntu 22.04, maven 3.8.6 and yetus 0.14.1.
Use python3 as much as possible.