-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27479 fix flaky test testClone in TestTaskMonitor #4876
Conversation
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR and letting us know this great tool for asserting json!
hbase-server/pom.xml
Outdated
<dependency> | ||
<groupId>org.skyscreamer</groupId> | ||
<artifactId>jsonassert</artifactId> | ||
<version>1.5.1</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better first add this to the parent pom, in the dependencyManagement section, and then reference it here, without specifying the version, as maybe in the future we also need to use this in other mdules, epsecially the hbase-rest module.
And please run |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
When I ran |
Just try mvn spotless:apply again and commit what is changed. At least there are still lines end with whitespace which is not allowed. Thanks. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Hi I tried |
Seems the latest PR is fine. There are test failure s but should not be related, just some flaky tests. |
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a2075f5)
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a2075f5)
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit a2075f5)
testClone
is detected as flaky by NonDex since the origin task monitor and the cloned one are represented as JSON objects, which are in a non-deterministic order. Therefore, I used JSONAssert to check if they are equal instead.