-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27495 Improve HFileLinkCleaner to validate back reference links… #4887
Conversation
… ahead the next traverse
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
retest |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
private RegionInfo hriLink; | ||
private Path archiveDir; | ||
private Path archiveStoreDir; | ||
private Path familyPath; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit. This is only used in configureDirectoriesAndLinks, can be local.
private String hfileLinkName; | ||
private Path linkBackRefDir; | ||
private Path linkBackRef; | ||
private FileStatus[] backRefs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit. Can be a local variable. Only used in createLink.
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
… ahead the next traverse (#4887) Signed-off-by: Peter Somogyi <psomogyi@apache.org> Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
… ahead the next traverse (#4887) Signed-off-by: Peter Somogyi <psomogyi@apache.org> Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
… ahead the next traverse