Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-27510 Should use 'org.apache.hbase.thirdparty.io.netty.tryRefle… #4898

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Nov 28, 2022

…ctionSetAccessible'

@Apache9 Apache9 self-assigned this Nov 28, 2022
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 59s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 2m 54s master passed
+1 💚 compile 4m 43s master passed
+1 💚 spotless 0m 42s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 30s the patch passed
+1 💚 compile 4m 40s the patch passed
+1 💚 javac 4m 40s the patch passed
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 8m 41s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚 spotless 0m 41s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
32m 2s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4898
Optional Tests dupname asflicense spotless shellcheck shelldocs javac hadoopcheck xml compile
uname Linux bd4c8805a675 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7fc4d99
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 73 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/console
versions git=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good but is the removal of --illegal-access=permit and other JDK module export changes required?

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 22s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 39s master passed
+1 💚 compile 2m 23s master passed
+1 💚 shadedjars 4m 59s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 15s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 17s the patch passed
+1 💚 compile 2m 13s the patch passed
+1 💚 javac 2m 14s the patch passed
+1 💚 shadedjars 4m 48s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 10s the patch passed
_ Other Tests _
+1 💚 unit 286m 25s root in the patch passed.
319m 29s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4898
Optional Tests javac javadoc unit shadedjars compile
uname Linux f37171c33df4 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7fc4d99
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/testReport/
Max. process+thread count 4743 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 40s master passed
+1 💚 compile 1m 37s master passed
+1 💚 shadedjars 3m 47s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 25s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 8s the patch passed
+1 💚 compile 1m 35s the patch passed
+1 💚 javac 1m 35s the patch passed
+1 💚 shadedjars 3m 44s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 24s the patch passed
_ Other Tests _
+1 💚 unit 371m 58s root in the patch passed.
397m 44s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4898
Optional Tests javac javadoc unit shadedjars compile
uname Linux f4e419e7c898 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7fc4d99
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/testReport/
Max. process+thread count 4697 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4898/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor Author

Apache9 commented Nov 29, 2022

The change looks good but is the removal of --illegal-access=permit and other JDK module export changes required?

Java17 removes the support of --illegal-access support, so we have already removed this flag in pom when running UTs, in this PR I just align the flags in bin/hbase and pom.xml.

Thanks.

@Apache9 Apache9 merged commit 3ffc0b5 into apache:master Nov 29, 2022
Apache9 added a commit that referenced this pull request Nov 29, 2022
…ctionSetAccessible' (#4898)

Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit 3ffc0b5)
Apache9 added a commit that referenced this pull request Nov 29, 2022
…ctionSetAccessible' (#4898)

Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit 3ffc0b5)
stoty pushed a commit to stoty/hbase that referenced this pull request Dec 12, 2023
…ctionSetAccessible' (apache#4898)

Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit 3ffc0b5)
stoty pushed a commit to stoty/hbase that referenced this pull request Dec 12, 2023
…ctionSetAccessible' (apache#4898)

Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit 3ffc0b5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants