HBASE-22819 Automatically migrate the rs group config for table after… #498

Apache9 · 2019-08-15T14:59:00Z

Apache-HBase · 2019-08-15T21:21:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	93	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-22514 Compile Tests _
0	mvndep	40	Maven dependency ordering for branch
+1	mvninstall	313	HBASE-22514 passed
+1	compile	73	HBASE-22514 passed
+1	checkstyle	96	HBASE-22514 passed
+1	shadedjars	271	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	53	HBASE-22514 passed
0	spotbugs	269	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	315	HBASE-22514 passed
		_ Patch Compile Tests _
0	mvndep	14	Maven dependency ordering for patch
+1	mvninstall	289	the patch passed
+1	compile	78	the patch passed
+1	javac	78	the patch passed
-1	checkstyle	73	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	270	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	974	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	52	the patch passed
+1	findbugs	337	the patch passed
		_ Other Tests _
+1	unit	175	hbase-common in the patch passed.
-1	unit	18795	hbase-server in the patch failed.
+1	asflicense	94	The patch does not generate ASF License warnings.
		22854

Reason	Tests
Failed junit tests	hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.rsgroup.TestMigrateRSGroupInfo
	hadoop.hbase.namespace.TestNamespaceAuditor
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
	hadoop.hbase.client.TestCloneSnapshotFromClientNormal
	hadoop.hbase.client.TestAdmin1

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/1/artifact/out/Dockerfile
GITHUB PR	#498
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 20e31fc53cb5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-498/out/precommit/personality/provided.sh
git revision	HBASE-22514 / `07fe41d`
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/1/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/1/testReport/
Max. process+thread count	4934 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

sunhelly · 2019-08-16T06:26:44Z

hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java

+          .setRegionServerGroup(groupInfo.getName()).build();
+        try {
+          pendingProcIds.add(
+            masterServices.modifyTable(tableName, newTd, HConstants.NO_NONCE, HConstants.NO_NONCE));


Should we just updating the meta row of the table to add group info, avoiding reopening regions when modify table?

Oh I thought about it again. New implementation will make tables all in the default group until migrating them to their belongs groups. So reopening maybe necessary.

Yes, this is the safest way...

Apache-HBase · 2019-08-16T08:54:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	42	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-22514 Compile Tests _
0	mvndep	38	Maven dependency ordering for branch
+1	mvninstall	430	HBASE-22514 passed
+1	compile	101	HBASE-22514 passed
+1	checkstyle	138	HBASE-22514 passed
+1	shadedjars	352	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	68	HBASE-22514 passed
0	spotbugs	346	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	405	HBASE-22514 passed
		_ Patch Compile Tests _
0	mvndep	18	Maven dependency ordering for patch
+1	mvninstall	404	the patch passed
+1	compile	97	the patch passed
+1	javac	97	the patch passed
+1	checkstyle	137	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	360	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1232	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	64	the patch passed
+1	findbugs	425	the patch passed
		_ Other Tests _
+1	unit	212	hbase-common in the patch passed.
-1	unit	8899	hbase-server in the patch failed.
+1	asflicense	47	The patch does not generate ASF License warnings.
		13972

Reason	Tests
Failed junit tests	hadoop.hbase.security.token.TestZKSecretWatcher

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/2/artifact/out/Dockerfile
GITHUB PR	#498
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d1fa5b5d721d 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-498/out/precommit/personality/provided.sh
git revision	HBASE-22514 / `07fe41d`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/2/testReport/
Max. process+thread count	4344 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-16T12:30:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	88	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-22514 Compile Tests _
0	mvndep	36	Maven dependency ordering for branch
+1	mvninstall	361	HBASE-22514 passed
+1	compile	87	HBASE-22514 passed
+1	checkstyle	121	HBASE-22514 passed
+1	shadedjars	311	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	64	HBASE-22514 passed
0	spotbugs	292	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	347	HBASE-22514 passed
		_ Patch Compile Tests _
0	mvndep	17	Maven dependency ordering for patch
+1	mvninstall	351	the patch passed
+1	compile	87	the patch passed
+1	javac	87	the patch passed
+1	checkstyle	117	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	306	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1064	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	59	the patch passed
+1	findbugs	355	the patch passed
		_ Other Tests _
+1	unit	181	hbase-common in the patch passed.
+1	unit	12187	hbase-server in the patch passed.
+1	asflicense	46	The patch does not generate ASF License warnings.
		16631

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/3/artifact/out/Dockerfile
GITHUB PR	#498
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 1ea80eb328bc 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-498/out/precommit/personality/provided.sh
git revision	HBASE-22514 / `07fe41d`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/3/testReport/
Max. process+thread count	4217 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-16T16:27:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	87	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-22514 Compile Tests _
0	mvndep	41	Maven dependency ordering for branch
+1	mvninstall	454	HBASE-22514 passed
+1	compile	104	HBASE-22514 passed
+1	checkstyle	124	HBASE-22514 passed
+1	shadedjars	387	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	72	HBASE-22514 passed
0	spotbugs	321	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	380	HBASE-22514 passed
		_ Patch Compile Tests _
0	mvndep	18	Maven dependency ordering for patch
+1	mvninstall	409	the patch passed
+1	compile	96	the patch passed
+1	javac	96	the patch passed
+1	checkstyle	130	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	372	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1232	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	63	the patch passed
+1	findbugs	404	the patch passed
		_ Other Tests _
+1	unit	196	hbase-common in the patch passed.
-1	unit	18556	hbase-server in the patch failed.
+1	asflicense	153	The patch does not generate ASF License warnings.
		23831

Reason	Tests
Failed junit tests	hadoop.hbase.rsgroup.TestMigrateRSGroupInfo
	hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
	hadoop.hbase.tool.TestSecureBulkLoadHFiles
	hadoop.hbase.snapshot.TestFlushSnapshotFromClient
	hadoop.hbase.client.TestCloneSnapshotFromClientNormal
	hadoop.hbase.namespace.TestNamespaceAuditor
	hadoop.hbase.tool.TestBulkLoadHFiles

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/5/artifact/out/Dockerfile
GITHUB PR	#498
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux bbf774a75aeb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-498/out/precommit/personality/provided.sh
git revision	HBASE-22514 / `32a2015`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/5/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/5/testReport/
Max. process+thread count	4500 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-18T10:02:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	61	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-22514 Compile Tests _
0	mvndep	35	Maven dependency ordering for branch
+1	mvninstall	329	HBASE-22514 passed
+1	compile	79	HBASE-22514 passed
+1	checkstyle	104	HBASE-22514 passed
+1	shadedjars	283	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	55	HBASE-22514 passed
0	spotbugs	272	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	322	HBASE-22514 passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	367	the patch passed
+1	compile	79	the patch passed
+1	javac	79	the patch passed
+1	checkstyle	101	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	317	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1005	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	54	the patch passed
+1	findbugs	340	the patch passed
		_ Other Tests _
+1	unit	172	hbase-common in the patch passed.
-1	unit	16315	hbase-server in the patch failed.
+1	asflicense	55	The patch does not generate ASF License warnings.
		20536

Reason	Tests
Failed junit tests	hadoop.hbase.rsgroup.TestMigrateRSGroupInfo
	hadoop.hbase.client.TestAsyncTableGetMultiThreaded
	hadoop.hbase.regionserver.TestSplitTransactionOnCluster

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/6/artifact/out/Dockerfile
GITHUB PR	#498
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux a283e04fde9b 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-498/out/precommit/personality/provided.sh
git revision	HBASE-22514 / `8660b52`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/6/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/6/testReport/
Max. process+thread count	4705 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-18T16:09:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	534	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-22514 Compile Tests _
0	mvndep	83	Maven dependency ordering for branch
+1	mvninstall	769	HBASE-22514 passed
+1	compile	587	HBASE-22514 passed
+1	checkstyle	295	HBASE-22514 passed
+1	shadedjars	832	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	141	HBASE-22514 passed
0	spotbugs	82	Used deprecated FindBugs config; considering switching to SpotBugs.
-1	findbugs	1130	hbase-server in HBASE-22514 failed.
		_ Patch Compile Tests _
0	mvndep	115	Maven dependency ordering for patch
+1	mvninstall	627	the patch passed
+1	compile	116	the patch passed
+1	javac	116	the patch passed
+1	checkstyle	136	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	384	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1543	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	77	the patch passed
-1	findbugs	686	hbase-server in the patch failed.
		_ Other Tests _
+1	unit	205	hbase-common in the patch passed.
-1	unit	2699	hbase-server in the patch failed.
+1	asflicense	62	The patch does not generate ASF License warnings.
		11844

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAsyncAccessControlAdminApi

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/7/artifact/out/Dockerfile
GITHUB PR	#498
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 34365d222f30 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-498/out/precommit/personality/provided.sh
git revision	HBASE-22514 / `8660b52`
Default Java	1.8.0_181
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/7/artifact/out/branch-findbugs-hbase-server.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/7/artifact/out/patch-findbugs-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/7/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/7/testReport/
Max. process+thread count	748 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/7/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-20T05:28:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	100	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-22514 Compile Tests _
0	mvndep	35	Maven dependency ordering for branch
+1	mvninstall	357	HBASE-22514 passed
+1	compile	93	HBASE-22514 passed
+1	checkstyle	124	HBASE-22514 passed
+1	shadedjars	334	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	66	HBASE-22514 passed
0	spotbugs	293	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	345	HBASE-22514 passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	331	the patch passed
+1	compile	86	the patch passed
+1	javac	86	the patch passed
+1	checkstyle	115	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	304	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1045	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	58	the patch passed
+1	findbugs	408	the patch passed
		_ Other Tests _
+1	unit	203	hbase-common in the patch passed.
+1	unit	9506	hbase-server in the patch passed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		13989

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/9/artifact/out/Dockerfile
GITHUB PR	#498
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux a15ee86a38fa 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-498/out/precommit/personality/provided.sh
git revision	HBASE-22514 / `8660b52`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/9/testReport/
Max. process+thread count	4031 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/9/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

infraio · 2019-08-20T06:56:10Z

hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java

+        TableDescriptor newTd = TableDescriptorBuilder.newBuilder(oldTd)
+          .setRegionServerGroup(groupInfo.getName()).build();
+        try {
+          pendingProcIds.add(


For the user which used RSGroup feature a lot, when user restart master with new code, this migrate thing will reopen all regions... This is not friendly for user? Can we finish this job by a tool? Only use the tool to change the TableDescriptor first, then upgrade cluster to new version code.

I think doing things automatically will be more friendly? As users may forget to user the tool and all the table configs will be ignored...

Need a new issue to add document for this? And add a config for maxConcurrency? If user decide to upgrade, user can use this config to reduce the impact for availability.

Apache-HBase · 2019-08-23T19:05:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	111	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ HBASE-22514 Compile Tests _
0	mvndep	39	Maven dependency ordering for branch
+1	mvninstall	364	HBASE-22514 passed
+1	compile	89	HBASE-22514 passed
+1	checkstyle	118	HBASE-22514 passed
+1	shadedjars	287	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	56	HBASE-22514 passed
0	spotbugs	291	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	343	HBASE-22514 passed
		_ Patch Compile Tests _
0	mvndep	16	Maven dependency ordering for patch
+1	mvninstall	305	the patch passed
+1	compile	77	the patch passed
+1	javac	77	the patch passed
+1	checkstyle	107	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	289	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	982	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	56	the patch passed
+1	findbugs	351	the patch passed
		_ Other Tests _
+1	unit	172	hbase-common in the patch passed.
-1	unit	15202	hbase-server in the patch failed.
+1	asflicense	57	The patch does not generate ASF License warnings.
		19429

Reason	Tests
Failed junit tests	hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
	hadoop.hbase.client.TestFromClientSide3

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/12/artifact/out/Dockerfile
GITHUB PR	#498
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux fe66daec900b 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-498/out/precommit/personality/provided.sh
git revision	HBASE-22514 / `4c570ed`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/12/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/12/testReport/
Max. process+thread count	4720 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/12/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java

infraio · 2019-08-24T00:24:01Z

hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupUtil.java

-  private static Optional<RSGroupInfo> getRSGroupInfo(MasterServices master, GetRSGroup getter,
+  /**
+   * Will try to get the rsgroup from {@link TableDescriptor} first, and then try to get the rsgroup
+   * from the {@link NamespaceDescriptor}. If still not present, return empty.


Seems the impl didn't get rsgroup from NamespaceDescriptor?

See below, you need to show all the code, include the unmodified pieces.

hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java

infraio · 2019-08-24T00:49:07Z

hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java

+        LOG.info("Start migrating table rs group config");
+        while (!masterServices.isStopped()) {
+          Collection<RSGroupInfo> groups = holder.groupName2Group.values();
+          boolean hasTables = groups.stream().anyMatch(r -> !r.getTables().isEmpty());


When restart master again, how to avoid migrate again?

Please see the above method, we have lots of checks, and once we finish migrate one group, we will update the RSGroupInfo to remove all the tables in it.

… HBASE-22695

Apache-HBase · 2019-08-24T21:47:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	113	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ HBASE-22514 Compile Tests _
0	mvndep	37	Maven dependency ordering for branch
+1	mvninstall	391	HBASE-22514 passed
+1	compile	102	HBASE-22514 passed
+1	checkstyle	128	HBASE-22514 passed
+1	shadedjars	344	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	63	HBASE-22514 passed
0	spotbugs	293	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	344	HBASE-22514 passed
		_ Patch Compile Tests _
0	mvndep	16	Maven dependency ordering for patch
+1	mvninstall	336	the patch passed
+1	compile	97	the patch passed
+1	javac	97	the patch passed
+1	checkstyle	122	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	345	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1185	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	58	the patch passed
+1	findbugs	353	the patch passed
		_ Other Tests _
+1	unit	184	hbase-common in the patch passed.
+1	unit	14674	hbase-server in the patch passed.
+1	asflicense	51	The patch does not generate ASF License warnings.
		19420

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/14/artifact/out/Dockerfile
GITHUB PR	#498
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 46f9ecc28129 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-498/out/precommit/personality/provided.sh
git revision	HBASE-22514 / `02f48d5`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/14/testReport/
Max. process+thread count	4754 (vs. ulimit of 10000)
modules	C: hbase-common hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-498/14/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

… HBASE-22695 (apache#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

Apache9 force-pushed the HBASE-22819 branch from f99d7a0 to 9626e18 Compare August 16, 2019 03:53

sunhelly reviewed Aug 16, 2019

View reviewed changes

Apache9 force-pushed the HBASE-22819 branch from 9626e18 to 9e40796 Compare August 16, 2019 07:22

asfgit force-pushed the HBASE-22514 branch from 22147a0 to 32a2015 Compare August 16, 2019 09:01

Apache9 force-pushed the HBASE-22819 branch from 9e40796 to 5f91a98 Compare August 16, 2019 09:24

asfgit force-pushed the HBASE-22514 branch from 32a2015 to 8660b52 Compare August 18, 2019 04:14

Apache9 force-pushed the HBASE-22819 branch from 5f91a98 to bcc5aed Compare August 18, 2019 04:19

infraio reviewed Aug 20, 2019

View reviewed changes

asfgit force-pushed the HBASE-22514 branch from 8660b52 to 4c570ed Compare August 22, 2019 13:09

Apache9 force-pushed the HBASE-22819 branch from bcc5aed to f9d8f6e Compare August 22, 2019 15:06

infraio reviewed Aug 24, 2019

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java Outdated Show resolved Hide resolved

infraio reviewed Aug 24, 2019

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java Outdated Show resolved Hide resolved

infraio reviewed Aug 24, 2019

View reviewed changes

asfgit force-pushed the HBASE-22514 branch from 4c570ed to 02f48d5 Compare August 24, 2019 14:13

HBASE-22819 Automatically migrate the rs group config for table after…

e42105c

… HBASE-22695

Apache9 force-pushed the HBASE-22819 branch from f9d8f6e to e42105c Compare August 24, 2019 14:36

infraio approved these changes Aug 25, 2019

View reviewed changes

Apache9 merged commit 24f4913 into apache:HBASE-22514 Aug 25, 2019

asfgit pushed a commit that referenced this pull request Aug 25, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

4741f66

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Aug 27, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

548e8c4

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Sep 10, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

fbdafde

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Sep 11, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

23b6a27

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Sep 11, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

3cb0d3e

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Sep 16, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

5d652cc

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Sep 17, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

a1930d5

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Sep 18, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

80d69c5

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Sep 20, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

363b97e

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Sep 24, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

87a1115

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Oct 5, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

a47d2b5

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Oct 28, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

af122d3

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Nov 5, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

c162c88

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Nov 10, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

3dc1b28

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Nov 13, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

db43492

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Dec 24, 2019

HBASE-22819 Automatically migrate the rs group config for table after H…

8dca9dc

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Feb 2, 2020

HBASE-22819 Automatically migrate the rs group config for table after H…

61fa836

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Feb 3, 2020

HBASE-22819 Automatically migrate the rs group config for table after H…

f682cc4

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Feb 4, 2020

HBASE-22819 Automatically migrate the rs group config for table after H…

571fa3d

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Feb 6, 2020

HBASE-22819 Automatically migrate the rs group config for table after H…

a96780f

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Feb 7, 2020

HBASE-22819 Automatically migrate the rs group config for table after H…

23f95cc

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Feb 8, 2020

HBASE-22819 Automatically migrate the rs group config for table after H…

d102331

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Feb 9, 2020

HBASE-22819 Automatically migrate the rs group config for table after H…

ed6c740

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Feb 12, 2020

HBASE-22819 Automatically migrate the rs group config for table after H…

f1cba5c

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Feb 20, 2020

HBASE-22819 Automatically migrate the rs group config for table after H…

4e70293

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Feb 22, 2020

HBASE-22819 Automatically migrate the rs group config for table after H…

72ecdce

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Feb 25, 2020

HBASE-22819 Automatically migrate the rs group config for table after H…

0924d69

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Feb 26, 2020

HBASE-22819 Automatically migrate the rs group config for table after H…

34d3983

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

asfgit pushed a commit that referenced this pull request Feb 29, 2020

HBASE-22819 Automatically migrate the rs group config for table after H…

7512445

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

Apache9 added a commit that referenced this pull request Mar 2, 2020

HBASE-22819 Automatically migrate the rs group config for table after H…

b3399ef

…BASE-22695 (#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-22819 Automatically migrate the rs group config for table after…

b38a793

… HBASE-22695 (apache#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-22819 Automatically migrate the rs group config for table after…

9573010

… HBASE-22695 (apache#498) Signed-off-by: Guanghao Zhang <zghao@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-22819 Automatically migrate the rs group config for table after… #498

HBASE-22819 Automatically migrate the rs group config for table after… #498

Apache9 commented Aug 15, 2019

Apache-HBase commented Aug 15, 2019

sunhelly Aug 16, 2019

sunhelly Aug 16, 2019

Apache9 Aug 16, 2019

Apache-HBase commented Aug 16, 2019

Apache-HBase commented Aug 16, 2019

Apache-HBase commented Aug 16, 2019

Apache-HBase commented Aug 18, 2019

Apache-HBase commented Aug 18, 2019

Apache-HBase commented Aug 20, 2019

infraio Aug 20, 2019

Apache9 Aug 20, 2019

infraio Aug 20, 2019

Apache-HBase commented Aug 23, 2019

infraio Aug 24, 2019

Apache9 Aug 24, 2019

infraio Aug 24, 2019

Apache9 Aug 24, 2019

Apache-HBase commented Aug 24, 2019

HBASE-22819 Automatically migrate the rs group config for table after… #498

HBASE-22819 Automatically migrate the rs group config for table after… #498

Conversation

Apache9 commented Aug 15, 2019

Apache-HBase commented Aug 15, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Apache-HBase commented Aug 16, 2019

Apache-HBase commented Aug 16, 2019

Apache-HBase commented Aug 16, 2019

Apache-HBase commented Aug 18, 2019

Apache-HBase commented Aug 18, 2019

Apache-HBase commented Aug 20, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Apache-HBase commented Aug 23, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Apache-HBase commented Aug 24, 2019