HBASE-27629 Let lock wait timeout to improve performance of SnapshotHFileCleaner #5020

petersomogyi · 2023-02-09T18:17:29Z

…FileCleaner Backport of HBASE-27043

taklwu

confirmed the change as same as 1aa07d5 , please free feel to merge once the precommit passes

Apache-HBase · 2023-02-09T22:51:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	3m 28s	branch-2.4 passed
+1 💚	compile	2m 34s	branch-2.4 passed
+1 💚	checkstyle	0m 36s	branch-2.4 passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 30s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 56s	the patch passed
+1 💚	compile	2m 16s	the patch passed
+1 💚	javac	2m 16s	the patch passed
+1 💚	checkstyle	0m 35s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 7s	Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 39s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		41m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5020
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 2693a94ea528 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `9236242`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2023-02-10T08:43:23Z

hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java

@@ -97,6 +98,8 @@ Collection<String> filesUnderSnapshot(final FileSystem fs, final Path snapshotDi
  private ImmutableMap<String, SnapshotDirectoryInfo> snapshots = ImmutableMap.of();
  private final Timer refreshTimer;

+  private static final int LOCK_TIMEOUT_MS = 30000;


Should we make it configurable? Just asking, I'm neutral on whether to introduce a configuration.

After HBASE-27590 I don't think it is necessary because the locking time is drastically reduced. Earlier I have seen the Failed to acquire write lock on taking snapshot after waiting 60000ms WARN messages continuously on this cluster.

Apache-HBase · 2023-02-13T10:25:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	3m 44s	branch-2.4 passed
+1 💚	compile	2m 47s	branch-2.4 passed
+1 💚	checkstyle	0m 41s	branch-2.4 passed
+1 💚	spotless	0m 47s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 55s	branch-2.4 passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	3m 24s	root in the patch failed.
+1 💚	compile	2m 22s	the patch passed
+1 💚	javac	2m 22s	the patch passed
+1 💚	checkstyle	0m 36s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	25m 25s	Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4.
+1 💚	spotless	0m 51s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 8s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		47m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5020
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux c0da80c8d514 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `8df3212`
Default Java	Eclipse Adoptium-11.0.17+8
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-02-13T12:44:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 23s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
-1 ❌	mvninstall	2m 25s	root in branch-2.4 failed.
+1 💚	compile	0m 35s	branch-2.4 passed
+1 💚	shadedjars	4m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 18s	the patch passed
+1 💚	compile	0m 36s	the patch passed
+1 💚	javac	0m 36s	the patch passed
+1 💚	shadedjars	4m 17s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	167m 46s	hbase-server in the patch passed.
		187m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5020
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 799e8aacfdfc 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `8df3212`
Default Java	Temurin-1.8.0_352-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/testReport/
Max. process+thread count	2576 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-02-13T12:54:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
+1 💚	mvninstall	3m 9s	branch-2.4 passed
+1 💚	compile	0m 43s	branch-2.4 passed
+1 💚	shadedjars	4m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 54s	the patch passed
+1 💚	compile	0m 43s	the patch passed
+1 💚	javac	0m 43s	the patch passed
+1 💚	shadedjars	4m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	174m 11s	hbase-server in the patch passed.
		197m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5020
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c3109f9fcdc4 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `8df3212`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/testReport/
Max. process+thread count	2376 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

petersomogyi · 2023-02-13T12:58:54Z

The mvninstall failures are strange and inconsistent. I was not able to reproduce it locally and the LICENSE file is not archived so I can't check what files are violating the licenses. This should be unrelated to this change.

HBASE-27629 Let lock wait timeout to improve performance of SnapshotH…

b2bd4a2

…FileCleaner Backport of HBASE-27043

petersomogyi requested review from taklwu and sunhelly February 9, 2023 18:17

taklwu approved these changes Feb 9, 2023

View reviewed changes

sunhelly approved these changes Feb 10, 2023

View reviewed changes

Apache9 reviewed Feb 10, 2023

View reviewed changes

petersomogyi merged commit c580835 into apache:branch-2.4 Feb 13, 2023

petersomogyi deleted the HBASE-27629 branch February 13, 2023 13:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27629 Let lock wait timeout to improve performance of SnapshotHFileCleaner #5020

HBASE-27629 Let lock wait timeout to improve performance of SnapshotHFileCleaner #5020

petersomogyi commented Feb 9, 2023

taklwu left a comment

Apache-HBase commented Feb 9, 2023

Apache9 Feb 10, 2023

petersomogyi Feb 13, 2023

Apache-HBase commented Feb 13, 2023

Apache-HBase commented Feb 13, 2023

Apache-HBase commented Feb 13, 2023

petersomogyi commented Feb 13, 2023

HBASE-27629 Let lock wait timeout to improve performance of SnapshotHFileCleaner #5020

HBASE-27629 Let lock wait timeout to improve performance of SnapshotHFileCleaner #5020

Conversation

petersomogyi commented Feb 9, 2023

taklwu left a comment

Choose a reason for hiding this comment

Apache-HBase commented Feb 9, 2023

Apache9 Feb 10, 2023

Choose a reason for hiding this comment

petersomogyi Feb 13, 2023

Choose a reason for hiding this comment

Apache-HBase commented Feb 13, 2023

Apache-HBase commented Feb 13, 2023

Apache-HBase commented Feb 13, 2023

petersomogyi commented Feb 13, 2023