HBASE-22870 reflection fails to access a private nested class #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you raise a related JIRA ticket? If not, please raise one first, it is easy for history tracking. |
hbase-2.1.5 will be deployed in our product environment, now, interface compablity, integration test and fault exercises are being performed, so more and more bugs will be exposed. I want to contribute bugfix, how can I do? It there a guide doc for new comer? |
|
HBASE-22870, is it yours? Please update the description in JIRA too. |
satanson
changed the title
@Reidddddd |
Reidddddd
requested changes
Aug 17, 2019
| @@ -3906,7 +3906,7 @@ public boolean isShutDown() { | |||
| /** | |||
| * Force to terminate region server when abort timeout. | |||
| */ | |||
| private static class SystemExitWhenAbortTimeout extends TimerTask { | |||
| public static class SystemExitWhenAbortTimeout extends TimerTask { | |||
There was a problem hiding this comment.
It is reasonable to keep it private since it is an inner task which should not be seen outside service.
I suggest using
getDeclaredConstructor().setAccessible(true).newInstance() to bypass it.
There was a problem hiding this comment.
ok, good suggest, setAccessible return void, so should write like this
Constructor<? extends TimerTask> timerTaskCtor =
Class.forName(conf.get(ABORT_TIMEOUT_TASK, SystemExitWhenAbortTimeout.class.getName()))
.asSubclass(TimerTask.class).getDeclaredConstructor();
timerTaskCtor.setAccessible(true);
abortTimeoutTask = timerTaskCtor.newInstance();
|
Let's wait some time to see if any other comment. I'll will commit it tomorrow if no further comment. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
commit |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HMaster crashes at org/apache/hadoop/hbase/regionserver/HRegionServer.java:1044
A private static nested class can not be instantiated via reflection.
code snippet
log in product environtment